From ada@jander.fl.net.au Wed Sep 29 02:20:21 1999
Return-Path: <ada@jander.fl.net.au>
Received: from jander.fl.net.au (jander.fl.net.au [202.181.0.27])
	by hub.freebsd.org (Postfix) with ESMTP id C805315169
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 29 Sep 1999 02:20:08 -0700 (PDT)
	(envelope-from ada@jander.fl.net.au)
Received: (from ada@localhost)
	by jander.fl.net.au (8.9.2/8.8.8) id TAA27125;
	Wed, 29 Sep 1999 19:20:07 +1000 (EST)
	(envelope-from ada)
Message-Id: <199909290920.TAA27125@jander.fl.net.au>
Date: Wed, 29 Sep 1999 19:20:07 +1000 (EST)
From: Ada Lim <ada@fl.net.au>
Sender: ada@jander.fl.net.au
Reply-To: ada@fl.net.au
To: FreeBSD-gnats-submit@freebsd.org
Subject: tzfile.h referenced in tzfile(5) doesn't exist
X-Send-Pr-Version: 3.2

>Number:         14035
>Category:       docs
>Synopsis:       tzfile.h referenced in tzfile(5) doesn't exist
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 29 02:30:00 PDT 1999
>Closed-Date:    Thu Jun 22 07:15:53 PDT 2000
>Last-Modified:  Thu Jun 22 07:18:43 PDT 2000
>Originator:     
>Release:        FreeBSD 3.1-STABLE i386
>Organization:
>Environment:
>Description:
 
 
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:

From: <jkoshy@FreeBSD.org>
To: freebsd-gnats-submit@freebsd.org, wollman@FreeBSD.org
Cc:  
Subject: Re: docs/14035: tzfile.h referenced in tzfile(5) doesn't exist
Date: Thu, 30 Sep 1999 00:33:46 -0700 (PDT)

 This is a multipart MIME message.
 
 --==_Exmh_-5370710300
 Content-Type: text/plain
 
 
 Looking at docs/14035, I came across the following anomalies in
 
 a) tzfile.5 refers to 4 4-byte quantities in the header, however
    the header file "tzfile.h" defines 6.  This bug is there is -CURRENT
    too.
 
 b) Missing word '20' in the description in -STABLE.
 
 c) The first field of the header is tzh_ttisgmtcnt in -STABLE (and in
    -CURRENT), not tzh_ttisstdcnt as claimed.
 
 The following patch for -STABLE corrects these errors and adds copyright
 info as a comment.  Could you please review?
 
 Koshy
 <jkoshy@freebsd.org>
 
 --==_Exmh_-5370710300
 Content-Type: text/plain ; name="patch"
 Content-Description: patch
 Content-Disposition: attachment; filename="patch"
 
 Index: tzfile.5
 ===================================================================
 RCS file: /home/ncvs/src/lib/libc/stdtime/tzfile.5,v
 retrieving revision 1.5
 diff -u -r1.5 tzfile.5
 --- tzfile.5	1998/05/10 21:21:01	1.5
 +++ tzfile.5	1999/09/30 12:20:23
 @@ -5,18 +5,20 @@
  .Nm tzfile
  .Nd timezone information
  .Sh SYNOPSIS
 -.Fd #include <tzfile.h>
 +.Fd #include "/usr/src/lib/libc/stdtime/tzfile.h"
  .Sh DESCRIPTION
  The time zone information files used by
  .Xr tzset 3
 -begin with bytes reserved for future use,
 -followed by four four-byte values
 +begin with 20 bytes reserved for future use,
 +followed by six four-byte values
  written in a ``standard'' byte order
  (the high-order byte of the value is written first).
  These values are,
  in order:
  .Pp
  .Bl -tag -compact -width tzh_ttisstdcnt
 +.It Li tzh_ttisgmtcnt
 +The number of UTC/local indicators stored in the file.
  .It Li tzh_ttisstdcnt
  The number of standard/wall indicators stored in the file.
  .It Li tzh_leapcnt
 @@ -119,3 +121,5 @@
  .Xr time2posix 3 ,
  .Xr zic 8
  .\" @(#)tzfile.5	7.2
 +.\" This file is in the public domain, so clarified as of
 +.\" 1996-06-05 by Arthur David Olson (arthur_david_olson@nih.gov).
 
 --==_Exmh_-5370710300--
 
 
 

From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
To: jkoshy@FreeBSD.org
Cc: freebsd-gnats-submit@FreeBSD.org, wollman@FreeBSD.org
Subject: Re: docs/14035: tzfile.h referenced in tzfile(5) doesn't exist
Date: Thu, 30 Sep 1999 10:44:24 -0400 (EDT)

 <<On Thu, 30 Sep 1999 00:33:46 -0700 (PDT), jkoshy@FreeBSD.org said:
 
 > a) tzfile.5 refers to 4 4-byte quantities in the header, however
 >    the header file "tzfile.h" defines 6.  This bug is there is -CURRENT
 >    too.
 
 tzfile(5) should not reference tzfile.h -- it's an internal header,
 not for public consumption.  tzfile.5 may well be more correct --
 there is some amount of version skew between libc and zic(8).  (For
 example, the current file format includes a magic number at the
 beginning of the file, which libc doesn't know about or check for.)
 
 -GAWollman
 
 --
 Garrett A. Wollman   | O Siem / We are all family / O Siem / We're all the same
 wollman@lcs.mit.edu  | O Siem / The fires of freedom 
 Opinions not those of| Dance in the burning flame
 MIT, LCS, CRS, or NSA|                     - Susan Aglukark and Chad Irschick
 
State-Changed-From-To: open->feedback 
State-Changed-By: nbm 
State-Changed-When: Tue Apr 18 05:15:24 PDT 2000 
State-Changed-Why:  
wollman's revision 1.6 import seems to clarify the location of this file. 
Is this still a problem? 
State-Changed-From-To: feedback->closed 
State-Changed-By: nbm 
State-Changed-When: Thu Jun 22 07:15:53 PDT 2000 
State-Changed-Why:  
Feedback timed out, and this looks clarified. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=14035 
>Unformatted:
