From nobody@FreeBSD.org  Mon Jul 27 10:07:41 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5536A1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Jul 2009 10:07:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 43EEC8FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Jul 2009 10:07:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n6RA7e5g071109
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Jul 2009 10:07:40 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n6RA7e4b071108;
	Mon, 27 Jul 2009 10:07:40 GMT
	(envelope-from nobody)
Message-Id: <200907271007.n6RA7e4b071108@www.freebsd.org>
Date: Mon, 27 Jul 2009 10:07:40 GMT
From: Patrick Lamaiziere <patfbsd@davenulle.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: asmc(4) documents dev.asmc.%d.light.control sysctl
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         137168
>Category:       docs
>Synopsis:       asmc(4) documents dev.asmc.%d.light.control sysctl
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 27 10:10:00 UTC 2009
>Closed-Date:    Mon Jul 27 13:37:23 UTC 2009
>Last-Modified:  Mon Jul 27 13:40:03 UTC 2009
>Originator:     Patrick Lamaiziere
>Release:        8.0-CURRENT/i386
>Organization:
>Environment:
FreeBSD baby-jane.lamaiziere.net 8.0-BETA2 FreeBSD 8.0-BETA2 #0: Tue Jul 21 08:04:55 CEST 2009     patrick@baby-jane.lamaiziere.net:/usr/obj/usr/src/sys/BABY-JANE  i386

>Description:
The description of the sysctl dev.asmc.%d.light.control (to set the light of the keyboard) is missing in the manual page.
>How-To-Repeat:

>Fix:
See the attached patch (feel free to fix my english thanks)


Patch attached with submission follows:

--- asmc.4.old	2009-07-27 11:16:50.000000000 +0200
+++ asmc.4	2009-07-27 12:04:55.000000000 +0200
@@ -25,7 +25,7 @@
 .\"
 .\" $FreeBSD: src/share/man/man4/asmc.4,v 1.4 2008/04/07 11:27:16 rpaulo Exp $
 .\"
-.Dd April 7, 2008
+.Dd July 27, 2009
 .Dt ASMC 4
 .Os
 .Sh NAME
@@ -72,15 +72,18 @@
 .Sh KEYBOARD BACKLIGHT
 On
 .Tn MacBook Pro
-systems, you can control the keyboard brightness by writing values to
+systems, you can control the keyboard brightness by writing value to
 the
+.Va dev.asmc.%d.light.control
+sysctl MIB
+.Pp
+Each of these sysctl MIBs contains the raw value returned by the left
+and right light sensors:
 .Va dev.asmc.%d.light.left
 or
 .Va dev.asmc.%d.light.right
 sysctl MIBs.
 .Pp
-Each of these sysctl MIBs contains the raw value returned by the left
-and right light sensors.
 .Sh TEMPERATURES
 The number of temperature sensors and their description varies among
 systems.


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: rpaulo 
State-Changed-When: Mon Jul 27 13:36:50 UTC 2009 
State-Changed-Why:  
Thanks for the patch. I just committed it to HEAD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137168 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/137168: commit references a PR
Date: Mon, 27 Jul 2009 13:36:45 +0000 (UTC)

 Author: rpaulo
 Date: Mon Jul 27 13:36:35 2009
 New Revision: 195905
 URL: http://svn.freebsd.org/changeset/base/195905
 
 Log:
   * Document the dev.asmc.N.light.control sysctl. [1]
   * Add more models that have the SMC.
   
   PR:		137168 [1]
   Submitted by:	Patrick Lamaiziere <patfbsd at davenulle.org>
   Approved by:	re (kib)
 
 Modified:
   head/share/man/man4/asmc.4
 
 Modified: head/share/man/man4/asmc.4
 ==============================================================================
 --- head/share/man/man4/asmc.4	Mon Jul 27 12:09:32 2009	(r195904)
 +++ head/share/man/man4/asmc.4	Mon Jul 27 13:36:35 2009	(r195905)
 @@ -1,5 +1,5 @@
  .\"-
 -.\" Copyright (c) 2007, 2008 Rui Paulo <rpaulo@FreeBSD.org>
 +.\" Copyright (c) 2007, 2008, 2009 Rui Paulo <rpaulo@FreeBSD.org>
  .\" All rights reserved.
  .\"
  .\" Redistribution and use in source and binary forms, with or without
 @@ -25,7 +25,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd April 7, 2008
 +.Dd July 27, 2009
  .Dt ASMC 4
  .Os
  .Sh NAME
 @@ -54,11 +54,17 @@ The SMC is known to be found on the foll
  .Pp
  .Bl -bullet -offset indent -compact
  .It
 -MacBook (any generation)
 +MacBook
  .It
 -MacBook Pro (any generation)
 +MacBook Pro
  .It
  Intel MacMini
 +.It
 +Mac Pro
 +.It
 +MacBook Air
 +.It
 +Intel iMac
  .El
  .Pp
  With this driver, you can configure your keyboard backlight
 @@ -72,15 +78,16 @@ under the device tree
  .Sh KEYBOARD BACKLIGHT
  On
  .Tn MacBook Pro
 -systems, you can control the keyboard brightness by writing values to
 +systems, you can control the keyboard brightness by writing a value to
  the
 +.Va dev.asmc.%d.light.control
 +sysctl MIB.
 +.Pp
 +The following sysctl MIBs contains the raw value returned by the left
 +and right light sensors:
  .Va dev.asmc.%d.light.left
  or
 -.Va dev.asmc.%d.light.right
 -sysctl MIBs.
 -.Pp
 -Each of these sysctl MIBs contains the raw value returned by the left
 -and right light sensors.
 +.Va dev.asmc.%d.light.right .
  .Sh TEMPERATURES
  The number of temperature sensors and their description varies among
  systems.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
