From nobody@FreeBSD.org  Wed Apr 29 19:50:14 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4074310656AA
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 Apr 2009 19:50:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 2F01D8FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 Apr 2009 19:50:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n3TJoDsD044321
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 Apr 2009 19:50:13 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n3TJoDF5044319;
	Wed, 29 Apr 2009 19:50:13 GMT
	(envelope-from nobody)
Message-Id: <200904291950.n3TJoDF5044319@www.freebsd.org>
Date: Wed, 29 Apr 2009 19:50:13 GMT
From: Eugene Mychlo <myc@barev.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Incorrect control messages in ng_hole(4) manpage
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         134100
>Category:       docs
>Synopsis:       [patch] Incorrect control messages in ng_hole(4) manpage
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 29 20:00:11 UTC 2009
>Closed-Date:    Mon May 25 10:13:28 UTC 2009
>Last-Modified:  Mon May 25 10:13:28 UTC 2009
>Originator:     Eugene Mychlo
>Release:        FreeBSD 7.1-RELEASE-p4
>Organization:
Rekomendata, JSC
>Environment:
FreeBSD mycws.local 7.1-RELEASE-p4 FreeBSD 7.1-RELEASE-p4 #0: Sun Mar 22 12:35:36 UTC 2009     root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
The ng_hole(4) manpage states that hole node type supports NGM_BPF_* control messages, but isn't correct.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- share/man/man4/ng_hole.4~	2009-04-29 23:41:51.000000000 +0400
+++ share/man/man4/ng_hole.4	2009-04-29 23:42:50.000000000 +0400
@@ -58,20 +58,20 @@
 This node type supports the generic control messages, plus the
 following:
 .Bl -tag -width indent
-.It Dv NGM_BPF_GET_STATS
+.It Dv NGM_HOLE_GET_STATS
 This command takes an
 .Tn ASCII
 string argument, the hook name, and returns the statistics
 associated with the hook as a
 .Vt "struct ng_hole_hookstat" .
-.It Dv NGM_BPF_CLR_STATS
+.It Dv NGM_HOLE_CLR_STATS
 This command takes an
 .Tn ASCII
 string argument, the hook name, and clears the statistics
 associated with the hook.
-.It Dv NGM_BPF_GETCLR_STATS
+.It Dv NGM_HOLE_GETCLR_STATS
 This command is identical to
-.Dv NGM_BPF_GET_STATS ,
+.Dv NGM_HOLE_GET_STATS ,
 except that the statistics are also atomically cleared.
 .El
 .Sh SHUTDOWN


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Thu Apr 30 10:01:26 UTC 2009 
State-Changed-Why:  
Fixed in HEAD.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134100 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/134100: commit references a PR
Date: Thu, 30 Apr 2009 10:01:29 +0000 (UTC)

 Author: maxim
 Date: Thu Apr 30 10:01:13 2009
 New Revision: 191682
 URL: http://svn.freebsd.org/changeset/base/191682
 
 Log:
   o Correct ng_hole(4) control messages names.
   
   PR:		docs/134100
   Submitted by:	Eugene Mychlo
   MFC after:	1 week
 
 Modified:
   head/share/man/man4/ng_hole.4
 
 Modified: head/share/man/man4/ng_hole.4
 ==============================================================================
 --- head/share/man/man4/ng_hole.4	Thu Apr 30 07:48:49 2009	(r191681)
 +++ head/share/man/man4/ng_hole.4	Thu Apr 30 10:01:13 2009	(r191682)
 @@ -58,20 +58,20 @@ as long as the name is unique.
  This node type supports the generic control messages, plus the
  following:
  .Bl -tag -width indent
 -.It Dv NGM_BPF_GET_STATS
 +.It Dv NGM_HOLE_GET_STATS
  This command takes an
  .Tn ASCII
  string argument, the hook name, and returns the statistics
  associated with the hook as a
  .Vt "struct ng_hole_hookstat" .
 -.It Dv NGM_BPF_CLR_STATS
 +.It Dv NGM_HOLE_CLR_STATS
  This command takes an
  .Tn ASCII
  string argument, the hook name, and clears the statistics
  associated with the hook.
 -.It Dv NGM_BPF_GETCLR_STATS
 +.It Dv NGM_HOLE_GETCLR_STATS
  This command is identical to
 -.Dv NGM_BPF_GET_STATS ,
 +.Dv NGM_HOLE_GET_STATS ,
  except that the statistics are also atomically cleared.
  .El
  .Sh SHUTDOWN
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Mon May 25 10:13:15 UTC 2009 
State-Changed-Why:  
Merged to RELENG_7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134100 
>Unformatted:
