From nobody@FreeBSD.org  Sun Mar 29 17:43:14 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1AF321065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 29 Mar 2009 17:43:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 095228FC1C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 29 Mar 2009 17:43:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2THhDvw063930
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 29 Mar 2009 17:43:13 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n2THhDYq063929;
	Sun, 29 Mar 2009 17:43:13 GMT
	(envelope-from nobody)
Message-Id: <200903291743.n2THhDYq063929@www.freebsd.org>
Date: Sun, 29 Mar 2009 17:43:13 GMT
From: Warren Block <wblock@wonkity.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: powerd(8) man page errors
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         133186
>Category:       docs
>Synopsis:       [patch] powerd(8) man page errors
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gavin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 29 17:50:01 UTC 2009
>Closed-Date:    Wed Jan 06 21:01:57 UTC 2010
>Last-Modified:  Wed Jan 06 21:01:57 UTC 2010
>Originator:     Warren Block
>Release:        7.2-PRERELEASE
>Organization:
>Environment:
FreeBSD lightning 7.2-PRERELEASE FreeBSD 7.2-PRERELEASE #0: Thu Mar 26 20:56:40 MDT 2009     root@lightning:/usr/obj/usr/src/sys/LIGHTNING  i386
>Description:
powerd man page needs to be updated and clarified:

1. "It offers three modes (maximum, minimum, and adaptive) that can be individually selected while on AC power or batter-ies.  The modes maximum, minimum, adaptive and hiadaptive may be abbrevi-ated max, min, adp, hadp."

That's actually four modes.  hiadaptive should be mentioned in the first sentence, too.


2.  "Hiadaptive mode is alike adaptive mode,"

Change "alike" to "like".


3.  "It rises frequency faster, drops slower and keeps twice lower CPU load."

"rises" should be "increases".

"keeps twice lower CPU load" is extremely unclear.  Is this load being put on the CPU by powerd?  Or is it CPU load being monitored by powerd?  Lower than what?  What does "twice lower" mean?
>How-To-Repeat:
man 8 powerd
>Fix:
1.  Fix mode count and list in second sentence: "It offers three modes (maximum, minimum, and adaptive)" should be "It offers four modes (maximum, minimum, adaptive, and hiadaptive)"

2.  Change "alike" to "like".

3.  Rewrite the sentence that explains what hiadaptive does so that it is clear and unambiguous.

>Release-Note:
>Audit-Trail:

From: Gavin Atkinson <gavin@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/133186: powerd(8) man page errors
Date: Wed, 12 Aug 2009 15:54:33 +0100

 Patch at http://people.freebsd.org/~gavin/PRs/133186.diff
State-Changed-From-To: open->patched 
State-Changed-By: gavin 
State-Changed-When: Mon Dec 21 22:58:54 UTC 2009 
State-Changed-Why:  
Fixed in HEAD, MFC in two weeks 


Responsible-Changed-From-To: freebsd-doc->gavin 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Mon Dec 21 22:58:54 UTC 2009 
Responsible-Changed-Why:  
Mine 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133186 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/133186: commit references a PR
Date: Mon, 21 Dec 2009 22:56:20 +0000 (UTC)

 Author: gavin
 Date: Mon Dec 21 22:56:06 2009
 New Revision: 200819
 URL: http://svn.freebsd.org/changeset/base/200819
 
 Log:
   Grammar and minor tweaks to powerd(8) man page.
   
   PR:		docs/133186
   Approved by:	ed (mentor)
   MFC after:	2 weeks
 
 Modified:
   head/usr.sbin/powerd/powerd.8
 
 Modified: head/usr.sbin/powerd/powerd.8
 ==============================================================================
 --- head/usr.sbin/powerd/powerd.8	Mon Dec 21 22:16:07 2009	(r200818)
 +++ head/usr.sbin/powerd/powerd.8	Mon Dec 21 22:56:06 2009	(r200819)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd December 24, 2008
 +.Dd December 21, 2009
  .Dt POWERD 8
  .Os
  .Sh NAME
 @@ -45,7 +45,7 @@ The
  .Nm
  utility monitors the system state and sets various power control options
  accordingly.
 -It offers three modes (maximum, minimum, and adaptive) that can be
 +It offers four modes (maximum, minimum, adaptive and hiadaptive) that can be
  individually selected while on AC power or batteries.
  The modes maximum, minimum, adaptive and hiadaptive may be abbreviated
  max, min, adp, hadp.
 @@ -57,9 +57,10 @@ Adaptive mode attempts to strike a balan
  the system appears idle and increasing it when the system is busy.
  It offers a good balance between a small performance loss for greatly
  increased power savings.
 -Hiadaptive mode is alike adaptive mode, but tuned for systems where
 +Hiadaptive mode is like adaptive mode, but tuned for systems where
  performance and interactivity are more important then power consumption.
 -It rises frequency faster, drops slower and keeps twice lower CPU load.
 +It increases frequency faster, reduces the frequency less aggressively and
 +will maintain full frequency for longer.
  The default mode is adaptive for battery power and hiadaptive for the rest.
  .Pp
  The
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/133186: commit references a PR
Date: Wed,  6 Jan 2010 20:54:22 +0000 (UTC)

 Author: gavin
 Date: Wed Jan  6 20:54:04 2010
 New Revision: 201672
 URL: http://svn.freebsd.org/changeset/base/201672
 
 Log:
   MFC r200819:
   
     Grammar and minor tweaks to powerd(8) man page.
   
   PR:		docs/133186
   Approved by:	ed (mentor, implicit)
 
 Modified:
   stable/8/usr.sbin/powerd/powerd.8
 Directory Properties:
   stable/8/usr.sbin/powerd/   (props changed)
 
 Modified: stable/8/usr.sbin/powerd/powerd.8
 ==============================================================================
 --- stable/8/usr.sbin/powerd/powerd.8	Wed Jan  6 20:51:04 2010	(r201671)
 +++ stable/8/usr.sbin/powerd/powerd.8	Wed Jan  6 20:54:04 2010	(r201672)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd December 24, 2008
 +.Dd December 21, 2009
  .Dt POWERD 8
  .Os
  .Sh NAME
 @@ -45,7 +45,7 @@ The
  .Nm
  utility monitors the system state and sets various power control options
  accordingly.
 -It offers three modes (maximum, minimum, and adaptive) that can be
 +It offers four modes (maximum, minimum, adaptive and hiadaptive) that can be
  individually selected while on AC power or batteries.
  The modes maximum, minimum, adaptive and hiadaptive may be abbreviated
  max, min, adp, hadp.
 @@ -57,9 +57,10 @@ Adaptive mode attempts to strike a balan
  the system appears idle and increasing it when the system is busy.
  It offers a good balance between a small performance loss for greatly
  increased power savings.
 -Hiadaptive mode is alike adaptive mode, but tuned for systems where
 +Hiadaptive mode is like adaptive mode, but tuned for systems where
  performance and interactivity are more important then power consumption.
 -It rises frequency faster, drops slower and keeps twice lower CPU load.
 +It increases frequency faster, reduces the frequency less aggressively and
 +will maintain full frequency for longer.
  The default mode is adaptive for battery power and hiadaptive for the rest.
  .Pp
  The
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gavin 
State-Changed-When: Wed Jan 6 21:01:28 UTC 2010 
State-Changed-Why:  
Merged to 8.  Thanks for your bug report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133186 
>Unformatted:
