From nobody@FreeBSD.org  Thu Jan 22 17:00:22 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4926B1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Jan 2009 17:00:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3C0338FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Jan 2009 17:00:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n0MH0Mc4060288
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Jan 2009 17:00:22 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n0MH0LWZ060286;
	Thu, 22 Jan 2009 17:00:21 GMT
	(envelope-from nobody)
Message-Id: <200901221700.n0MH0LWZ060286@www.freebsd.org>
Date: Thu, 22 Jan 2009 17:00:21 GMT
From: George Hartzell <hartzell@alerce.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: No man page installed for padlock(4) on amd64 sytstem (Via Nano processor)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         130895
>Category:       docs
>Synopsis:       [patch] No man page installed for padlock(4) on amd64 sytstem (Via Nano processor)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gavin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 22 17:10:01 UTC 2009
>Closed-Date:    Mon Jul 26 13:26:03 UTC 2010
>Last-Modified:  Mon Jul 26 13:26:03 UTC 2010
>Originator:     George Hartzell
>Release:        8.0-CURRENT
>Organization:
>Environment:
FreeBSD bluetoo.alerce.com 8.0-CURRENT FreeBSD 8.0-CURRENT #2: Thu Jan 22 23:31:03 UTC 2009     root@bluetoo.alerce.com:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:

The man page for padlock(4) wasn't installed on a new system that I built up last night.

It's a VIA VB8001, running -CURRENT amd64.

At a guess it's absence might be explained by padlock historically only existing on 32 bit platforms?  The man page source is available at:

  /usr/src/share/man/man4/man4.i386/padlock.4



>How-To-Repeat:
Build a -CURRENT amd64 system and look for the padlock(4) man page.
>Fix:

Possibly just moving the man page source to 

  /usr/src/share/man/man4/padlock.4



>Release-Note:
>Audit-Trail:

From: Patrick =?ISO-8859-15?Q?Lamaizi=E8re?= <patfbsd@davenulle.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/130895: No man page installed for padlock(4) on amd64
 sytstem (Via Nano processor)
Date: Thu, 22 Jan 2009 19:42:00 +0100

 > >Description:
 > 
 > The man page for padlock(4) wasn't installed on a new system that I
 > built up last night.
 > 
 > It's a VIA VB8001, running -CURRENT amd64.
 > 
 > At a guess it's absence might be explained by padlock historically
 > only existing on 32 bit platforms?  The man page source is available
 > at:
 > 
 >   /usr/src/share/man/man4/man4.i386/padlock.4
 
 Yes because. The padlock(4) driver is built only on i386. 
 
 > >Fix:
 > 
 > Possibly just moving the man page source to 
 > 
 >   /usr/src/share/man/man4/padlock.4
 
 That's not enought to make it built on amd64.
 
 We should include it (at least) in sys/conf/files.amd64
 and sys/modules/Makefile
 
 The good question is does the actual padlock work on the via nano
 processor?

From: Gavin Atkinson <gavin@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/130895: No man page installed for padlock(4) on amd64
	sytstem (Via Nano processor)
Date: Wed, 12 Aug 2009 15:56:14 +0100

 This PR is a valid problem.  It needs a repocopy
 src/share/man/man4/man4.i386/padlock.4 > src/share/man/man4/padlock.4
 and the patch at http://people.freebsd.org/~gavin/PRs/130895.diff
Responsible-Changed-From-To: freebsd-doc->gavin 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Mon Feb 8 21:13:17 UTC 2010 
Responsible-Changed-Why:  
Take 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130895 
State-Changed-From-To: open->patched 
State-Changed-By: gavin 
State-Changed-When: Mon Feb 8 21:24:19 UTC 2010 
State-Changed-Why:  
Fixed in head, MFC in 1 week 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130895 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/130895: commit references a PR
Date: Mon,  8 Feb 2010 21:24:26 +0000 (UTC)

 Author: gavin
 Date: Mon Feb  8 21:24:12 2010
 New Revision: 203689
 URL: http://svn.freebsd.org/changeset/base/203689
 
 Log:
   Install the padlock(4) man page on amd64 as well as i386, to match the
   platforms where the driver itself is compiled and installed.
   
   PR:		docs/130895
   Reported by:	George Hartzell <hartzell alerce.com>
   MFC after:	1 week
 
 Added:
   head/share/man/man4/padlock.4
      - copied, changed from r203610, head/share/man/man4/man4.i386/padlock.4
 Deleted:
   head/share/man/man4/man4.i386/padlock.4
 Modified:
   head/share/man/man4/Makefile
   head/share/man/man4/man4.i386/Makefile
 
 Modified: head/share/man/man4/Makefile
 ==============================================================================
 --- head/share/man/man4/Makefile	Mon Feb  8 21:23:48 2010	(r203688)
 +++ head/share/man/man4/Makefile	Mon Feb  8 21:24:12 2010	(r203689)
 @@ -297,6 +297,7 @@ MAN=	aac.4 \
  	${_nxge.4} \
  	ohci.4 \
  	orm.4 \
 +	${_padlock.4} \
  	pass.4 \
  	patm.4 \
  	pccard.4 \
 @@ -649,6 +650,7 @@ _nfsmb.4=	nfsmb.4
  _nve.4=		nve.4
  _nvram.4=	nvram.4
  _nxge.4=	nxge.4
 +_padlock.4=	padlock.4
  _rr232x.4=	rr232x.4
  _speaker.4=	speaker.4
  _spkr.4=	spkr.4
 
 Modified: head/share/man/man4/man4.i386/Makefile
 ==============================================================================
 --- head/share/man/man4/man4.i386/Makefile	Mon Feb  8 21:23:48 2010	(r203688)
 +++ head/share/man/man4/man4.i386/Makefile	Mon Feb  8 21:24:12 2010	(r203689)
 @@ -20,7 +20,6 @@ MAN=	aic.4 \
  	mcd.4 \
  	mse.4 \
  	npx.4 \
 -	padlock.4 \
  	pae.4 \
  	pbio.4 \
  	pcf.4 \
 
 Copied and modified: head/share/man/man4/padlock.4 (from r203610, head/share/man/man4/man4.i386/padlock.4)
 ==============================================================================
 --- head/share/man/man4/man4.i386/padlock.4	Sun Feb  7 13:59:03 2010	(r203610, copy source)
 +++ head/share/man/man4/padlock.4	Mon Feb  8 21:24:12 2010	(r203689)
 @@ -24,8 +24,8 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd August 1, 2007
 -.Dt PADLOCK 4 i386
 +.Dd February 8, 2010
 +.Dt PADLOCK 4
  .Os
  .Sh NAME
  .Nm padlock
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/130895: commit references a PR
Date: Tue, 16 Feb 2010 22:23:43 +0000 (UTC)

 Author: gavin
 Date: Tue Feb 16 22:23:33 2010
 New Revision: 203976
 URL: http://svn.freebsd.org/changeset/base/203976
 
 Log:
   Merge 203689 from head:
   
     Install the padlock(4) man page on amd64 as well as i386, to match the
     platforms where the driver itself is compiled and installed.
   
   PR:		docs/130895
   Reported by:	George Hartzell <hartzell alerce.com>
 
 Added:
   stable/8/share/man/man4/padlock.4
      - copied unchanged from r203689, head/share/man/man4/padlock.4
 Deleted:
   stable/8/share/man/man4/man4.i386/padlock.4
 Modified:
   stable/8/share/man/man4/Makefile
   stable/8/share/man/man4/man4.i386/Makefile
 Directory Properties:
   stable/8/share/man/man4/   (props changed)
 
 Modified: stable/8/share/man/man4/Makefile
 ==============================================================================
 --- stable/8/share/man/man4/Makefile	Tue Feb 16 22:19:55 2010	(r203975)
 +++ stable/8/share/man/man4/Makefile	Tue Feb 16 22:23:33 2010	(r203976)
 @@ -294,6 +294,7 @@ MAN=	aac.4 \
  	${_nxge.4} \
  	ohci.4 \
  	orm.4 \
 +	${_padlock.4} \
  	pass.4 \
  	patm.4 \
  	pccard.4 \
 @@ -641,6 +642,7 @@ _nfsmb.4=	nfsmb.4
  _nve.4=		nve.4
  _nvram.4=	nvram.4
  _nxge.4=	nxge.4
 +_padlock.4=	padlock.4
  _rr232x.4=	rr232x.4
  _speaker.4=	speaker.4
  _spkr.4=	spkr.4
 
 Modified: stable/8/share/man/man4/man4.i386/Makefile
 ==============================================================================
 --- stable/8/share/man/man4/man4.i386/Makefile	Tue Feb 16 22:19:55 2010	(r203975)
 +++ stable/8/share/man/man4/man4.i386/Makefile	Tue Feb 16 22:23:33 2010	(r203976)
 @@ -21,7 +21,6 @@ MAN=	aic.4 \
  	mcd.4 \
  	mse.4 \
  	npx.4 \
 -	padlock.4 \
  	pae.4 \
  	pbio.4 \
  	pcf.4 \
 
 Copied: stable/8/share/man/man4/padlock.4 (from r203689, head/share/man/man4/padlock.4)
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ stable/8/share/man/man4/padlock.4	Tue Feb 16 22:23:33 2010	(r203976, copy of r203689, head/share/man/man4/padlock.4)
 @@ -0,0 +1,97 @@
 +.\" Copyright (c) 2005 Christian Brueffer
 +.\" All rights reserved.
 +.\"
 +.\" Redistribution and use in source and binary forms, with or without
 +.\" modification, are permitted provided that the following conditions
 +.\" are met:
 +.\" 1. Redistributions of source code must retain the above copyright
 +.\"    notice, this list of conditions and the following disclaimer.
 +.\" 2. Redistributions in binary form must reproduce the above copyright
 +.\"    notice, this list of conditions and the following disclaimer in the
 +.\"    documentation and/or other materials provided with the distribution.
 +.\"
 +.\" THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
 +.\" ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 +.\" IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 +.\" ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
 +.\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 +.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
 +.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 +.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 +.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
 +.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 +.\" SUCH DAMAGE.
 +.\"
 +.\" $FreeBSD$
 +.\"
 +.Dd February 8, 2010
 +.Dt PADLOCK 4
 +.Os
 +.Sh NAME
 +.Nm padlock
 +.Nd "driver for the cryptographic functions and RNG in VIA C3, C7 and Eden processors"
 +.Sh SYNOPSIS
 +To compile this driver into the kernel,
 +place the following lines in your
 +kernel configuration file:
 +.Bd -ragged -offset indent
 +.Cd "device crypto"
 +.Cd "device padlock"
 +.Ed
 +.Pp
 +Alternatively, to load the driver as a
 +module at boot time, place the following line in
 +.Xr loader.conf 5 :
 +.Bd -literal -offset indent
 +padlock_load="YES"
 +.Ed
 +.Sh DESCRIPTION
 +The C3 and Eden processor series from VIA include hardware acceleration for
 +AES.
 +The C7 series includes hardware acceleration for AES, SHA1, SHA256 and RSA.
 +All of the above processor series include a hardware random number generator.
 +.Pp
 +The
 +.Nm
 +driver registers itself to accelerate AES operations and, if available, HMAC/SHA1
 +and HMAC/SHA256 for
 +.Xr crypto 4 .
 +It also registers itself to accelerate other HMAC algorithms, although
 +there is no hardware acceleration for those algorithms.
 +This is only needed so
 +.Nm
 +can work with
 +.Xr ipsec 4 .
 +.Pp
 +The hardware random number generator supplies data for the kernel
 +.Xr random 4
 +subsystem.
 +.Sh SEE ALSO
 +.Xr crypt 3 ,
 +.Xr crypto 4 ,
 +.Xr intro 4 ,
 +.Xr ipsec 4 ,
 +.Xr random 4 ,
 +.Xr crypto 9
 +.Sh HISTORY
 +The
 +.Nm
 +driver first appeared in
 +.Ox .
 +The first
 +.Fx
 +release to include it was
 +.Fx 6.0 .
 +.Sh AUTHORS
 +.An -nosplit
 +The
 +.Nm
 +driver with AES encryption support was written by
 +.An Jason Wright Aq jason@OpenBSD.org .
 +It was ported to
 +.Fx
 +and then extended to support SHA1 and SHA256
 +by
 +.An Pawel Jakub Dawidek Aq pjd@FreeBSD.org .
 +This manual page was written by
 +.An Christian Brueffer Aq brueffer@FreeBSD.org .
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gavin 
State-Changed-When: Mon Jul 26 13:25:35 UTC 2010 
State-Changed-Why:  
This should have been closed when I merged the PR to stable/8 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130895 
>Unformatted:
