From ga9@buffy.york.ac.uk  Mon Jul 28 11:48:47 2008
Return-Path: <ga9@buffy.york.ac.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8E9A91065677
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Jul 2008 11:48:47 +0000 (UTC)
	(envelope-from ga9@buffy.york.ac.uk)
Received: from mail-gw0.york.ac.uk (mail-gw0.york.ac.uk [144.32.128.245])
	by mx1.freebsd.org (Postfix) with ESMTP id 1D1BE8FC1C
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Jul 2008 11:48:46 +0000 (UTC)
	(envelope-from ga9@buffy.york.ac.uk)
Received: from mail-gw6.york.ac.uk (mail-gw6.york.ac.uk [144.32.129.26])
	by mail-gw0.york.ac.uk (8.13.6/8.13.6) with ESMTP id m6SBmiFt018175
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Jul 2008 12:48:44 +0100 (BST)
Received: from buffy-128.york.ac.uk ([144.32.128.160] helo=buffy.york.ac.uk)
	by mail-gw6.york.ac.uk with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.68)
	(envelope-from <ga9@buffy.york.ac.uk>)
	id 1KNRDY-00065Y-5G
	for FreeBSD-gnats-submit@freebsd.org; Mon, 28 Jul 2008 12:48:44 +0100
Received: from buffy.york.ac.uk (localhost [127.0.0.1])
	by buffy.york.ac.uk (8.14.2/8.14.2) with ESMTP id m6SBmhZ8064185
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Jul 2008 12:48:43 +0100 (BST)
	(envelope-from ga9@buffy.york.ac.uk)
Received: (from ga9@localhost)
	by buffy.york.ac.uk (8.14.2/8.14.2/Submit) id m6SBmhFo064184;
	Mon, 28 Jul 2008 12:48:43 +0100 (BST)
	(envelope-from ga9)
Message-Id: <200807281148.m6SBmhFo064184@buffy.york.ac.uk>
Date: Mon, 28 Jul 2008 12:48:43 +0100 (BST)
From: Gavin Atkinson <gavin@freebsd.org>
Reply-To: Gavin Atkinson <gavin@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] updates to developers handbook: sockets section
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         126031
>Category:       docs
>Synopsis:       [patch] updates to developers handbook: sockets section
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    danger
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 28 11:50:00 UTC 2008
>Closed-Date:    Sun Aug 03 09:51:00 UTC 2008
>Last-Modified:  Sun Aug  3 10:00:08 UTC 2008
>Originator:     Gavin Atkinson
>Release:        FreeBSD 7.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD buffy.york.ac.uk 7.0-STABLE FreeBSD 7.0-STABLE #3: Fri Jun 20 09:21:51 UTC 2008 root@buffy.york.ac.uk:/usr/obj/usr/src/sys/GENERIC amd64

>Description:
	Minor updates to the (otherwise very good) sockets tutorial:
 - Include string.h to avoid compile warning about using bzero without defining it
 - use herror() rather than perror() to give useful error messages (the *hostby*()
   functions set h_errno not errno)
>How-To-Repeat:
	compile and test the code examples
>Fix:

--- devh-sockets.diff begins here ---
Index: doc/en_US.ISO8859-1/books/developers-handbook/sockets/chapter.sgml
===================================================================
RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/developers-handbook/sockets/chapter.sgml,v
retrieving revision 1.15
diff -u -r1.15 chapter.sgml
--- doc/en_US.ISO8859-1/books/developers-handbook/sockets/chapter.sgml	5 Jan 2006 20:03:35 -0000	1.15
+++ doc/en_US.ISO8859-1/books/developers-handbook/sockets/chapter.sgml	28 Jul 2008 11:44:41 -0000
@@ -966,6 +966,7 @@
  * Programmed by G. Adam Stanislav
  */
 #include &lt;stdio.h&gt;
+#include &lt;string.h&gt;
 #include &lt;sys/types.h&gt;
 #include &lt;sys/socket.h&gt;
 #include &lt;netinet/in.h&gt;
@@ -1181,6 +1182,7 @@
  * June 19, 2001
  */
 #include &lt;stdio.h&gt;
+#include &lt;string.h&gt;
 #include &lt;time.h&gt;
 #include &lt;unistd.h&gt;
 #include &lt;sys/types.h&gt;
@@ -1582,7 +1584,7 @@
   host = (argc &gt; 1) ? (char *)argv[1] : "time.nist.gov";
 
   if ((he = gethostbyname(host)) == NULL) {
-    perror(host);
+    herror(host);
     return 2;
   }
 
--- devh-sockets.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->danger 
Responsible-Changed-By: danger 
Responsible-Changed-When: Mon Jul 28 11:59:01 UTC 2008 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126031 
State-Changed-From-To: open->closed 
State-Changed-By: danger 
State-Changed-When: Sun Aug 3 09:50:32 UTC 2008 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126031 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/126031: commit references a PR
Date: Sun,  3 Aug 2008 09:50:28 +0000 (UTC)

 danger      2008-08-03 09:50:20 UTC
 
   FreeBSD doc repository
 
   Modified files:
     en_US.ISO8859-1/books/developers-handbook/sockets chapter.sgml 
   Log:
   - Include string.h to avoid compile warning about using bzero without
     defining it
   - use herror() rather than perror() to give useful error messages
     (the *hostby*() functions set h_errno not errno)
   
   PR:             docs/126031
   Submitted by:   gavin
   
   Revision  Changes    Path
   1.16      +3 -1      doc/en_US.ISO8859-1/books/developers-handbook/sockets/chapter.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
