From nobody@FreeBSD.org  Sat Jul 12 17:22:49 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C01471065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Jul 2008 17:22:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D6208FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Jul 2008 17:22:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6CHMnQ4006894
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Jul 2008 17:22:49 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m6CHMm6h006893;
	Sat, 12 Jul 2008 17:22:48 GMT
	(envelope-from nobody)
Message-Id: <200807121722.m6CHMm6h006893@www.freebsd.org>
Date: Sat, 12 Jul 2008 17:22:48 GMT
From: Mateusz Guzik <mjguzik@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] ktrace(2) contains outdated struct ktr_header
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         125546
>Category:       docs
>Synopsis:       [patch] ktrace(2) contains outdated struct ktr_header
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 12 17:30:01 UTC 2008
>Closed-Date:    Sat Aug 02 12:52:32 UTC 2008
>Last-Modified:  Sat Aug  2 13:50:02 UTC 2008
>Originator:     Mateusz Guzik
>Release:        8.0-CURRENT
>Organization:
>Environment:
FreeBSD eternal 8.0-CURRENT FreeBSD 8.0-CURRENT #14: Tue Jul  8 02:28:46 CEST 2008     f@eternal:/usr/obj/usr/src/sys/ETERNAL  i386

>Description:
struct ktr_header in ktrace(2):
[..]
caddr_t ktr_buf;
};

struct ktr_header in /usr/include/sys/ktrace.h:
[..]
intptr_t        ktr_tid;        /* was ktr_buffer */
};

>How-To-Repeat:

>Fix:
Patch is attached.

Patch attached with submission follows:

--- ./lib/libc/sys/ktrace.2.orig	2008-07-12 18:54:22.000000000 +0200
+++ ./lib/libc/sys/ktrace.2	2008-07-12 19:16:53.000000000 +0200
@@ -99,11 +99,11 @@
 	int	ktr_len;		/* length of buf */
 	short	ktr_type;		/* trace record type */
 	pid_t	ktr_pid;		/* process id */
 	char	ktr_comm[MAXCOMLEN+1];	/* command name */
 	struct	timeval ktr_time;	/* timestamp */
-	caddr_t	ktr_buf;
+	intptr_t	ktr_tid;
 };
 .Ed
 .Pp
 The
 .Va ktr_len
@@ -118,12 +118,12 @@
 The
 .Va ktr_time
 field gives the time (with microsecond resolution)
 that the record was generated.
 The
-.Va ktr_buf
-is an internal kernel pointer and is not useful.
+.Va ktr_tid
+field holds a threadid.
 .Pp
 The generic header is followed by
 .Va ktr_len
 bytes of a
 .Va ktr_type


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Sun Jul 13 13:43:10 UTC 2008 
State-Changed-Why:  
patched in current 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125546 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/125546: commit references a PR
Date: Sun, 13 Jul 2008 13:43:27 +0000 (UTC)

 remko       2008-07-13 13:42:52 UTC
 
   FreeBSD src repository
 
   Modified files:
     lib/libc/sys         ktrace.2 
   Log:
   SVN rev 180491 on 2008-07-13 13:42:52Z by remko
   
   Update the ktr_header structure, which changed over time.
   
   PR:             125546
   Submitted by:   Mateusz Guzik <mjguzik at gmail dot com>
   MFC after:      3 days
   
   Revision  Changes    Path
   1.26      +4 -4      src/lib/libc/sys/ktrace.2
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Sat Aug 2 12:52:32 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125546 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/125546: commit references a PR
Date: Sat,  2 Aug 2008 13:40:59 +0000 (UTC)

 remko       2008-08-02 13:40:14 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     lib/libc/sys         ktrace.2 
   Log:
   SVN rev 181179 on 2008-08-02 13:40:14Z by remko
   
   MFC r180491
   
     Update the ktr_header structure, which changed over time.
   
     PR:             125546
     Submitted by:   Mateusz Guzik <mjguzik at gmail dot com>
     MFC after:      3 days
   
   Revision  Changes    Path
   1.25.2.1  +4 -4      src/lib/libc/sys/ktrace.2
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
