From db@db.net  Sat Apr  5 22:08:18 2008
Return-Path: <db@db.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1C52D106566C
	for <freebsd-gnats-submit@freebsd.org>; Sat,  5 Apr 2008 22:08:18 +0000 (UTC)
	(envelope-from db@db.net)
Received: from diana.db.net (diana.db.net [204.228.229.66])
	by mx1.freebsd.org (Postfix) with ESMTP id E94438FC0A
	for <freebsd-gnats-submit@freebsd.org>; Sat,  5 Apr 2008 22:08:17 +0000 (UTC)
	(envelope-from db@db.net)
Received: from diana.db.net
	([204.228.229.66] helo=localhost ident=mailnull)
	by diana.db.net with esmtp (Exim 4.66 (FreeBSD))
	(envelope-from <db@db.net>)
	id 1JiFuF-000NpK-Fl
	for freebsd-gnats-submit@freebsd.org; Sat, 05 Apr 2008 15:26:35 -0600
Received: from diana.db.net ([127.0.0.1] helo=localhost)
	(envelope-from <db@night.db.net>)
	id 1JiFuE-000BWj-My
	for FreeBSD-gnats-submit@freebsd.org; Sat, 05 Apr 2008 17:26:34 -0400
Message-Id: <E1JiFuE-000BWj-My@night.db.net>
Date: Sat, 05 Apr 2008 17:26:34 -0400
From: Diane Bruce <db@db.net>
Reply-To: Diane Bruce <db@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Misleading doc for adding new users to a group
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         122476
>Category:       docs
>Synopsis:       [handbook] [patch] Misleading doc for adding new users to a group
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 05 22:10:00 UTC 2008
>Closed-Date:    Thu Apr 24 16:25:04 UTC 2008
>Last-Modified:  Thu Apr 24 16:25:04 UTC 2008
>Originator:     Diane Bruce
>Release:        FreeBSD 7.0-RELEASE i386
>Organization:
Are you kidding?
>Environment:
System: FreeBSD night.db.net 7.0-RELEASE FreeBSD 7.0-RELEASE #13: Thu Feb 28 08:50:37 EST 2008 root@night.db.net:/usr/obj/usr/src/sys/NIGHT i386



>Description:
	3.8 is mis-leading and has resulted in a new user accidentally
	deleting himself from groups, both -M and -m should be shown
	as examples clarifying the difference.
>How-To-Repeat:

>Fix:

See sgml diff

--- en_US.ISO8859-1/books/handbook/users/chapter.sgml.orig	2008-04-04 18:24:51.000000000 -0400
+++ en_US.ISO8859-1/books/handbook/users/chapter.sgml	2008-04-05 16:01:40.000000000 -0400
@@ -982,7 +982,7 @@
       the <groupname>teamtwo</groupname> group.</para>

     <example>
-      <title>Adding Somebody to a Group Using &man.pw.8;</title>
+      <title>Creating the list of members of a Group Using &man.pw.8;</title>

       <screen>&prompt.root; <userinput>pw groupmod teamtwo -M jru</userinput>
 &prompt.root; <userinput>pw groupshow teamtwo</userinput>
@@ -990,7 +990,7 @@
     </example>

     <para>The argument to the <option>-M</option> option is a
-      comma-delimited list of users who are members of the group.  From the
+      comma-delimited list of users who are to be in the group.  From the
       preceding sections, we know that the password file also contains a
       group for each user.  The latter (the user) is automatically added to
       the group list by the system; the user will not show up as a member
@@ -1000,6 +1000,18 @@
       <filename>/etc/group</filename> file; it will never attempt to read
       additionally data from <filename>/etc/passwd</filename>.</para>

+      <example>
+      <title>Adding a new member to a Group Using &man.pw.8;</title>
+
+      <screen>&prompt.root; <userinput>pw groupmod teamtwo -m db</userinput>
+&prompt.root; <userinput>pw groupshow teamtwo</userinput>
+teamtwo:*:1100:jru,db</screen>
+    </example>
+    <para>The argument to the <option>-m</option> option is a
+      comma-delimited list of users who are to be added to the group. Unlike
+      the previous example, these users are added to the group and do not
+      replace the list of users in the group.
+    </para>
     <example>
       <title>Using &man.id.1; to Determine Group Membership</title>



>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/122476: commit references a PR
Date: Thu, 24 Apr 2008 16:17:55 +0000 (UTC)

 roam        2008-04-24 16:17:44 UTC
 
   FreeBSD doc repository
 
   Modified files:
     en_US.ISO8859-1/books/handbook/users chapter.sgml 
   Log:
   Clarify the use of the "-M" and "-m" options to "pw groupmod" in
   the "Groups" section.  Specifically, explain that "-M" sets the group
   memberlist to the exact userlist specified, while "-m" adds to
   the current list.
   
   PR:             122476
   Submitted by:   db
   
   Revision  Changes    Path
   1.59      +15 -2     doc/en_US.ISO8859-1/books/handbook/users/chapter.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: roam 
State-Changed-When: Thu Apr 24 16:24:29 UTC 2008 
State-Changed-Why:  
I've just committed a slightly modified version of your patch. 
Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122476 
>Unformatted:
