From moonshade@pnhz.kz  Mon Nov 26 09:43:57 2007
Return-Path: <moonshade@pnhz.kz>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7467B16A418
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Nov 2007 09:43:57 +0000 (UTC)
	(envelope-from moonshade@pnhz.kz)
Received: from relay.pnhz.kz (relay.pnhz.kz [212.154.198.217])
	by mx1.freebsd.org (Postfix) with ESMTP id B21C413C459
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Nov 2007 09:43:56 +0000 (UTC)
	(envelope-from moonshade@pnhz.kz)
Received: from abyss.pnhz.kz (abyss.pnhz.kz [192.168.121.40])
	by relay.pnhz.kz with ESMTP id lAQ9XZwf090773
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Nov 2007 15:33:47 +0600 (ALMT)
	(envelope-from moonshade@pnhz.kz)
Message-Id: <1196069626.87262@abyss.pnhz.kz>
Date: Mon, 26 Nov 2007 15:33:46 +0600
From: "Denis Eremenko <moonshade@pnhz.kz>" <moonshade@pnhz.kz>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: Base NTP: NO_NTP support + NO_SHAREDOCS applies to NTP's HTMLs
X-Send-Pr-Version: gtk-send-pr 0.4.8 
X-GNATS-Notify:

>Number:         118261
>Category:       docs
>Synopsis:       [patch] Base NTP: NO_NTP support + NO_SHAREDOCS applies to NTP's HTMLs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    trhodes
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 26 09:50:05 UTC 2007
>Closed-Date:    Thu Jan 24 09:46:57 UTC 2008
>Last-Modified:  Thu Jan 24 09:50:01 UTC 2008
>Originator:     Denis Eremenko <moonshade@pnhz.kz>
>Release:        FreeBSD 6.3-PRERELEASE i386
>Organization:
>Environment:


System: FreeBSD 6.3-PRERELEASE #0: Mon Nov 19 17:10:51 ALMT 2007
    moonshade@abyss.pnhz.kz:/usr/obj/data/os/FreeBSD/src/6/src/sys/ABYSS-6



>Description:


1. NTP-related stuff does not built with NO_NTP=yes in make.conf (just
like NO_BIND, NO_SENDMAIL and etc.)

2. If NO_SHAREDOCS defined, NTP HTML docs does not installed to
/usr/share/doc/ntp (this is not applies to man pages).



>How-To-Repeat:





>Fix:


--- no_ntp.diff begins here ---
diff -Nur share/doc.orig/Makefile share/doc/Makefile
--- share/doc.orig/Makefile	2007-11-26 13:07:28.000000000 +0600
+++ share/doc/Makefile	2007-11-26 13:06:46.000000000 +0600
@@ -1,12 +1,16 @@
 #	From: @(#)Makefile	8.1 (Berkeley) 6/5/93
 # $FreeBSD: src/share/doc/Makefile,v 1.19 2004/09/25 09:11:39 dougb Exp $
 
-SUBDIR=	${_bind9} IPv6 papers psd smm usd
+SUBDIR=	${_bind9} ${_ntp} IPv6 papers psd smm usd
 
 .if !defined(NO_BIND)
 _bind9=	bind9
 .endif
 
+.if !defined(NO_NTP)
+_ntp=	ntp
+.endif
+
 # Default output format for troff documents is ascii.
 # To generate postscript versions of troff documents, use:
 #  make PRINTERDEVICE=ps
diff -Nur share/doc.orig/ntp/Makefile share/doc/ntp/Makefile
--- share/doc.orig/ntp/Makefile	1970-01-01 06:00:00.000000000 +0600
+++ share/doc/ntp/Makefile	2007-11-26 12:53:37.000000000 +0600
@@ -0,0 +1,25 @@
+# $FreeBSD: src/usr.sbin/ntp/doc/Makefile,v 1.11.2.1 2006/05/25 20:22:54 pav Exp $
+
+FILESDIR=	${SHAREDIR}/doc/ntp
+
+FILES=	accopt.html assoc.html audio.html authopt.html build.html \
+	clockopt.html \
+	config.html confopt.html copyright.html debug.html driver1.html \
+	driver10.html driver11.html driver12.html driver16.html driver18.html \
+	driver19.html driver2.html driver20.html driver22.html driver23.html \
+	driver24.html driver26.html driver27.html driver28.html driver29.html \
+	driver3.html driver30.html driver32.html driver33.html driver34.html \
+	driver35.html driver36.html driver37.html \
+	driver4.html driver5.html driver6.html driver7.html driver8.html \
+	driver9.html extern.html hints.html \
+	howto.html index.html kern.html \
+	ldisc.html measure.html miscopt.html monopt.html mx4200data.html \
+	notes.html ntpd.html ntpdate.html ntpdc.html ntpq.html ntptime.html \
+	ntptrace.html parsedata.html parsenew.html patches.html porting.html \
+	pps.html prefer.html quick.html rdebug.html refclock.html \
+	release.html tickadj.html
+
+.PATH: ${.CURDIR}/../../../contrib/ntp/html \
+	${.CURDIR}/../../../contrib/ntp/html/drivers
+
+.include <bsd.prog.mk>
--- usr.sbin/Makefile.orig	2007-11-26 13:03:20.000000000 +0600
+++ usr.sbin/Makefile	2007-11-26 13:03:55.000000000 +0600
@@ -106,7 +106,7 @@
 	ngctl \
 	nghook \
 	nologin \
-	ntp \
+	${_ntp} \
 	${_ofwdump} \
 	${_pccard} \
 	pciconf \
@@ -259,6 +259,10 @@
 _lpr=		lpr
 .endif
 
+.if !defined(NO_NTP)
+_ntp=		ntp
+.endif
+
 .if !defined(NO_SENDMAIL)
 _editmap=	editmap
 _mailstats=	mailstats
--- share/examples/etc/make.conf.orig	2007-11-26 13:19:51.000000000 +0600
+++ share/examples/etc/make.conf	2007-11-26 13:20:58.000000000 +0600
@@ -130,6 +130,7 @@
 #			# If NO_NIS is set, you might need to adopt your
 #			# nsswitch.conf(5) and remove `nis' entries.
 #NO_NLS_CATALOGS=	# do not build NLS catalog support for csh(1)
+#NO_NTP=		# do not build NTP related programs
 #NO_OBJC=		# do not build Objective C support
 #NO_OPENSSH=		# do not build OpenSSH
 #NO_OPENSSL=		# do not build OpenSSL (implies NO_KERBEROS/NO_OPENSSH)
--- usr.sbin/ntp/doc/Makefile.orig	2007-11-26 12:52:56.000000000 +0600
+++ usr.sbin/ntp/doc/Makefile	2007-11-26 12:54:03.000000000 +0600
@@ -1,28 +1,6 @@
 # $FreeBSD: src/usr.sbin/ntp/doc/Makefile,v 1.11.2.1 2006/05/25 20:22:54 pav Exp $
 
-FILESDIR=	${SHAREDIR}/doc/ntp
-
-FILES=	accopt.html assoc.html audio.html authopt.html build.html \
-	clockopt.html \
-	config.html confopt.html copyright.html debug.html driver1.html \
-	driver10.html driver11.html driver12.html driver16.html driver18.html \
-	driver19.html driver2.html driver20.html driver22.html driver23.html \
-	driver24.html driver26.html driver27.html driver28.html driver29.html \
-	driver3.html driver30.html driver32.html driver33.html driver34.html \
-	driver35.html driver36.html driver37.html \
-	driver4.html driver5.html driver6.html driver7.html driver8.html \
-	driver9.html extern.html hints.html \
-	howto.html index.html kern.html \
-	ldisc.html measure.html miscopt.html monopt.html mx4200data.html \
-	notes.html ntpd.html ntpdate.html ntpdc.html ntpq.html ntptime.html \
-	ntptrace.html parsedata.html parsenew.html patches.html porting.html \
-	pps.html prefer.html quick.html rdebug.html refclock.html \
-	release.html tickadj.html
-
 MAN=	ntp.conf.5 ntp.keys.5
 MAN+=	ntp-keygen.8 ntpd.8 ntpdate.8 ntpdc.8 ntpq.8 ntptime.8 ntptrace.8
 
-.PATH: ${.CURDIR}/../../../contrib/ntp/html \
-	${.CURDIR}/../../../contrib/ntp/html/drivers
-
 .include <bsd.prog.mk>
--- share/man/man5/make.conf.5.orig	2007-11-26 14:40:30.000000000 +0600
+++ share/man/man5/make.conf.5	2007-11-26 14:42:26.000000000 +0600
@@ -585,6 +585,9 @@
 .Pq Vt bool
 Set to not build NLS catalog support for
 .Xr csh 1 .
+.It Va NO_NTP
+.Pq Vt bool
+Set to not build NTP related programs.
 .It Va NO_OBJC
 .Pq Vt bool
 Set to not build Objective C support.
--- no_ntp.diff ends here ---



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-doc 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Nov 26 10:47:47 UTC 2007 
Responsible-Changed-Why:  
reclassify. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118261 

From: Tom Rhodes <trhodes@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: "Denis Eremenko <moonshade@pnhz.kz>" <moonshade@pnhz.kz>
Subject: Re: docs/118261: [patch] Base NTP: NO_NTP support + NO_SHAREDOCS
 applies to NTP's HTMLs
Date: Wed, 23 Jan 2008 20:48:44 -0500

 Hi,
 
 The patch here is actually incorrect and is the long way to do it.
 
 Looking at the Makefile(s) in question, it appears that NO_MAN
 implies both NO_MAN and NO_SHAREDOCS whether the user wants this
 or not.  I've submitted the following patch to another person
 for review.  It correctly wraps the manual pages in NO_MAN, and
 wraps the share docs into NO_SHAREDOCS.  The only issues I
 think the only other changes to this patch would probably be
 to not enter the docs directory at all if both NO_SHAREDOCS
 and NO_MAN are set.  This could be done with a different change
 to the Makefile if:
 
 .if !defined(NO_SHAREDOCS) && !defined(NO_MAN)
 subdir+=	doc
 .endif
 
 In place of my change which implicitly adds the doc subdir to
 the list.
 
 --- doc/Makefile	25 May 2006 20:22:54 -0000	1.11.2.1
 +++ doc/Makefile	24 Jan 2008 01:42:50 -0000
 @@ -1,5 +1,6 @@
  # $FreeBSD: src/usr.sbin/ntp/doc/Makefile,v 1.11.2.1 2006/05/25 20:22:54 pav Exp $
  
 +.if !defined(NO_SHAREDOCS)
  FILESDIR=	${SHAREDIR}/doc/ntp
  
  FILES=	accopt.html assoc.html audio.html authopt.html build.html \
 @@ -19,10 +20,14 @@
  	pps.html prefer.html quick.html rdebug.html refclock.html \
  	release.html tickadj.html
  
 +.PATH: ${.CURDIR}/../../../contrib/ntp/html \
 +        ${.CURDIR}/../../../contrib/ntp/html/drivers
 +
 +.endif
 +
 +.if !defined(NO_MAN)
  MAN=	ntp.conf.5 ntp.keys.5
  MAN+=	ntp-keygen.8 ntpd.8 ntpdate.8 ntpdc.8 ntpq.8 ntptime.8 ntptrace.8
 -
 -.PATH: ${.CURDIR}/../../../contrib/ntp/html \
 -	${.CURDIR}/../../../contrib/ntp/html/drivers
 +.endif
  
  .include <bsd.prog.mk>
 
 Thanks,
 
 -- 
 Tom Rhodes
State-Changed-From-To: open->analyzed 
State-Changed-By: trhodes 
State-Changed-When: Thu Jan 24 01:50:13 UTC 2008 
State-Changed-Why:  
Switch to analyzed, I have submitted a patch for review which is available in 
this PR. 


Responsible-Changed-From-To: freebsd-doc->trhodes 
Responsible-Changed-By: trhodes 
Responsible-Changed-When: Thu Jan 24 01:50:13 UTC 2008 
Responsible-Changed-Why:  
Take - I'll see it through. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118261 
State-Changed-From-To: analyzed->closed 
State-Changed-By: trhodes 
State-Changed-When: Thu Jan 24 09:46:30 UTC 2008 
State-Changed-Why:  
This has now been fixed in RELENG_6, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118261 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/118261: commit references a PR
Date: Thu, 24 Jan 2008 09:46:11 +0000 (UTC)

 trhodes     2008-01-24 09:46:05 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     usr.sbin/ntp         Makefile 
     usr.sbin/ntp/doc     Makefile 
   Log:
   MFC:
   : ru          2006-03-15 11:17:31 UTC
   :
   :   FreeBSD src repository
   :
   :   Modified files:
   :     usr.sbin/ntp         Makefile
   :     usr.sbin/ntp/doc     Makefile
   :   Log:
   :   If we don't want HTML docs, we might still want manpages.
   :   If we don't want manpages, we might still want HTML docs.
   :
   :   Revision  Changes    Path
   :   1.12      +0 -3      src/usr.sbin/ntp/Makefile
   :   1.12      +2 -0      src/usr.sbin/ntp/doc/Makefile
   
   PR:     118261
   
   Revision  Changes    Path
   1.11.2.1  +0 -3      src/usr.sbin/ntp/Makefile
   1.11.2.2  +2 -0      src/usr.sbin/ntp/doc/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
