From nobody@FreeBSD.org  Wed Sep 26 22:21:06 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C2D2A16A419
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Sep 2007 22:21:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A51C113C455
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Sep 2007 22:21:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l8QML6lX000817
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Sep 2007 22:21:06 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l8QML6Ao000816;
	Wed, 26 Sep 2007 22:21:06 GMT
	(envelope-from nobody)
Message-Id: <200709262221.l8QML6Ao000816@www.freebsd.org>
Date: Wed, 26 Sep 2007 22:21:06 GMT
From: Jens Khler <mail@chatty.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Documentation mistake: CXD1947 _not_ supported, see fwohci_pci.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         116680
>Category:       docs
>Synopsis:       [patch] fwohci(4): Documentation mistake: CXD1947 _not_ supported, see fwohci_pci.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 26 22:30:01 GMT 2007
>Closed-Date:    Mon Jun 02 09:47:50 UTC 2008
>Last-Modified:  Mon Jun 02 09:47:50 UTC 2008
>Originator:     Jens Khler
>Release:        since 5.5 or so
>Organization:
n/a
>Environment:
see above
>Description:
FreeBSD probably NEVER supported CXD1947! What a pity.

See your own patch:

==== //depot/projects/smpng/sys/dev/firewire/fwohci_pci.c#35 (text+ko) ====

@@ -31,7 +31,7 @@
  * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  *
- * $FreeBSD: src/sys/dev/firewire/fwohci_pci.c,v 1.52 2005/05/20 12:37:16 marius Exp $
+ * $FreeBSD: src/sys/dev/firewire/fwohci_pci.c,v 1.53 2005/07/17 19:59:07 imp Exp $
  */

 #define BOUNCE_BUFFER_TEST	0
@@ -169,8 +169,8 @@
 		return BUS_PROBE_DEFAULT;
 	}
 	if (id == (FW_VENDORID_SONY | FW_DEVICE_CXD1947)) {
-		device_set_desc(dev, "Sony i.LINK (CXD1947)");
-		return BUS_PROBE_DEFAULT;
+		device_printf(dev, "Sony i.LINK (CXD1947) not supported");
+		return ENXIO;
 	}
 	if (id == (FW_VENDORID_SONY | FW_DEVICE_CXD3222)) {
 		device_set_desc(dev, "Sony i.LINK (CXD3222)");
>How-To-Repeat:
install on adequate hardware
>Fix:
write some cool driver

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: linimon 
State-Changed-When: Wed Sep 26 22:50:55 UTC 2007 
State-Changed-Why:  
So where is the part of the documentation that has the bug, so we can 
address it? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116680 
State-Changed-From-To: feedback->analyzed 
State-Changed-By: linimon 
State-Changed-When: Mon Mar 3 07:02:45 UTC 2008 
State-Changed-Why:  
OK, after some investigation I've figured out where the manpage lives. 
OTOH I don't have any manpage-fu so all I can do is generate the patch 
(which seems obvious). 

Is anyone from docs interested in testing and comitting? 

cvs diff: Diffing . 
Index: fwohci.4 
=================================================================== 
RCS file: /home/FreeBSD/ncvs/src/share/man/man4/fwohci.4,v 
retrieving revision 1.16 
diff -r1.16 fwohci.4 
102,103d101 
< Sony i.LINK (CXD1947) 
< .It 



Responsible-Changed-From-To: freebsd-bugs->freebsd-doc 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Mar 3 07:02:45 UTC 2008 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=116680 
State-Changed-From-To: analyzed->patched 
State-Changed-By: brueffer 
State-Changed-When: Mon Mar 3 09:56:10 CET 2008 
State-Changed-Why:  
Fixed in CURRENT, MFC pending. Thanks! 


Responsible-Changed-From-To: freebsd-doc->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Mon Mar 3 09:56:10 CET 2008 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116680 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/116680: commit references a PR
Date: Mon,  3 Mar 2008 08:55:59 +0000 (UTC)

 brueffer    2008-03-03 08:55:50 UTC
 
   FreeBSD src repository
 
   Modified files:
     share/man/man4       fwohci.4 
   Log:
   The Sony i.LINK (CXD1947) is _not_ supported.
   
   PR:             116680
   Submitted by:   Jens Khler <mail@chatty.de>
   MFC after:      3 days
   
   Revision  Changes    Path
   1.17      +1 -3      src/share/man/man4/fwohci.4
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gavin 
State-Changed-When: Mon Jun 2 09:47:18 UTC 2008 
State-Changed-Why:  
This doc bug is fixed in HEAD, RELENG_7 and RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116680 
>Unformatted:
