From nobody@FreeBSD.org  Sun Mar 11 20:29:43 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5D44F16A4CD
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2007 20:29:43 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 3B77E13C45A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2007 20:29:43 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l2BKTg1M025208
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2007 20:29:43 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l2BKTgsb025207;
	Sun, 11 Mar 2007 20:29:42 GMT
	(envelope-from nobody)
Message-Id: <200703112029.l2BKTgsb025207@www.freebsd.org>
Date: Sun, 11 Mar 2007 20:29:42 GMT
From: Jamie Jones<jamie@bishopston.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: VOP_FSYNC() and VFS_SYNC() man pages need "cred" removal
X-Send-Pr-Version: www-3.0

>Number:         110200
>Category:       docs
>Synopsis:       [patch] VOP_FSYNC() and VFS_SYNC() man pages need "cred" removal
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 11 20:30:04 GMT 2007
>Closed-Date:    Sat May 19 11:27:34 GMT 2007
>Last-Modified:  Sat May 19 11:27:34 GMT 2007
>Originator:     Jamie Jones
>Release:        6.2-RELEASE
>Organization:
>Environment:
FreeBSD thompson.bishopston.net 6.2-STABLE FreeBSD 6.2-STABLE #0: Mon Feb 26 09:23:42 GMT 2007     root@thompson.bishopston.net:/usr/obj/usr/src/sys/THOMPSON  i386
>Description:
The man pages for VOP_FSYNC and VFS_SYNC still reference the "cred" parameter which has long since been removed.

i.e. int
     VOP_FSYNC(struct vnode *vp, struct ucred *cred, int waitfor,
         struct thread *td);
and int
     VFS_SYNC(struct mount *mp, int waitfor, struct ucred *cred,
         struct thread *td);


>How-To-Repeat:
man VOP_FSYNC
man VFS_SYNC
>Fix:
Updated the man pages as per the attached patch

cheers, 
Jamie

Patch attached with submission follows:

--- share/man/man9/VFS_SYNC.9.orig	Sun Mar 11 20:22:14 2007
+++ share/man/man9/VFS_SYNC.9	Sun Mar 11 20:24:00 2007
@@ -39,7 +39,7 @@
 .In sys/mount.h
 .In sys/vnode.h
 .Ft int
-.Fn VFS_SYNC "struct mount *mp" "int waitfor" "struct ucred *cred" "struct thread *td"
+.Fn VFS_SYNC "struct mount *mp" "int waitfor" "struct thread *td"
 .Sh DESCRIPTION
 The
 .Fn VFS_SYNC
@@ -61,8 +61,6 @@
 .It Dv MNT_LAZY
 push data not written by file system syncer
 .El
-.It Fa cred
-The caller's credentials.
 .It Fa td
 The calling thread.
 .El

--- share/man/man9/VOP_FSYNC.9.orig	Sun Mar 11 20:22:39 2007
+++ share/man/man9/VOP_FSYNC.9	Sun Mar 11 20:24:53 2007
@@ -38,7 +38,7 @@
 .In sys/param.h
 .In sys/vnode.h
 .Ft int
-.Fn VOP_FSYNC "struct vnode *vp" "struct ucred *cred" "int waitfor" "struct thread *td"
+.Fn VOP_FSYNC "struct vnode *vp" "int waitfor" "struct thread *td"
 .Sh DESCRIPTION
 This call flushes any dirty file system buffers for the file.
 It is used to implement the
@@ -51,8 +51,6 @@
 .Bl -tag -width waitfor
 .It Fa vp
 The vnode of the file.
-.It Fa cred
-The caller's credentials.
 .It Fa waitfor
 Whether the function should wait for I/O to complete.
 Possible values are:
@@ -84,7 +82,7 @@
 .Sh PSEUDOCODE
 .Bd -literal
 int
-vop_fsync(struct vnode *vp, struct ucred *cred, int waitfor, struct thread *td)
+vop_fsync(struct vnode *vp, int waitfor, struct thread *td)
 {
     struct buf *bp;
     struct buf *nbp;

>Release-Note:
>Audit-Trail:

From: Jamie Jones <jamie@bishopston.net>
To: bug-followup@freebsd.org, jamie@bishopston.net
Cc:  
Subject: Re: docs/110200: VOP_FSYNC() and VFS_SYNC() man pages need "cred" removal
Date: Sun, 11 Mar 2007 20:48:28 +0000

 Incidently, these aren't the ONLY pages that need fixing in the same way.
 
 Cheers,
 Jamie
 
 -- 
 -=-=-=-  Virus Scanned by "pacha.mail.bishopston.net" using ClamAv  -=-=-=-
 Database Last Checked: Sun Mar 11 20:38:01 GMT 2007 - http://www.clamav.net/
 Database Updated     : Thu Mar  8 10:33:26 GMT 2007 - 98512 viruses scanned
State-Changed-From-To: open->patched 
State-Changed-By: pav 
State-Changed-When: Sat May 12 12:55:54 UTC 2007 
State-Changed-Why:  
Committed to HEAD; will MFC to RELENG_6 


Responsible-Changed-From-To: freebsd-doc->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Sat May 12 12:55:54 UTC 2007 
Responsible-Changed-Why:  
Committed to HEAD; will MFC to RELENG_6 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110200 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/110200: commit references a PR
Date: Sat, 12 May 2007 13:11:03 +0000 (UTC)

 pav         2007-05-12 13:10:55 UTC
 
   FreeBSD src repository (doc,ports committer)
 
   Modified files:
     share/man/man9       VFS_SYNC.9 VOP_FSYNC.9 
   Log:
   Remove cred argument, which was removed from code by phk two years ago
   
   PR:             docs/110200
   Submitted by:   Jamie Jones <jamie@bishopston.net>
   MFC after:      1 week
   
   Revision  Changes    Path
   1.16      +1 -3      src/share/man/man9/VFS_SYNC.9
   1.16      +2 -4      src/share/man/man9/VOP_FSYNC.9
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: pav 
State-Changed-When: Sat May 19 11:27:27 UTC 2007 
State-Changed-Why:  
MFC'ed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110200 
>Unformatted:
