From mharo@patrol.area51.fremont.ca.us Wed Apr  7 01:06:37 1999
Return-Path: <mharo@patrol.area51.fremont.ca.us>
Received: from patrol.area51.fremont.ca.us (d60-076.leach.ucdavis.edu [169.237.60.76])
	by hub.freebsd.org (Postfix) with ESMTP id 3BA8D15747
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Apr 1999 01:06:37 -0700 (PDT)
	(envelope-from mharo@patrol.area51.fremont.ca.us)
Received: (from mharo@localhost)
	by patrol.area51.fremont.ca.us (8.9.2/8.9.2) id BAA44782;
	Wed, 7 Apr 1999 01:04:38 -0700 (PDT)
	(envelope-from mharo)
Message-Id: <199904070804.BAA44782@patrol.area51.fremont.ca.us>
Date: Wed, 7 Apr 1999 01:04:38 -0700 (PDT)
From: mharo@area51.fremont.ca.us
Sender: mharo@patrol.area51.fremont.ca.us
Reply-To: mharo@area51.fremont.ca.us
To: FreeBSD-gnats-submit@freebsd.org
Subject: Problem with query-pr-summary.cgi
X-Send-Pr-Version: 3.2

>Number:         10997
>Category:       docs
>Synopsis:       Problem with query-pr-summary.cgi
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr  7 01:10:01 PDT 1999
>Closed-Date:    Sun Sep 9 14:05:36 PDT 2001
>Last-Modified:  Sun Sep 09 14:06:22 PDT 2001
>Originator:     Michael Haro
>Release:        FreeBSD 3.1-STABLE i386
>Organization:
>Environment:

	

>Description:

Not really sure where to file this www problem report.  It isn't really
a docs problem, it is a cgi problem, but I guess docs will do.

Doing a query where the originator contains a space gets converted into
a space from a + but not back into a + in the <A HREF stuff for the
"Include closed reports too" link on the page.

This might be messed up other places too.

>How-To-Repeat:

	

>Fix:
	
something like this might work but there is probably a better way....
$self_ref3 =~ s/ /+/g;

I'm unable to test this code patch but I think it would work.  Again,
there is probably a better way.

Index: query-pr-summary.cgi
===================================================================
RCS file: /cvs/www/en/cgi/query-pr-summary.cgi,v
retrieving revision 1.22
diff -u -r1.22 query-pr-summary.cgi
--- query-pr-summary.cgi	1999/02/26 22:05:58	1.22
+++ query-pr-summary.cgi	1999/04/07 07:58:23
@@ -176,6 +177,7 @@
 		$self_ref3 .= '&' if ($self_ref2 !~/\?$/);
 		$self_ref3 .= $_ . '=' . $input{$_};
 	}
+	$self_ref3 =~ s/ /+/g;
 }
 if ($input{"closedtoo"}) {
 	print '<A HREF="', $self_ref3, '">Don',"'",'t show closed reports</A>.';


>Release-Note:
>Audit-Trail:

From: Tom Hukins <tom@eborcom.com>
To: mharo@area51.fremont.ca.us
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: docs/10997: Problem with query-pr-summary.cgi
Date: Thu, 8 Apr 1999 13:01:16 +0100

 On Wed, Apr 07, 1999 at 01:04:38AM -0700, mharo@area51.fremont.ca.us wrote:
 > 
 > >Description:
 > 
 > Doing a query where the originator contains a space gets converted into
 > a space from a + but not back into a + in the <A HREF stuff for the
 > "Include closed reports too" link on the page.
 > 
 > >Fix:
 > 	
 > something like this might work but there is probably a better way....
 > $self_ref3 =~ s/ /+/g;
 
 Given that the script is written in Perl, a better fix might be to
 pass $self_ref4 through the URI::URL module. This would ensure
 special characters other than space are encoded properly.
 
 Tom
 
State-Changed-From-To: open->feedback 
State-Changed-By: tom 
State-Changed-When: Thu Aug 30 03:57:01 PDT 2001 
State-Changed-Why:  
This seems to have been fixed in version 1.27 of query-pr-summary.cgi, 
associated with misc/22191 - please can you confirm this is no longer a 
problem. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=10997 
State-Changed-From-To: feedback->closed 
State-Changed-By: tom 
State-Changed-When: Sun Sep 9 14:05:36 PDT 2001 
State-Changed-Why:  
Problem already fixed (see misc/22191) 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=10997 
>Unformatted:
