From kargl@troutmask.apl.washington.edu  Fri May  5 18:19:41 2006
Return-Path: <kargl@troutmask.apl.washington.edu>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2D63016A401;
	Fri,  5 May 2006 18:19:41 +0000 (UTC)
	(envelope-from kargl@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 39CFD43D5D;
	Fri,  5 May 2006 18:19:40 +0000 (GMT)
	(envelope-from kargl@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1])
	by troutmask.apl.washington.edu (8.13.6/8.13.6) with ESMTP id k45IJdBU071564;
	Fri, 5 May 2006 11:19:39 -0700 (PDT)
	(envelope-from kargl@troutmask.apl.washington.edu)
Received: (from root@localhost)
	by troutmask.apl.washington.edu (8.13.6/8.13.6/Submit) id k45IJdHF071558;
	Fri, 5 May 2006 11:19:39 -0700 (PDT)
	(envelope-from kargl)
Message-Id: <200605051819.k45IJdHF071558@troutmask.apl.washington.edu>
Date: Fri, 5 May 2006 11:19:39 -0700 (PDT)
From: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>
Reply-To: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc: ru@freebsd.org
Subject: [PATCH] Update Fortran related variables in sys.mk
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         96834
>Category:       conf
>Synopsis:       [PATCH] Update Fortran related variables in sys.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 05 18:20:18 GMT 2006
>Closed-Date:    Sat May 06 14:51:31 GMT 2006
>Last-Modified:  Sat May 06 14:51:31 GMT 2006
>Originator:     Steven G. Kargl
>Release:        FreeBSD 7.0-CURRENT amd64
>Organization:
APL/UW
>Environment:
System: FreeBSD troutmask.apl.washington.edu 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Thu Apr 13 10:34:17 PDT 2006 root@troutmask.apl.washington.edu:/usr/obj/usr/src/sys/SPEW amd64


	
>Description:

The sys.mk file currently defines "FFLAGS = -O" for the default
Fortran compilation options while "CFLAGS = -O2 -pipe".  Futhermore,
the .if (POSIX) conditional is unnecessary.  FreeBSD has never had a
fort77 program and it never will.
	
>How-To-Repeat:
	
>Fix:

The patch removes the POSIX conditional and updates
the default Fortran flags.

--- sys.mk.orig	Fri May  5 11:12:58 2006
+++ sys.mk	Fri May  5 11:13:46 2006
@@ -63,13 +63,8 @@
 _+_		?=	+
 .endif
 
-.if defined(%POSIX)
-FC		?=	fort77
-FFLAGS		?=	-O 1
-.else
 FC		?=	f77
-FFLAGS		?=	-O
-.endif
+FFLAGS		?=	-O2 -pipe
 EFLAGS		?=
 
 INSTALL		?=	install

>Release-Note:
>Audit-Trail:

From: Ruslan Ermilov <ru@FreeBSD.org>
To: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>
Cc: bug-followup@FreeBSD.org
Subject: Re: conf/96834: [PATCH] Update Fortran related variables in sys.mk
Date: Sat, 6 May 2006 16:50:34 +0300

 On Fri, May 05, 2006 at 11:19:39AM -0700, Steven G. Kargl wrote:
 > 
 > The sys.mk file currently defines "FFLAGS = -O" for the default
 > Fortran compilation options while "CFLAGS = -O2 -pipe".
 > 
 I don't have an opinion about this, since I don't know what
 -O2 does exactly when applied to f77(1).
 
 > Futhermore,
 > the .if (POSIX) conditional is unnecessary.  FreeBSD has never had a
 > fort77 program and it never will.
 > 	
 This is irrelevant.  POSIX requires that these variables be set
 as follows:
 
 FC=fort77
 FFLAGS=-O 1
 
 So we do.
 
 > The patch removes the POSIX conditional and updates
 > the default Fortran flags.
 > 
 > --- sys.mk.orig	Fri May  5 11:12:58 2006
 > +++ sys.mk	Fri May  5 11:13:46 2006
 > @@ -63,13 +63,8 @@
 >  _+_		?=	+
 >  .endif
 >  
 > -.if defined(%POSIX)
 > -FC		?=	fort77
 > -FFLAGS		?=	-O 1
 > -.else
 >  FC		?=	f77
 > -FFLAGS		?=	-O
 > -.endif
 > +FFLAGS		?=	-O2 -pipe
 >  EFLAGS		?=
 >  
 >  INSTALL		?=	install
 
 -- 
 Ruslan Ermilov
 ru@FreeBSD.org
 FreeBSD committer

From: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>
To: Ruslan Ermilov <ru@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: conf/96834: [PATCH] Update Fortran related variables in sys.mk
Date: Sat, 6 May 2006 07:44:15 -0700 (PDT)

 Ruslan Ermilov wrote:
 > On Fri, May 05, 2006 at 11:19:39AM -0700, Steven G. Kargl wrote:
 > > 
 > > The sys.mk file currently defines "FFLAGS = -O" for the default
 > > Fortran compilation options while "CFLAGS = -O2 -pipe".
 > > 
 > I don't have an opinion about this, since I don't know what
 > -O2 does exactly when applied to f77(1).
 
 f77(1) is g77 that is bundled with our gcc.  The optimizations
 turned on by -O2 apply to both gcc and g77 (it's the same
 middle and back ends).
 
 > > 	
 > This is irrelevant.  POSIX requires that these variables be set
 
 Ugh.
 
 You can close the PR without applying the patch.
 
 -- 
 Steve
 http://troutmask.apl.washington.edu/~kargl/
State-Changed-From-To: open->closed 
State-Changed-By: ru 
State-Changed-When: Sat May 6 14:51:08 UTC 2006 
State-Changed-Why:  
Closed per originator's request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=96834 
>Unformatted:
