From nobody@FreeBSD.org  Thu Jan  5 10:21:26 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8A0B616A422
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  5 Jan 2006 10:21:26 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2582343D5C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  5 Jan 2006 10:21:25 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k05ALNpa020234
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 5 Jan 2006 10:21:23 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k05ALNOp020233;
	Thu, 5 Jan 2006 10:21:23 GMT
	(envelope-from nobody)
Message-Id: <200601051021.k05ALNOp020233@www.freebsd.org>
Date: Thu, 5 Jan 2006 10:21:23 GMT
From: Guy Harris <guy@alum.mit.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Errors in devfs.rules files don't get logged
X-Send-Pr-Version: www-2.3

>Number:         91342
>Category:       conf
>Synopsis:       [devfs] Errors in devfs.rules files don't get logged
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 05 10:30:06 GMT 2006
>Closed-Date:    Fri Feb 11 16:03:30 UTC 2011
>Last-Modified:  Fri Feb 11 16:03:30 UTC 2011
>Originator:     Guy Harris
>Release:        FreeBSD 6.0-RELEASE i386
>Organization:
>Environment:
FreeBSD marconi.local 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Thu Nov 3 09:36:13 UTC 2005 root@x64.samsco.home:/usr/obj/usr/src/sys/GENERIC i386
>Description:
              If there's an error in /etc/defaults/devfs.rules or /etc/devfs.rules, no error message about the error appears in, for example, /var/log/messages.
>How-To-Repeat:
              Put in a rule with, for example, an invalid mode, such as rw-rw----. 
>Fix:
              
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: jh 
Responsible-Changed-When: Tue Dec 21 16:38:50 UTC 2010 
Responsible-Changed-Why:  
Reassign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91342 

From: Jaakko Heinonen <jh@FreeBSD.org>
To: bug-followup@FreeBSD.org, guy@alum.mit.edu
Cc:  
Subject: Re: conf/91342: [devfs] Errors in devfs.rules files don't get logged
Date: Tue, 21 Dec 2010 18:45:15 +0200

 Guy Harris wrote:
 > If there's an error in /etc/defaults/devfs.rules or /etc/devfs.rules,
 > no error message about the error appears in, for example,
 > /var/log/messages.
 
 How about this patch?
 
 %%%
 Index: etc/rc.subr
 ===================================================================
 --- etc/rc.subr	(revision 216581)
 +++ etc/rc.subr	(working copy)
 @@ -1349,7 +1349,10 @@ devfs_init_rulesets()
  		return
  	fi
  	for file in $devfs_rulesets; do
 -		devfs_rulesets_from_file $file || return 1
 +		if ! devfs_rulesets_from_file $file; then
 +			warn "$_me: could not read rules from $file"
 +			return 1
 +		fi
  	done
  	devfs_rulesets_init=1
  	debug "$_me: devfs rulesets initialized"
 %%%
 
 -- 
 Jaakko
Responsible-Changed-From-To: freebsd-rc->jh 
Responsible-Changed-By: jh 
Responsible-Changed-When: Fri Jan 7 10:50:38 UTC 2011 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91342 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/91342: commit references a PR
Date: Fri,  7 Jan 2011 10:59:31 +0000 (UTC)

 Author: jh
 Date: Fri Jan  7 10:59:22 2011
 New Revision: 217090
 URL: http://svn.freebsd.org/changeset/base/217090
 
 Log:
   Warn if rules could not be read from a ruleset file. Now at least
   something gets logged if the file has syntax errors.
   
   PR:		conf/91342
   Silence on:	freebsd-rc
 
 Modified:
   head/etc/rc.subr
 
 Modified: head/etc/rc.subr
 ==============================================================================
 --- head/etc/rc.subr	Fri Jan  7 08:45:56 2011	(r217089)
 +++ head/etc/rc.subr	Fri Jan  7 10:59:22 2011	(r217090)
 @@ -1349,7 +1349,10 @@ devfs_init_rulesets()
  		return
  	fi
  	for file in $devfs_rulesets; do
 -		devfs_rulesets_from_file $file || return 1
 +		if ! devfs_rulesets_from_file $file; then
 +			warn "$_me: could not read rules from $file"
 +			return 1
 +		fi
  	done
  	devfs_rulesets_init=1
  	debug "$_me: devfs rulesets initialized"
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: jh 
State-Changed-When: Fri Jan 7 11:05:23 UTC 2011 
State-Changed-Why:  
Patched in head (r217090). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91342 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/91342: commit references a PR
Date: Wed,  9 Feb 2011 15:55:55 +0000 (UTC)

 Author: jh
 Date: Wed Feb  9 15:55:48 2011
 New Revision: 218489
 URL: http://svn.freebsd.org/changeset/base/218489
 
 Log:
   MFC r217090:
   
   Warn if rules could not be read from a ruleset file. Now at least
   something gets logged if the file has syntax errors.
   
   PR:		conf/91342
 
 Modified:
   stable/8/etc/rc.subr
 Directory Properties:
   stable/8/etc/   (props changed)
 
 Modified: stable/8/etc/rc.subr
 ==============================================================================
 --- stable/8/etc/rc.subr	Wed Feb  9 15:43:38 2011	(r218488)
 +++ stable/8/etc/rc.subr	Wed Feb  9 15:55:48 2011	(r218489)
 @@ -1348,7 +1348,10 @@ devfs_init_rulesets()
  		return
  	fi
  	for file in $devfs_rulesets; do
 -		devfs_rulesets_from_file $file || return 1
 +		if ! devfs_rulesets_from_file $file; then
 +			warn "$_me: could not read rules from $file"
 +			return 1
 +		fi
  	done
  	devfs_rulesets_init=1
  	debug "$_me: devfs rulesets initialized"
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/91342: commit references a PR
Date: Fri, 11 Feb 2011 10:06:54 +0000 (UTC)

 Author: jh
 Date: Fri Feb 11 10:06:49 2011
 New Revision: 218549
 URL: http://svn.freebsd.org/changeset/base/218549
 
 Log:
   MFC r217090:
   
   Warn if rules could not be read from a ruleset file. Now at least
   something gets logged if the file has syntax errors.
   
   PR:		conf/91342
 
 Modified:
   stable/7/etc/rc.subr
 Directory Properties:
   stable/7/etc/   (props changed)
 
 Modified: stable/7/etc/rc.subr
 ==============================================================================
 --- stable/7/etc/rc.subr	Fri Feb 11 09:58:38 2011	(r218548)
 +++ stable/7/etc/rc.subr	Fri Feb 11 10:06:49 2011	(r218549)
 @@ -1242,7 +1242,10 @@ devfs_init_rulesets()
  		return
  	fi
  	for file in $devfs_rulesets; do
 -		devfs_rulesets_from_file $file || return 1
 +		if ! devfs_rulesets_from_file $file; then
 +			warn "$_me: could not read rules from $file"
 +			return 1
 +		fi
  	done
  	devfs_rulesets_init=1
  	debug "$_me: devfs rulesets initialized"
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: jh 
State-Changed-When: Fri Feb 11 16:03:29 UTC 2011 
State-Changed-Why:  
Fixed in head, stable/8 and stable/7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91342 
>Unformatted:
