From nobody@FreeBSD.org  Tue Nov 22 16:08:21 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C4A6616A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Nov 2005 16:08:21 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EEDCF43D75
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Nov 2005 16:08:20 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jAMG8JL3096291
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Nov 2005 16:08:19 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id jAMG8J7r096290;
	Tue, 22 Nov 2005 16:08:19 GMT
	(envelope-from nobody)
Message-Id: <200511221608.jAMG8J7r096290@www.freebsd.org>
Date: Tue, 22 Nov 2005 16:08:19 GMT
From: "Scot W. Hetzel" <swhetzel@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: The example make.conf has tabs before the comment deliminator (#).
X-Send-Pr-Version: www-2.3

>Number:         89423
>Category:       conf
>Synopsis:       [patch] The example make.conf has tabs before the comment deliminator (#).
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 22 16:10:28 GMT 2005
>Closed-Date:    Sun Dec 11 20:45:19 GMT 2005
>Last-Modified:  Sun Dec 11 20:45:19 GMT 2005
>Originator:     Scot W. Hetzel
>Release:        FreeBSD 7.x-CURRENT
>Organization:
>Environment:
>Description:
Two additional comments were added for the NO_NIS variable in src/share/examples/etc/make.conf.  The author of these changes placed two tabs before the comment deliminator(#).  When this file is copied to /etc/make.conf, it causes make to report that it can't execute "# If set, you might need to adopt your" and "# nsswitch.conf(5) and remove `nis' entries."  Make expects the comment deliminator to be in the first column.

I know that some are going to say don't copy the file to /etc/make.conf, but at the top of the file it says:

# This file must be in valid Makefile syntax.

placing two tabs before the comment deliminator is not valid Makefile syntax.

>How-To-Repeat:
copy src/share/examples/etc/make.conf to /etc/make.conf
then try a buildworld
>Fix:
Index: make.conf
===================================================================
RCS file: /home/ncvs/src/share/examples/etc/make.conf,v
retrieving revision 1.269
diff -u -r1.269 make.conf
--- make.conf	23 Oct 2005 19:37:55 -0000	1.269
+++ make.conf	22 Nov 2005 07:41:35 -0000
@@ -125,8 +125,8 @@
 #NO_MODULES=		# do not build modules with the kernel
 #NO_NETCAT=		# do not build netcat
 #NO_NIS=		# do not build NIS support and related programs.
-			# If set, you might need to adopt your
-			# nsswitch.conf(5) and remove `nis' entries.
+#			# If set, you might need to adopt your
+#			# nsswitch.conf(5) and remove `nis' entries.
 #NO_OBJC=		# do not build Objective C support
 #NO_OPENSSH=		# do not build OpenSSH
 #NO_OPENSSL=		# do not build OpenSSL (implies NO_KERBEROS/NO_OPENSSH)

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: keramida 
State-Changed-When: Sun Nov 27 07:31:34 GMT 2005 
State-Changed-Why:  
Fixed, thanks for the bug report :) 


Responsible-Changed-From-To: freebsd-bugs->keramida 
Responsible-Changed-By: keramida 
Responsible-Changed-When: Sun Nov 27 07:31:34 GMT 2005 
Responsible-Changed-Why:  
I'll handle MFCs if necessary. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=89423 
State-Changed-From-To: patched->closed 
State-Changed-By: bz 
State-Changed-When: Sun Dec 11 20:43:31 UTC 2005 
State-Changed-Why:  
I MFCed the changes. Thanks for submitting. 


Responsible-Changed-From-To: keramida->bz 
Responsible-Changed-By: bz 
Responsible-Changed-When: Sun Dec 11 20:43:31 UTC 2005 
Responsible-Changed-Why:  
Take responsibility. It had been my fault. 
Thanks Giorgos for handling this initially. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=89423 
>Unformatted:
