From Andre.Albsmeier@siemens.com  Sun Sep 11 12:52:32 2005
Return-Path: <Andre.Albsmeier@siemens.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F19C416A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 11 Sep 2005 12:52:32 +0000 (GMT)
	(envelope-from Andre.Albsmeier@siemens.com)
Received: from thoth.sbs.de (thoth.sbs.de [192.35.17.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D150643D45
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 11 Sep 2005 12:52:31 +0000 (GMT)
	(envelope-from Andre.Albsmeier@siemens.com)
Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11])
	by thoth.sbs.de (8.12.6/8.12.6) with ESMTP id j8BCqU2R012236
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 11 Sep 2005 14:52:30 +0200
Received: from ims.mchp.siemens.de (ims.mchp.siemens.de [139.25.31.39])
	by mail2.siemens.de (8.12.6/8.12.6) with ESMTP id j8BCqUgY028673
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 11 Sep 2005 14:52:30 +0200
Received: from mail-ct.mchp.siemens.de (mail-ct.mchp.siemens.de [139.25.31.51])
				by ims.mchp.siemens.de  with ESMTP id j8BCqTJQ009276
				for <FreeBSD-gnats-submit@freebsd.org>; Sun, 11 Sep 2005 14:52:29 +0200 (MEST)
Received: from curry.mchp.siemens.de (curry [139.25.42.7])
	by mail-ct.mchp.siemens.de (8.12.11/8.12.11) with ESMTP id j8BCqTAV015953
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 11 Sep 2005 14:52:29 +0200 (MEST)
Received: (from localhost)
	by curry.mchp.siemens.de (8.13.4/8.13.4) id j8BCqT1r041545
	for FreeBSD-gnats-submit@freebsd.org; Sun, 11 Sep 2005 14:52:29 +0200 (CEST)
Message-Id: <200509111252.j8BCqTJ8099342@curry.mchp.siemens.de>
Date: Sun, 11 Sep 2005 14:52:29 +0200 (CEST)
From: Andre Albsmeier <Andre.Albsmeier@siemens.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: 550.ipfwlimit does not delete tmp file
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         85970
>Category:       conf
>Synopsis:       [patch] 550.ipfwlimit does not delete tmp file
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    maxim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 11 13:00:36 GMT 2005
>Closed-Date:    Tue Sep 13 14:34:58 GMT 2005
>Last-Modified:  Tue Sep 13 14:34:58 GMT 2005
>Originator:     Andre Albsmeier
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
>Environment:

System: FreeBSD 5.4-STABLE #2: Thu Aug 25 14:04:58 CEST 2005

>Description:

Since rev 1.6.4.1 /etc/periodic/security/550.ipfwlimit
creates a tmp file without deleting it if ipfw is not
used.

>How-To-Repeat:

On a FreeBSD-5.4 box without ipfw:

andre@bali:~>ls -l /tmp/security*
-rw-------  1 root  wheel  0 Sep  6 03:01 /tmp/security.BEMeBO7s
-rw-------  1 root  wheel  0 Sep 10 03:01 /tmp/security.OiHNQwdl
-rw-------  1 root  wheel  0 Sep 11 03:01 /tmp/security.PWShtLmE
-rw-------  1 root  wheel  0 Sep  8 03:01 /tmp/security.TpNslbC3
-rw-------  1 root  wheel  0 Sep  9 03:01 /tmp/security.eRuWD2Aa
-rw-------  1 root  wheel  0 Sep  7 03:01 /tmp/security.sEnKe309


>Fix:

--- 550.ipfwlimit.ORI	Sun Sep 11 14:44:52 2005
+++ 550.ipfwlimit	Sun Sep 11 14:45:20 2005
@@ -42,11 +42,11 @@
 
 case "$daily_status_security_ipfwlimit_enable" in
     [Yy][Ee][Ss])
-	TMP=`mktemp -t security`
 	IPFW_LOG_LIMIT=`sysctl -n net.inet.ip.fw.verbose_limit 2> /dev/null`
 	if [ $? -ne 0 ]; then
 		exit 0
 	fi
+	TMP=`mktemp -t security`
 	ipfw -a list | grep " log " | \
 	grep '^[[:digit:]]\+[[:space:]]\+[[:digit:]]\+' | \
 	awk -v limit="$IPFW_LOG_LIMIT" \
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Sun Sep 11 14:30:31 GMT 2005 
State-Changed-Why:  
Fixed in HEAD, thanks! 


Responsible-Changed-From-To: freebsd-bugs->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Sun Sep 11 14:30:31 GMT 2005 
Responsible-Changed-Why:  
MFC in 3 days. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85970 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Tue Sep 13 14:34:37 GMT 2005 
State-Changed-Why:  
Fixed in RELENG_5,6 as well. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85970 
>Unformatted:
