From nobody@FreeBSD.org  Sat Apr  9 15:52:47 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BA58E16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  9 Apr 2005 15:52:47 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 94CD443D54
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  9 Apr 2005 15:52:47 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j39Fql5a061069
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 9 Apr 2005 15:52:47 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j39FqlT0061068;
	Sat, 9 Apr 2005 15:52:47 GMT
	(envelope-from nobody)
Message-Id: <200504091552.j39FqlT0061068@www.freebsd.org>
Date: Sat, 9 Apr 2005 15:52:47 GMT
From: Erez Zadok <ezk@cs.sunysb.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: MNT_NODEV should be removed from sys/mount.h
X-Send-Pr-Version: www-2.3

>Number:         79715
>Category:       conf
>Synopsis:       MNT_NODEV should be removed from sys/mount.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rodrigc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 09 16:00:49 GMT 2005
>Closed-Date:    Mon May 22 19:07:06 GMT 2006
>Last-Modified:  Mon May 22 19:07:06 GMT 2006
>Originator:     Erez Zadok
>Release:        6.0
>Organization:
Stony Brook University
>Environment:
FreeBSD a-freebsd6.fsl.cs.sunysb.edu 6.0-CURRENT-SNAP001 FreeBSD 6.0-CURRENT-SNAP001 #0: Fri Feb  4 22:20:07 UTC 2005     root@x64.samsco.home:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
I maintain am-utils (www.am-utils.org).  Users reported some problems to me, which I tracked down to a depracated definition of MNT_NODEV in sys/mount.h.  It was left there, but reset to 0:

#define MNT_NODEV       0               /* Deprecated option */

This is incompatible with systems which use autoconf, because they "autodetect" that MNT_NODEV exists, and are happy to say that the "nodev" mount option exists.  Am-utils gets confused.  While I was able to work around this issue in am-utils-6.1-rc1, I think it is simply best to remove obsolste defintiion from code and let people fix their code properly: leaving them there but changing their values is causing worse confusion.

I filled out this PR at the reques of Kris Kennaway <kris@obsecurity.org>.


>How-To-Repeat:
      
>Fix:
      
>Release-Note:
>Audit-Trail:

From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: conf/79715: MNT_NODEV should be removed from sys/mount.h 
Date: Sat, 09 Apr 2005 18:05:06 +0200

 In message <200504091552.j39FqlT0061068@www.freebsd.org>, Erez Zadok writes:
 
 
 >I maintain am-utils (www.am-utils.org).  Users reported some
 >problems to me, which I tracked down to a depracated definition of
 >MNT_NODEV in sys/mount.h.  It was left there, but reset to 0:
 >
 >#define MNT_NODEV       0               /* Deprecated option */
 >
 
 I'm perfectly OK with removing it, but didn't out of fear of what
 I might break.  I guess this was a loose-loose scenario...
 
 -- 
 Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
 phk@FreeBSD.ORG         | TCP/IP since RFC 956
 FreeBSD committer       | BSD since 4.3-tahoe    
 Never attribute to malice what can adequately be explained by incompetence.

From: Erez Zadok <ezk@cs.sunysb.edu>
To: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
Cc: Erez Zadok <ezk@cs.sunysb.edu>, freebsd-gnats-submit@freebsd.org
Subject: Re: conf/79715: MNT_NODEV should be removed from sys/mount.h 
Date: Sat, 9 Apr 2005 12:18:08 -0400

 In message <28785.1113062706@critter.freebsd.dk>, "Poul-Henning Kamp" writes:
 > In message <200504091552.j39FqlT0061068@www.freebsd.org>, Erez Zadok writes:
 > 
 > 
 > >I maintain am-utils (www.am-utils.org).  Users reported some
 > >problems to me, which I tracked down to a depracated definition of
 > >MNT_NODEV in sys/mount.h.  It was left there, but reset to 0:
 > >
 > >#define MNT_NODEV       0               /* Deprecated option */
 > >
 > 
 > I'm perfectly OK with removing it, but didn't out of fear of what
 > I might break.  I guess this was a loose-loose scenario...
 
 If the actual NODEV functionallity had been removed from the kernel itself,
 then older binaries, precompiled with whatever NODEV was before, will get
 confused b/c users will expect "nodev" to work, but it will silently not
 work.
 
 > Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
 > phk@FreeBSD.ORG         | TCP/IP since RFC 956
 > FreeBSD committer       | BSD since 4.3-tahoe    
 > Never attribute to malice what can adequately be explained by incompetence.
 
 Thanks,
 Erez.
Responsible-Changed-From-To: freebsd-bugs->rodrigc 
Responsible-Changed-By: rodrigc 
Responsible-Changed-When: Wed Nov 23 21:05:31 GMT 2005 
Responsible-Changed-Why:  
Taking this, since I am looking at a lot of filesystem mounting stuff. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79715 
State-Changed-From-To: open->patched 
State-Changed-By: rodrigc 
State-Changed-When: Tue Nov 29 19:20:17 GMT 2005 
State-Changed-Why:  
This option has been removed in -CURRENT.  Not likely to be merged 
to RELENG_6, since this is a non-backwards compatible change. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79715 
State-Changed-From-To: patched->closed 
State-Changed-By: rodrigc 
State-Changed-When: Mon May 22 19:05:29 UTC 2006 
State-Changed-Why:  
MNT_NODEV removed from CURRENT, but will not be removed from RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79715 
>Unformatted:
