From pink@eniac.fsz.bme.hu  Tue Aug  4 06:38:51 1998
Received: from eniac.fsz.bme.hu (eniac.fsz.bme.hu [152.66.76.8])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA26593
          for <FreeBSD-gnats-submit@freebsd.org>; Tue, 4 Aug 1998 06:38:46 -0700 (PDT)
          (envelope-from pink@eniac.fsz.bme.hu)
Received: (from root@localhost)
          by eniac.fsz.bme.hu (8.8.8/8.8.4)
	  id PAA05643; Tue, 4 Aug 1998 15:38:31 +0200 (CEST)
Message-Id: <199808041338.PAA05643@eniac.fsz.bme.hu>
Date: Tue, 4 Aug 1998 15:38:31 +0200 (CEST)
From: Szabolcs Szigeti (PinkPanther) <pink@eniac.fsz.bme.hu>
Reply-To: pink@eniac.fsz.bme.hu
To: FreeBSD-gnats-submit@freebsd.org
Subject: /etc/login.conf not preserved during update
X-Send-Pr-Version: 3.2

>Number:         7491
>Category:       conf
>Synopsis:       /etc/login.conf not preserved during update
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug  4 06:40:00 PDT 1998
>Closed-Date:    Thu Aug 6 23:10:44 PDT 1998
>Last-Modified:  Tue Aug 11 11:30:01 PDT 1998
>Originator:     Szabolcs Szigeti (PinkPanther)
>Release:        FreeBSD 2.2.7-RELEASE i386
>Organization:
Technical University of Budapest
>Environment:

	System running 2.2.5-RELEASE updated to 2.2.7-RELEASE

>Description:

	During update to 2.2.7-RELEASE the file /etc/login.conf is overwritten 
        with the new version.

>How-To-Repeat:

	Update to 2.2.7-RELEASE using the "update" procedure on the boot floppy
>Fix:
	
	Copy the saved login.conf (from /usr/tmp/etc) to /etc

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: phk 
State-Changed-When: Thu Aug 6 23:10:44 PDT 1998 
State-Changed-Why:  
I belive you should save all your config files before doing an update 

From: Stefan Eggers <seggers@semyam.dinoco.de>
To: pink@eniac.fsz.bme.hu
Cc: FreeBSD-gnats-submit@FreeBSD.ORG, seggers@semyam.dinoco.de
Subject: Re: conf/7491: /etc/login.conf not preserved during update 
Date: Tue, 11 Aug 1998 20:15:23 +0200

 > 	During update to 2.2.7-RELEASE the file /etc/login.conf is overwritten 
 >         with the new version.
 
 > >Fix:
 > 	
 > 	Copy the saved login.conf (from /usr/tmp/etc) to /etc
 
 Fix sysinstall instead to preserve login.conf, too.  I think this
 (untested as I have no play machine suitable for this and I update
 with "make world") will do it:
 
 Index: installUpgrade.c
 ===================================================================
 RCS file: /usr2/FreeBSD/CVSROOT/src/release/sysinstall/installUpgrade.c,v
 retrieving revision 1.58
 diff -u -r1.58 installUpgrade.c
 --- installUpgrade.c	1998/05/24 02:49:54	1.58
 +++ installUpgrade.c	1998/08/11 17:53:24
 @@ -83,6 +83,7 @@
     { JUST_COPY,		"kerberosIV",		TRUE, NULL },
     { JUST_COPY,		"localtime",		TRUE, NULL },
     { JUST_COPY,		"login.access",		TRUE, NULL },
 +   { JUST_COPY,		"login.conf",		TRUE, NULL },
     { JUST_COPY,		"mail.rc",		TRUE, NULL },
     { JUST_COPY,		"make.conf",		TRUE, NULL },
     { JUST_COPY,		"manpath.config",	TRUE, NULL },
 
 I think such a fix should go in instead of just saying that "one
 should save ones config files before update" as my gnats database says
 is the reason given for closing this PR.  Of course making a backup of
 them is still a good idea.
 
 This saving of config files is what sysinstall offers to do on an
 update installation after all.  It just fails to do it propperly for
 the file in question it seems.
 
 Stefan.
 -- 
 Stefan Eggers                 Lu4 yao2 zhi1 ma3 li4,
 Max-Slevogt-Str. 1            ri4 jiu3 jian4 ren2 xin1.
 51109 Koeln
 Federal Republic of Germany
>Unformatted:
