From root@250-217.customer.cloud9.net  Fri Oct 22 16:05:52 2004
Return-Path: <root@250-217.customer.cloud9.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8334616A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 Oct 2004 16:05:52 +0000 (GMT)
Received: from corbulon.video-collage.com (aldan.algebra.com [216.254.65.224])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 19A0943D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 Oct 2004 16:05:52 +0000 (GMT)
	(envelope-from root@250-217.customer.cloud9.net)
Received: from 250-217.customer.cloud9.net (195-11.customer.cloud9.net [168.100.195.11])
	by corbulon.video-collage.com (8.12.11/8.12.11) with ESMTP id i9MG5mpB043846
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 Oct 2004 12:05:49 -0400 (EDT)
	(envelope-from root@250-217.customer.cloud9.net)
Received: from 250-217.customer.cloud9.net (smmsp@localhost [127.0.0.1])
	by 250-217.customer.cloud9.net (8.13.1/8.13.1) with ESMTP id i9MG5eq6000775
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 Oct 2004 12:05:40 -0400 (EDT)
	(envelope-from root@250-217.customer.cloud9.net)
Received: (from root@localhost)
	by 250-217.customer.cloud9.net (8.13.1/8.13.1/Submit) id i9MG5eeO000774;
	Fri, 22 Oct 2004 12:05:40 -0400 (EDT)
	(envelope-from root)
Message-Id: <200410221605.i9MG5eeO000774@250-217.customer.cloud9.net>
Date: Fri, 22 Oct 2004 12:05:40 -0400 (EDT)
From: Mikhail Teterin <mi@aldan.algebra.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: `fsck -y' tortures clean disks needlessly
X-Send-Pr-Version: 3.113

>Number:         73008
>Category:       conf
>Synopsis:       [patch] `fsck -y' tortures clean disks needlessly
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    brian
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 22 16:10:21 GMT 2004
>Closed-Date:    Thu Jan 27 17:26:19 GMT 2005
>Last-Modified:  Thu Jan 27 17:26:19 GMT 2005
>Originator:     Mikhail Teterin
>Release:        FreeBSD 6.0-CURRENT i386
>Organization:
Virtual Estates, Inc.
>Environment:
System: FreeBSD mi 6.0-CURRENT FreeBSD 6.0-CURRENT #1: Wed Oct 20 12:08:24 EDT 2004 mteterin@mi:/meow/obj/misha/src/sys/Gigabyte i386


>Description:
	Should the 'file system preen fail' and the fsck_y_enable
	be set to "YES", the /etc/rc.d/fsck will try `fsck -y'. This
	means, that even the now clean filesystems will be re-checked,
	sometimes adding many minutes to the start-up time.

>How-To-Repeat:

>Fix:

Index: fsck
===================================================================
RCS file: /meow/ncvs/src/etc/rc.d/fsck,v
retrieving revision 1.10
diff -U2 -r1.10 fsck
--- src/etc/rc.d/fsck	7 Oct 2004 13:55:25 -0000	1.10
+++ src/etc/rc.d/fsck	22 Oct 2004 15:59:39 -0000
@@ -58,5 +58,5 @@
 			if checkyesno fsck_y_enable; then
 				echo "File system preen failed, trying fsck -y."
-				fsck -y
+				fsck -yp
 				case $? in
 				0)
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->brian 
Responsible-Changed-By: brian 
Responsible-Changed-When: Wed Jan 12 13:00:31 GMT 2005 
Responsible-Changed-Why:  
I'll look at this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73008 

From: Brian Somers <brian@Awfulhak.org>(by way of Brian Somers <brian@Awfulhak.org>)
To: Mikhail Teterin <mi@aldan.algebra.com>
Cc: freebsd-bugs@FreeBSD.org
Subject: Re: conf/73008: [patch] `fsck -y' tortures clean disks needlessly
Date: Wed, 12 Jan 2005 13:00:24 +0000

 Hi,
 
 I don't think it makes a lot of sense to make this change.  If the preen
 fails, it's likely because of unexpected inconsistencies, and not something
 that -py will fix.
 
 What do you think?
 
 -- 
 Brian Somers                                          <brian@Awfulhak.org>
 Don't _EVER_ lose your sense of humour !               <brian@FreeBSD.org>
 
State-Changed-From-To: open->feedback 
State-Changed-By: brian 
State-Changed-When: Wed Jan 12 14:28:21 GMT 2005 
State-Changed-Why:  
Awaiting feedback from the submitter 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73008 

From: Brian Somers <brian@Awfulhak.org>
To: Mikhail Teterin <mi@corbulon.video-collage.com>,
	freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: conf/73008: [patch] `fsck -y' tortures clean disks needlessly
Date: Wed, 12 Jan 2005 16:50:19 +0000

 On Wed, 12 Jan 2005 11:44:03 -0500 (EST), Mikhail Teterin <mi@corbulon.video-collage.com> wrote:
 > > Hi,
 > > 
 > > I don't think it makes a lot of sense to make this change.  If the preen
 > > fails, it's likely because of unexpected inconsistencies, and not something
 > > that -py will fix.
 > > 
 > > What do you think?
 > 
 > -p means -- only check the filesystems, which are not marked clean, right?
 > 
 > If the preen fails, it is, indeed, because of unexpected inconsistencies,
 > but what is the point of re-fscking the clean filesystems?
 > 
 > Unfortunately, after submitting the PR I realized, fsck no longer works
 > as expected: ``fsck -yp'' does NOT do the right thing (which, IMHO, should
 > be: "do whatever you have to do, with the non-clean filesystems").
 
 I think in reality fsck needs a ``ignore clean filesystems'' switch, but
 -p isn't that switch (-p says ``do a check on the assumption that there's
 no such thing as a software bug'' -- well, almost).
 
 Should this PR be closed 'till such a time as someone has the time to
 as the fsck switch?
 
 -- 
 Brian Somers                                          <brian@Awfulhak.org>
 Don't _EVER_ lose your sense of humour !               <brian@FreeBSD.org>
State-Changed-From-To: feedback->closed 
State-Changed-By: brian 
State-Changed-When: Thu Jan 27 17:24:36 GMT 2005 
State-Changed-Why:  
This PR isn't useful in its current form.  What's really needed is a switch 
to ignore clean filesystems that can be used with fsck -y . 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73008 
>Unformatted:
