From yar@stylish.chem.msu.su  Mon Oct  6 10:45:38 2003
Return-Path: <yar@stylish.chem.msu.su>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7F3EF16A4B3; Mon,  6 Oct 2003 10:45:38 -0700 (PDT)
Received: from stylish.chem.msu.su (stylish.chem.msu.su [158.250.32.111])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 179C443FE5; Mon,  6 Oct 2003 10:45:36 -0700 (PDT)
	(envelope-from yar@stylish.chem.msu.su)
Received: from stylish.chem.msu.su (localhost [127.0.0.1])
	by stylish.chem.msu.su (8.12.10/8.12.10) with ESMTP id h96HiUPP000985;
	Mon, 6 Oct 2003 21:44:30 +0400 (MSD)
	(envelope-from yar@stylish.chem.msu.su)
Received: (from yar@localhost)
	by stylish.chem.msu.su (8.12.10/8.12.10/Submit) id h96HiUwT000984;
	Mon, 6 Oct 2003 21:44:30 +0400 (MSD)
	(envelope-from yar)
Message-Id: <200310061744.h96HiUwT000984@stylish.chem.msu.su>
Date: Mon, 6 Oct 2003 21:44:30 +0400 (MSD)
From: Yar Tikhiy <yar@comp.chem.msu.su>
To: FreeBSD-gnats-submit@freebsd.org
Cc: mtm@freebsd.org
Subject: Exit status from /etc/rc.d/mountcritlocal is ignored
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         57659
>Category:       conf
>Synopsis:       Exit status from /etc/rc.d/mountcritlocal is ignored
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 06 10:50:21 PDT 2003
>Closed-Date:    Tue Dec 09 00:40:21 PST 2003
>Last-Modified:  Tue Dec 09 00:40:21 PST 2003
>Originator:     Yar Tikhiy
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
Moscow State University
>Environment:
System: FreeBSD stylish.chem.msu.su 5.1-CURRENT FreeBSD 5.1-CURRENT #0: Sun Oct 5 02:38:19 MSD 2003 yar@stylish.chem.msu.su:/usr/obj/usr/src/sys/STYLISH i386

>Description:
	System startup will continue despite /etc/rc.d/mountcritlocal
	has failed.

	This may be a manifestation of a more general problem in rcNG.

>How-To-Repeat:
	Try to boot with an unmountable FS in /etc/fstab, e.g.:

	/dev/nodev	/mnt	ufs	rw	0	0
							^ so fsck won't fail

>Fix:
>Release-Note:
>Audit-Trail:

From: Yar Tikhiy <yar@comp.chem.msu.su>
To: freebsd-gnats-submit@FreeBSD.org
Cc: mtm@FreeBSD.org
Subject: Re: conf/57659: Exit status from /etc/rc.d/mountcritlocal is ignored
Date: Tue, 7 Oct 2003 17:35:34 +0400

 As my further investigation has revealed, it's just a problem of
 /etc/rc.d/mountcritlocal.  It should stop startup on a mount failure,
 but won't actually.  I'd suggest applying the patch attached.  By
 the way, the script /etc/rc.d/mountcritremote seems to have the
 same problem.
 
 -- 
 Yar
 
 --- /usr/src/etc/rc.d/mountcritlocal	Mon Jun  2 19:45:55 2003
 +++ ./mountcritlocal	Tue Oct  7 16:44:28 2003
 @@ -43,6 +43,9 @@
  		*)
  			echo 'Mounting /etc/fstab filesystems failed,' \
  			    ' startup aborted'
 +			if [ "$autoboot" = yes ]; then
 +				kill -TERM $$
 +			fi
  			exit 1
  			;;
  		esac
Responsible-Changed-From-To: freebsd-bugs->dougb 
Responsible-Changed-By: kris 
Responsible-Changed-When: Fri Oct 17 17:45:51 PDT 2003 
Responsible-Changed-Why:  
Assign to rc.d maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57659 

From: Mike Makonnen <mtm@identd.net>
To: Yar Tikhiy <yar@comp.chem.msu.su>
Cc: freebsd-gnats-submit@FreeBSD.org, mtm@FreeBSD.org
Subject: Re: conf/57659: Exit status from /etc/rc.d/mountcritlocal is ignored
Date: Mon, 1 Dec 2003 14:53:32 +0300

 On Tue, Oct 07, 2003 at 05:35:34PM +0400, Yar Tikhiy wrote:
 > As my further investigation has revealed, it's just a problem of
 > /etc/rc.d/mountcritlocal.  It should stop startup on a mount failure,
 > but won't actually.  I'd suggest applying the patch attached.  By
 > the way, the script /etc/rc.d/mountcritremote seems to have the
 > same problem.
 > 
 > -- 
 > Yar
 > 
 > --- /usr/src/etc/rc.d/mountcritlocal	Mon Jun  2 19:45:55 2003
 > +++ ./mountcritlocal	Tue Oct  7 16:44:28 2003
 > @@ -43,6 +43,9 @@
 >  		*)
 >  			echo 'Mounting /etc/fstab filesystems failed,' \
 >  			    ' startup aborted'
 > +			if [ "$autoboot" = yes ]; then
 > +				kill -TERM $$
 > +			fi
 >  			exit 1
 >  			;;
 >  		esac
 
 Quite correct. I've requested permission from re to commit this and a similar
 patch.
 
 Cheers.
 -- 
 Mike Makonnen  | GPG-KEY: http://www.identd.net/~mtm/mtm.asc
 mtm@identd.net | Fingerprint: 00E8 61BC 0D75 7FFB E4D3  6BF1 B239 D010 3215 D418
 mtm@FreeBSD.Org| FreeBSD - Unleash the Daemon !
State-Changed-From-To: open->closed 
State-Changed-By: mtm 
State-Changed-When: Tue Dec 9 00:39:16 PST 2003 
State-Changed-Why:  
Fixed. 

Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57659 
>Unformatted:
