From dcrudy@wildfire.danielrudy.org  Sat Aug 23 23:04:34 2003
Return-Path: <dcrudy@wildfire.danielrudy.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BD45216A4BF
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 23 Aug 2003 23:04:34 -0700 (PDT)
Received: from wildfire.danielrudy.org (adsl-67-121-152-22.dsl.pltn13.pacbell.net [67.121.152.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2D75543FA3
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 23 Aug 2003 23:04:34 -0700 (PDT)
	(envelope-from dcrudy@wildfire.danielrudy.org)
Received: from wildfire.danielrudy.org (pszcds@localhost.danielrudy.org [127.0.0.1])
	by wildfire.danielrudy.org (8.12.8p1/8.12.8) with ESMTP id h7O64X9W062916
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 23 Aug 2003 23:04:33 -0700 (PDT)
	(envelope-from dcrudy@wildfire.danielrudy.org)
Received: (from root@localhost)
	by wildfire.danielrudy.org (8.12.8p1/8.12.8/Submit) id h7O64XUc062915;
	Sat, 23 Aug 2003 23:04:33 -0700 (PDT)
Message-Id: <200308240604.h7O64XUc062915@wildfire.danielrudy.org>
Date: Sat, 23 Aug 2003 23:04:33 -0700 (PDT)
From: System Administrator <root@wildfire.danielrudy.org>
Reply-To: Daniel Rudy <dcrudy@pacbell.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Change to /etc/rc.network & /etc/defaults/rc.conf
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         55916
>Category:       conf
>Synopsis:       [PATCH] ppp-user options
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mtm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 23 23:10:19 PDT 2003
>Closed-Date:    Tue Apr 10 14:16:55 GMT 2007
>Last-Modified:  Tue Apr 10 14:16:55 GMT 2007
>Originator:     System Administrator
>Release:        FreeBSD 4.8-RELEASE-p1 i386
>Organization:
None
>Environment:
System: FreeBSD wildfire.danielrudy.org 4.8-RELEASE-p1 FreeBSD 4.8-RELEASE-p1 #0: Mon Aug 4 03:09:35 PDT 2003 root@strata.danielrudy.org:/usr/obj/usr/src/sys/WILDFIRE i386

>Description:
In the /etc/rc.network file, there is no provision to add additional options to ppp startup such as unit #.  This code change to rc.network and an additional entry in /etc/defaults/rc.conf will resolve this.

>How-To-Repeat:

Change Request: No trouble to repeat.

>Fix:

Beginning on line 279 of file /etc/rc.network, add these lines:

case ${ppp_flags} in
  [Nn][Oo])
    ;;
  *)
    ppp_command="${ppp_command} ${ppp_flags}"
    ;;
esac

Beginning on line 108 of file /etc/defaults/rc.conf, add this line:

ppp_flags="NO"		# Additional flags to ppp.


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: dougb 
State-Changed-When: Wed Feb 22 02:17:44 UTC 2006 
State-Changed-Why:  

rc.network is long gone, is this still a problem for you? 


Responsible-Changed-From-To: freebsd-bugs->dougb 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Wed Feb 22 02:17:44 UTC 2006 
Responsible-Changed-Why:  

I'll handle the feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55916 

From: Daniel Rudy <dcrudy@pacbell.net>
To: bug-followup@FreeBSD.org,  dcrudy@pacbell.net
Cc:  
Subject: Re: conf/55916: Change to /etc/rc.network & /etc/defaults/rc.conf
Date: Fri, 14 Apr 2006 00:01:28 -0700

 Sorry for the long delay for the feedback.
 
 Yes, it is still an issue, but now with the new setup that was
 introduced in 5.0, the problem is now in /etc/rc.d/ppp-user where the
 following code should be added starting at line 34:
 
         # Additional option.  This checks for ppp flags.
         #
         case ${ppp_flags} in
         [Nn][Oo])
                 ;;
         *)
                 rc_flags="$rc_flags ${ppp_flags}"
                 ;;
         esac
 
 This is not a hot topic but every time I upgrade the OS to the next
 version, I have to add this code.
 
 -- 
 Daniel Rudy
State-Changed-From-To: feedback->open 
State-Changed-By: dougb 
State-Changed-When: Thu May 18 05:12:01 UTC 2006 
State-Changed-Why:  

Thank you for your feedback. I'm not able to address this 
change request in a timely manner, but hopefully someone 
on the list (who knows more about ppp than I do) will 
take an interest. 


Responsible-Changed-From-To: dougb->freebsd-rc 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Thu May 18 05:12:01 UTC 2006 
Responsible-Changed-Why:  

ENOTIME 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55916 

From: Mike Makonnen <mtm@FreeBSD.Org>
To: bug-followup@FreeBSD.org, dcrudy@pacbell.net
Cc:  
Subject: Re: conf/55916: [PATCH] ppp-user options
Date: Sat, 31 Mar 2007 12:59:40 +0300

 I'm not sure I understand. In rc.d there shouldn't be any need for you
 to include that piece of code. If you specify ppp_flags="....." in your
 /etc/rc.conf, the rc.subr(8) glue routines should "automagically" pick it
 up. Can you try an unmodified /etc/rc.d/ppp script and put your
 additional arguments in a ppp_flags variable in /etc/rc.conf, and report
 on the outcome please. Thanks.
 
 Cheers.
 -- 
 Mike Makonnen          | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc
 mmakonnen_at_gmail.com | AC7B 5672 2D11 F4D0 EBF8  5279 5359 2B82 7CD4 1F55
 mtm_at_FreeBSD.Org     | FreeBSD - http://www.freebsd.org
State-Changed-From-To: open->feedback 
State-Changed-By: mtm 
State-Changed-When: Sat Mar 31 12:26:23 UTC 2007 
State-Changed-Why:  
I'll look into this. Awaiting feedback from Originator. 


Responsible-Changed-From-To: freebsd-rc->mtm 
Responsible-Changed-By: mtm 
Responsible-Changed-When: Sat Mar 31 12:26:23 UTC 2007 
Responsible-Changed-Why:  
I'll look into this. Awaiting feedback from Originator. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55916 

From: Daniel Rudy <dcrudy@pacbell.net>
To: Mike Makonnen <mtm@FreeBSD.Org>
Cc: bug-followup@FreeBSD.org
Subject: Re: conf/55916: [PATCH] ppp-user options
Date: Tue, 10 Apr 2007 00:23:53 -0700

 At about the time of 3/31/2007 2:59 AM, Mike Makonnen stated the following:
 > I'm not sure I understand. In rc.d there shouldn't be any need for you
 > to include that piece of code. If you specify ppp_flags="....." in your
 > /etc/rc.conf, the rc.subr(8) glue routines should "automagically" pick it
 > up. Can you try an unmodified /etc/rc.d/ppp script and put your
 > additional arguments in a ppp_flags variable in /etc/rc.conf, and report
 > on the outcome please. Thanks.
 > 
 > Cheers.
 
 The code that I added was a hold-over from 4.x/5.x era.  I removed the
 code and it still incorporates ppp_flags into the startup.  The primary
 use of this is to force ppp to use a particular interface.  In this case
 tun0.  You may close the bug report.
 
 
 -- 
 Daniel Rudy
 
 Why geeks like computers: look chat date touch grep make unzip
 strip view finger mount fcsk more fcsk yes spray umount sleep
State-Changed-From-To: feedback->closed 
State-Changed-By: mtm 
State-Changed-When: Tue Apr 10 14:16:06 UTC 2007 
State-Changed-Why:  
Originator confirmed this issue is resolved. 
Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55916 
>Unformatted:
