From eugen@grosbein.pp.ru  Tue Dec 31 07:06:23 2002
Return-Path: <eugen@grosbein.pp.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3C2AB37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 31 Dec 2002 07:06:23 -0800 (PST)
Received: from grosbein.pp.ru (www2.svzserv.kemerovo.su [213.184.65.86])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 86D6B43ED1
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 31 Dec 2002 07:06:14 -0800 (PST)
	(envelope-from eugen@grosbein.pp.ru)
Received: from grosbein.pp.ru (smmsp@localhost [127.0.0.1])
	by grosbein.pp.ru (8.12.6/8.12.6) with ESMTP id gBVF6HdZ017532
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 31 Dec 2002 22:06:17 +0700 (KRAT)
	(envelope-from eugen@grosbein.pp.ru)
Received: (from eugen@localhost)
	by grosbein.pp.ru (8.12.6/8.12.6/Submit) id gBVF3wQC017485;
	Tue, 31 Dec 2002 22:03:58 +0700 (KRAT)
Message-Id: <200212311503.gBVF3wQC017485@grosbein.pp.ru>
Date: Tue, 31 Dec 2002 22:03:58 +0700 (KRAT)
From: Eugene Grosbein <eugen@grosbein.pp.ru>
Reply-To: Eugene Grosbein <eugen@grosbein.pp.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] /etc/defaults/pccard.conf uses -link0, -link1 for ep(4)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         46651
>Category:       conf
>Synopsis:       [PATCH] /etc/defaults/pccard.conf uses -link0, -link1 for ep(4)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    maxim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 31 07:10:03 PST 2002
>Closed-Date:    Wed Feb 12 00:06:53 PST 2003
>Last-Modified:  Wed Feb 12 00:06:53 PST 2003
>Originator:     Eugene Grosbein
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
Svyaz Service JSC
>Environment:
System: FreeBSD grosbein.pp.ru 4.7-STABLE FreeBSD 4.7-STABLE #0: Tue Dec 31 15:11:39 KRAT 2002 eu@grosbein.pp.ru:/usr/local/obj/usr/local/src/sys/DADV i386


>Description:
		device ep(4) does not use -link0, -link1 flags used
		by device nep(4) six years ago. However, they are
		still survive in /etc/defaults/pccard.conf since
		the revison 1.3, when nate said in a commit log:

Also,change the 3C589 examples to
reflect what I use to switch between the two connectors.

		Now it's harmless but it's potential rabbit trap,
		sometimes ep(4) may utilize link[0-2] flags.

>How-To-Repeat:
		N/A

>Fix:

		Patch  /etc/defaults/pccard.conf:

--- pccard.conf.orig	Tue Dec 31 22:01:33 2002
+++ pccard.conf	Tue Dec 31 22:02:52 2002
@@ -1104,14 +1104,13 @@
 # Don't think this will work.
 #card "3Com Corporation" "3C562"
 #	config	0x9 "ep" ?
-#	insert	/etc/pccard_ether $device start -link0 link1
+#	insert	/etc/pccard_ether $device start
 #	remove	/etc/pccard_ether $device stop
 
 # 3Com Etherlink III 3C589, 3C589B, 3C589C, 3C589D
 card "3Com Corporation" "/3C589/"
 	config	auto "ep" ?
-	insert	/etc/pccard_ether $device start -link0 link1
-#	insert	/etc/pccard_ether $device start link0 -link1
+	insert	/etc/pccard_ether $device start
 	remove	/etc/pccard_ether $device stop
 
 # Farallon EtherMac


Eugene Grosbein
>Release-Note:
>Audit-Trail:

From: Eugene Grosbein <eugen@grosbein.pp.ru>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/46651: [PATCH] /etc/defaults/pccard.conf uses -link0, -link1 
 for ep(4)
Date: Tue, 31 Dec 2002 22:37:21 +0700

 Small note: link[0-1] flags for ep(4) were removed 3 years ago by mdodd,
 see rev. 1.90 of if_ep.c
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Tue Feb 4 06:11:53 PST 2003 
State-Changed-Why:  
Fixed in rev. 1.257 src/etc/defaults/pccard.conf in -CURRENT. 


Responsible-Changed-From-To: freebsd-bugs->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Tue Feb 4 06:11:53 PST 2003 
Responsible-Changed-Why:  
Will MFC the fix in one week. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=46651 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Wed Feb 12 00:06:23 PST 2003 
State-Changed-Why:  
Fixed in -CURRENT and -STABLE, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=46651 
>Unformatted:
