From nobody@FreeBSD.org  Tue Apr 30 22:00:47 2002
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 462E437B400
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 30 Apr 2002 22:00:43 -0700 (PDT)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g4150hs68927;
	Tue, 30 Apr 2002 22:00:43 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200205010500.g4150hs68927@freefall.freebsd.org>
Date: Tue, 30 Apr 2002 22:00:43 -0700 (PDT)
From: Lumpy Lynx <lumpy@is.no.bs>
To: freebsd-gnats-submit@FreeBSD.org
Subject: etc/security calls diff -w, but i dont think it means to
X-Send-Pr-Version: www-1.0

>Number:         37618
>Category:       conf
>Synopsis:       etc/security calls diff -w, but i dont think it means to
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    cjc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 30 22:10:01 PDT 2002
>Closed-Date:    Mon May 13 23:39:37 PDT 2002
>Last-Modified:  Mon May 13 23:39:37 PDT 2002
>Originator:     Lumpy Lynx
>Release:        4.5-Stable
>Organization:
No BS Networks
>Environment:
cant get it right now
>Description:
            if ! cmp ${LOG}/setuid.today ${TMP} >/dev/null; then
              [ $rc -lt 1 ] && rc=1
              separator
              echo "${host} setuid diffs:"
              diff -w ${LOG}/setuid.today ${TMP}
              mv ${LOG}/setuid.today ${LOG}/setuid.yesterday || rc=3
              mv ${TMP} ${LOG}/setuid.today || rc=3
            fi
      
              if it does a diff -w, then wont it think that 
            "fi le" and "file" are the same?  doesnt that seem a little
             wrong?
>How-To-Repeat:
      less /etc/security
>Fix:

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->brian 
Responsible-Changed-By: johan 
Responsible-Changed-When: Thu May 2 18:08:41 PDT 2002 
Responsible-Changed-Why:  
Over to Brian who made that commit in rev 1.41 of 
/etc/security. 

Brian, what was the reason for this change? 

Note that this now is in etc/periodic/security/100.chksetuid 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37618 

From: Johan Karlsson <k@numeri.campus.luth.se>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Fwd: Re: conf/37618: etc/security calls diff -w, but i dont think it means to
Date: Sun, 5 May 2002 00:03:49 +0200

 Save in the PR.
 
 ----- Forwarded message from Brian Somers <brian@freebsd-services.com> -----
 
 From: Brian Somers <brian@freebsd-services.com>
 To: "Crist J. Clark" <cjc@FreeBSD.ORG>
 Cc: Brian Somers <brian@freebsd-services.com>, johan@FreeBSD.ORG,
    freebsd-bugs@FreeBSD.ORG, brian@FreeBSD.ORG
 Subject: Re: conf/37618: etc/security calls diff -w, but i dont think it means to 
 Date: Sat, 04 May 2002 21:28:10 +0100
 
 It's fine by me if you want to commit this.
 
 > It seems like this is the right way to make everyone happy.
 > 
 > Index: 100.chksetuid
 > ===================================================================
 > RCS file: /export/freebsd/ncvs/src/etc/periodic/security/100.chksetuid,v
 > retrieving revision 1.1
 > diff -u -r1.1 100.chksetuid
 > --- 100.chksetuid	7 Dec 2001 23:57:38 -0000	1.1
 > +++ 100.chksetuid	4 May 2002 19:56:13 -0000
 > @@ -52,7 +52,7 @@
 >  	    find $mount -xdev -type f \
 >  		    \( -perm -u+x -or -perm -g+x -or -perm -o+x \) \
 >  		    \( -perm -u+s -or -perm -g+s \) -print0
 > -	done | xargs -0 -n 20 ls -liTd | sort +10 > ${TMP}
 > +	done | xargs -0 -n 20 ls -liTd | sed 's/^ *//' | sort +10 > ${TMP}
 >  
 >  	if [ ! -f ${LOG}/setuid.today ]; then
 >  	    rc=1
 > @@ -64,7 +64,7 @@
 >  	then
 >  	    [ $rc -lt 1 ] && rc=1
 >  	    echo "${host} setuid diffs:"
 > -	    diff -w ${LOG}/setuid.today ${TMP}
 > +	    diff -b ${LOG}/setuid.today ${TMP}
 >  	    mv ${LOG}/setuid.today ${LOG}/setuid.yesterday || rc=3
 >  	    mv ${TMP} ${LOG}/setuid.today || rc=3
 >  	fi
 > 
 > -- 
 > Crist J. Clark                     |     cjclark@alum.mit.edu
 >                                    |     cjclark@jhu.edu
 > http://people.freebsd.org/~cjc/    |     cjc@freebsd.org
 
 -- 
 Brian <brian@freebsd-services.com>                <brian@Awfulhak.org>
       http://www.freebsd-services.com/        <brian@[uk.]FreeBSD.org>
 Don't _EVER_ lose your sense of humour !      <brian@[uk.]OpenBSD.org>
 
 
 ----- End forwarded message -----
 
 -- 
 Johan Karlsson		mailto:k@numeri.campus.luth.se
State-Changed-From-To: open->patched 
State-Changed-By: cjc 
State-Changed-When: Sat May 4 17:59:48 PDT 2002 
State-Changed-Why:  
Applied my fix mentioned in the audit trail to -CURRENT. Clean the 
whitespace from the front of the ls(1) output and revert to diff(1) 
with the -b option. 


Responsible-Changed-From-To: brian->cjc 
Responsible-Changed-By: cjc 
Responsible-Changed-When: Sat May 4 17:59:48 PDT 2002 
Responsible-Changed-Why:  
brian said he didn't mind if I patched it. I assume he doesn't mind if 
I now steal the PR. I'll handle MFC to -STABLE pending re@ approval 
(we're in freeze for 4.6). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37618 
State-Changed-From-To: patched->closed 
State-Changed-By: cjc 
State-Changed-When: Mon May 13 23:38:44 PDT 2002 
State-Changed-Why:  
MFC'ed to -STABLE (will be in 4.6-RELEASE). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37618 
>Unformatted:
