From andre.albsmeier@mchp.siemens.de  Sat Jan  5 06:40:53 2002
Return-Path: <andre.albsmeier@mchp.siemens.de>
Received: from goliath.siemens.de (goliath.siemens.de [194.138.37.131])
	by hub.freebsd.org (Postfix) with ESMTP id 1A35D37B419
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  5 Jan 2002 06:40:52 -0800 (PST)
Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11])
	by goliath.siemens.de (8.11.6/8.11.6) with ESMTP id g05Eenl00565
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 5 Jan 2002 15:40:50 +0100 (MET)
Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.42.7])
	by mail2.siemens.de (8.11.6/8.11.6) with ESMTP id g05Eeng21782
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 5 Jan 2002 15:40:49 +0100 (MET)
Received: (from localhost)
	by curry.mchp.siemens.de (8.11.6/8.11.6) id g05Een640642
	for FreeBSD-gnats-submit@freebsd.org; Sat, 5 Jan 2002 15:40:49 +0100 (CET)
Message-Id: <200201051440.g05EenU72574@curry.mchp.siemens.de>
Date: Sat, 5 Jan 2002 15:40:49 +0100 (CET)
From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] allow using of -C option during install of man pages
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         33575
>Category:       conf
>Synopsis:       [PATCH] allow using of -C option during install of man pages
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ru
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 05 06:50:01 PST 2002
>Closed-Date:    Tue Aug 20 01:52:28 PDT 2002
>Last-Modified:  Tue Aug 20 01:52:28 PDT 2002
>Originator:     Andre Albsmeier
>Release:        FreeBSD 4.5-PRERELEASE i386
>Organization:
>Environment:

All FreeBSD systems

>Description:

When using the man(1) command after a "make installworld", man pages
get formatted again even if they didn't change and the corresponding
cat page was available already.

>How-To-Repeat:

cd /usr/src/bin/ls && make install
man ls
cd /usr/src/bin/ls && make install
man ls

>Fix:

We could use the -C flag for installing manpages. The patches below
makes it possible to specify WANT_MAN_COMPARE in /etc/make.conf so
that man pages are installed using the -C option. If you don't put
WANT_MAN_COMPARE in /etc/make.conf the old behaviour is kept.

--- etc/defaults/make.conf.ORI	Fri Dec  7 17:48:13 2001
+++ etc/defaults/make.conf	Sat Jan  5 15:20:08 2002
@@ -141,6 +141,11 @@
 #
 #NOMANCOMPRESS=	true
 #
+# If you want manual pages to be installed only if they have changed
+# since the last install, uncomment the following.
+#
+#WANT_MAN_COMPARE=	true
+#
 #
 # If you want the "compat" shared libraries installed as part of your normal
 # builds, uncomment these:
--- share/mk/bsd.man.mk.ORI	Mon Dec 31 14:06:53 2001
+++ share/mk/bsd.man.mk	Sat Jan  5 15:25:04 2002
@@ -49,7 +49,11 @@
 #		Install the manual pages and their links.
 #
 
+.if defined(WANT_MAN_COMPARE)
+MINSTALL=	${INSTALL} -C -o ${MANOWN} -g ${MANGRP} -m ${MANMODE}
+.else
 MINSTALL=	${INSTALL} ${COPY} -o ${MANOWN} -g ${MANGRP} -m ${MANMODE}
+.endif
 
 CATDIR=		${MANDIR:H:S/$/\/cat/}
 CATEXT=		.cat



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->suspended 
State-Changed-By: ru 
State-Changed-When: Wed Jan 9 02:11:34 PST 2002 
State-Changed-Why:  
The catpaging feature of man(1) is going to be axed in the 
next couple of days. 


Responsible-Changed-From-To: freebsd-bugs->ru 
Responsible-Changed-By: ru 
Responsible-Changed-When: Wed Jan 9 02:11:34 PST 2002 
Responsible-Changed-Why:  
Reminder to close this PR afterwards. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33575 

From: Ruslan Ermilov <ru@FreeBSD.org>
To: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
Cc: freebsd-bugs@FreeBSD.org
Subject: Re: conf/33575: [PATCH] allow using of -C option during install of man pages
Date: Wed, 9 Jan 2002 12:25:33 +0200

 On Wed, Jan 09, 2002 at 11:15:29AM +0100, Andre Albsmeier wrote:
 > On Wed, 09-Jan-2002 at 02:14:02 -0800, ru@FreeBSD.org wrote:
 > > Synopsis: [PATCH] allow using of -C option during install of man pages
 > > 
 > > State-Changed-From-To: open->suspended
 > > State-Changed-By: ru
 > > State-Changed-When: Wed Jan 9 02:11:34 PST 2002
 > > State-Changed-Why: 
 > > The catpaging feature of man(1) is going to be axed in the
 > > next couple of days.
 > 
 > Oops, why this? Did I miss something?
 > 
 This feature of man(1) is insecure in many ways, catpages are
 optional, and there are good alternatives exist for creating
 catpages in a secure way during the `make world' (MANBUILDCAT)
 and on a periodic(8) basis (weekly_catman_enable).
 
 Please see PR bin/32791 for details.
 
 
 Cheers,
 -- 
 Ruslan Ermilov		Oracle Developer/DBA,
 ru@sunbay.com		Sunbay Software AG,
 ru@FreeBSD.org		FreeBSD committer,
 +380.652.512.251	Simferopol, Ukraine
 
 http://www.FreeBSD.org	The Power To Serve
 http://www.oracle.com	Enabling The Information Age
State-Changed-From-To: suspended->closed 
State-Changed-By: ru 
State-Changed-When: Tue Jan 15 06:48:56 PST 2002 
State-Changed-Why:  


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33575 
State-Changed-From-To: closed->open 
State-Changed-By: ru 
State-Changed-When: Tue Jan 15 07:16:42 PST 2002 
State-Changed-Why:  
Closed by mistake. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33575 
State-Changed-From-To: open->closed 
State-Changed-By: ru 
State-Changed-When: Tue Aug 20 01:49:07 PDT 2002 
State-Changed-Why:  
You can put INSTALL="install -C" to /etc/make.conf to get 
everything compared before installing, or you can override 
MINSTALL in /etc/make.conf if you want this for manpages 
only. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=33575 
>Unformatted:
