From jhs@freebsd.org  Sun Apr 13 08:56:17 1997
Received: from desk.jhs.no_domain (slip139-92-4-68.mu.de.ibm.net [139.92.4.68])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id IAA11185
          for <FreeBSD-gnats-submit@freebsd.org>; Sun, 13 Apr 1997 08:55:21 -0700 (PDT)
Received: (from jhs@localhost) by desk.jhs.no_domain (8.7.5/8.6.9) id RAA03932; Sun, 13 Apr 1997 17:51:01 +0200 (MET DST)
Message-Id: <199704131551.RAA03932@desk.jhs.no_domain>
Date: Sun, 13 Apr 1997 17:51:01 +0200 (MET DST)
From: jhs@freebsd.org
Reply-To: jhs@freebsd.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: src/sys/i386/conf/Makefile.i386 $@ is deprecated ? use ${.TARGET}
X-Send-Pr-Version: 3.2

>Number:         3272
>Category:       conf
>Synopsis:       $@ is deprecated I believe, so use ${.TARGET}
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    imp
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 13 09:00:02 PDT 1997
>Closed-Date:    Wed Sep 16 15:30:03 MDT 1998
>Last-Modified:  Wed Sep 16 15:30:25 MDT 1998
>Originator:     Julian Stacey jhs@freebsd.org
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
>Environment:

	All versions

>Description:

	$@ is deprecated I believe, so use ${.TARGET} in
	src/sys/i386/conf/Makefile.i386

>How-To-Repeat:

	-

>Fix:
	
	2 Patches appended.

Change from $@ to ${.TARGET}	as $@ is deprecated.

*** old/src/sys/i386/conf/Makefile.i386 Sun Jan 29 00:46:06 1995
--- new/src/sys/i386/conf/Makefile.i386	Sun Jan 29 00:50:38 1995
***************
*** 63,76 ****
  SYSTEM_SFILES= ${I386}/i386/locore.s
  SYSTEM_OBJS= locore.o vnode_if.o ${OBJS} ioconf.o param.o
  SYSTEM_DEP= Makefile symbols.exclude symbols.sort ${SYSTEM_OBJS}
! SYSTEM_LD_HEAD= @echo loading $@; rm -f $@
! SYSTEM_LD= @${LD} -Bstatic -Z -T ${LOAD_ADDRESS} -o $@ -X ${SYSTEM_OBJS} vers.o
  .if ${CFLAGS:M-g} == ""
  SYMORDER_EXCLUDE=-x symbols.exclude
  .endif
  SYSTEM_LD_TAIL= @echo rearranging symbols; \
! 	symorder -m ${SYMORDER_EXCLUDE} symbols.sort $@; \
! 	size $@; chmod 755 $@
  
  %BEFORE_DEPEND
  
--- 63,76 ----
  SYSTEM_SFILES= ${I386}/i386/locore.s
  SYSTEM_OBJS= locore.o vnode_if.o ${OBJS} ioconf.o param.o
  SYSTEM_DEP= Makefile symbols.exclude symbols.sort ${SYSTEM_OBJS}
! SYSTEM_LD_HEAD= @echo loading ${.TARGET}; rm -f ${.TARGET}
! SYSTEM_LD= @${LD} -Bstatic -Z -T ${LOAD_ADDRESS} -o ${.TARGET} -X ${SYSTEM_OBJS} vers.o
  .if ${CFLAGS:M-g} == ""
  SYMORDER_EXCLUDE=-x symbols.exclude
  .endif
  SYSTEM_LD_TAIL= @echo rearranging symbols; \
! 	symorder -m ${SYMORDER_EXCLUDE} symbols.sort ${.TARGET}; \
! 	size ${.TARGET}; chmod 755 ${.TARGET}
  
  %BEFORE_DEPEND
  
***************
*** 138,144 ****
  	${CC} -c ${CFLAGS} ${PARAM} -UKERNEL ${I386}/i386/genassym.c
  
  genassym: genassym.o
! 	${CC} ${CFLAGS} ${PARAM} genassym.o -o $@
  
  # XXX this assumes that the options for NORMAL_C* and DRIVER_C* are identical.
  depend: assym.s param.c vnode_if.h
--- 138,144 ----
  	${CC} -c ${CFLAGS} ${PARAM} -UKERNEL ${I386}/i386/genassym.c
  
  genassym: genassym.o
! 	${CC} ${CFLAGS} ${PARAM} genassym.o -o ${.TARGET}
  
  # XXX this assumes that the options for NORMAL_C* and DRIVER_C* are identical.
  depend: assym.s param.c vnode_if.h
*** old/src/sys/i386/conf/Makefile.i386 Sun Jan 29 00:46:06 1995
--- new/src/sys/i386/conf/Makefile.i386	Sun Jan 29 00:50:38 1995
***************
*** 63,76 ****
  SYSTEM_SFILES= ${I386}/i386/locore.s
  SYSTEM_OBJS= locore.o vnode_if.o ${OBJS} ioconf.o param.o
  SYSTEM_DEP= Makefile symbols.exclude symbols.sort ${SYSTEM_OBJS}
! SYSTEM_LD_HEAD= @echo loading $@; rm -f $@
! SYSTEM_LD= @${LD} -Bstatic -Z -T ${LOAD_ADDRESS} -o $@ -X ${SYSTEM_OBJS} vers.o
  .if ${CFLAGS:M-g} == ""
  SYMORDER_EXCLUDE=-x symbols.exclude
  .endif
  SYSTEM_LD_TAIL= @echo rearranging symbols; \
! 	symorder -m ${SYMORDER_EXCLUDE} symbols.sort $@; \
! 	size $@; chmod 755 $@
  
  %BEFORE_DEPEND
  
--- 63,76 ----
  SYSTEM_SFILES= ${I386}/i386/locore.s
  SYSTEM_OBJS= locore.o vnode_if.o ${OBJS} ioconf.o param.o
  SYSTEM_DEP= Makefile symbols.exclude symbols.sort ${SYSTEM_OBJS}
! SYSTEM_LD_HEAD= @echo loading ${.TARGET}; rm -f ${.TARGET}
! SYSTEM_LD= @${LD} -Bstatic -Z -T ${LOAD_ADDRESS} -o ${.TARGET} -X ${SYSTEM_OBJS} vers.o
  .if ${CFLAGS:M-g} == ""
  SYMORDER_EXCLUDE=-x symbols.exclude
  .endif
  SYSTEM_LD_TAIL= @echo rearranging symbols; \
! 	symorder -m ${SYMORDER_EXCLUDE} symbols.sort ${.TARGET}; \
! 	size ${.TARGET}; chmod 755 ${.TARGET}
  
  %BEFORE_DEPEND
  
***************
*** 138,144 ****
  	${CC} -c ${CFLAGS} ${PARAM} -UKERNEL ${I386}/i386/genassym.c
  
  genassym: genassym.o
! 	${CC} ${CFLAGS} ${PARAM} genassym.o -o $@
  
  # XXX this assumes that the options for NORMAL_C* and DRIVER_C* are identical.
  depend: assym.s param.c vnode_if.h
--- 138,144 ----
  	${CC} -c ${CFLAGS} ${PARAM} -UKERNEL ${I386}/i386/genassym.c
  
  genassym: genassym.o
! 	${CC} ${CFLAGS} ${PARAM} genassym.o -o ${.TARGET}
  
  # XXX this assumes that the options for NORMAL_C* and DRIVER_C* are identical.
  depend: assym.s param.c vnode_if.h


Julian
---
Julian H. Stacey	<jhs@freebsd.org>	http://www.freebsd.org/~jhs/
	`Music On Hold' phone systems disrupt concentration.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->suspended 
State-Changed-By: phk 
State-Changed-When: Sat Apr 11 14:14:28 PDT 1998 
State-Changed-Why:  
There are 137 makefiles in the system which uses $@.  If one were to 
change this, it should be done all over. 
Responsible-Changed-From-To: freebsd-bugs->imp 
Responsible-Changed-By: imp 
Responsible-Changed-When: Wed Apr 29 11:40:18 MDT 1998 
Responsible-Changed-Why:  
Cause I'm taking this over. 
. 
State-Changed-From-To: suspended->open 
State-Changed-By: imp 
State-Changed-When: Mon Sep 14 15:31:53 MDT 1998 
State-Changed-Why:  
Fixed 
State-Changed-From-To: open->closed 
State-Changed-By: imp 
State-Changed-When: Wed Sep 16 15:30:03 MDT 1998 
State-Changed-Why:  
I already fixed this. 
>Unformatted:
Julian H. Stacey	<jhs@freebsd.org>	http://www.freebsd.org/~jhs/
