From root@kabelfoon.nl  Thu Aug 16 00:08:02 2001
Return-Path: <root@kabelfoon.nl>
Received: from klingon.kabelfoon.nl (klingon.kabelfoon.nl [62.45.45.101])
	by hub.freebsd.org (Postfix) with ESMTP id BB06437B418
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 16 Aug 2001 00:08:01 -0700 (PDT)
	(envelope-from root@kabelfoon.nl)
Received: by klingon.kabelfoon.nl (Postfix, from userid 0)
	id 98CDB5D001; Thu, 16 Aug 2001 09:08:00 +0200 (CEST)
Message-Id: <20010816070800.98CDB5D001@klingon.kabelfoon.nl>
Date: Thu, 16 Aug 2001 09:08:00 +0200 (CEST)
From: Hans Hoppe <h.hoppe@kabelfoon.nl>
Sender: root@kabelfoon.nl
Reply-To: Hans Hoppe <h.hoppe@kabelfoon.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: sysinstall puts confusing message in /etc/rc.conf about 'this file'
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         29764
>Category:       conf
>Synopsis:       sysinstall puts confusing message in /etc/rc.conf about 'this file'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 16 00:10:01 PDT 2001
>Closed-Date:    Sun Aug 19 23:49:16 PDT 2001
>Last-Modified:  Sun Aug 19 23:51:16 PDT 2001
>Originator:     Hans Hoppe
>Release:        FreeBSD 4.3-STABLE i386
>Organization:
Kabelfoon BV
>Environment:
System: FreeBSD klingon.kabelfoon.intern 4.3-STABLE FreeBSD 4.3-STABLE #6: Wed Jul 4 16:46:54 CEST 2001 kdhn@klingon.kabelfoon.intern:/usr/src/sys/compile/LDAP i386


	
>Description:
/stand/sysinstall puts the following text in /etc/rc.conf:

# This file now contains just the overrides from /etc/defaults/rc.conf
# please make all changes to this file.

There could be confusion whether 'this file' on the second line refers to 
/etc/defaults/rc.conf or /etc/rc.conf.

>How-To-Repeat:
Let sysinstall generate a /etc/rc.conf
>Fix:
Suggested diff for config.c:

--- usr/src/release/sysinstall/config.c.orig	Wed Jul  4 08:56:37 2001
+++ usr/src/release/sysinstall/config.c	Thu Aug 16 08:49:25 2001
@@ -389,7 +389,7 @@
 	return;
     if (write_header) {
 	fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf\n");
-	fprintf(rcSite, "# please make all changes to this file.\n\n");
+	fprintf(rcSite, "# please make all changes to /etc/rc.conf.\n\n");
 	fprintf(rcSite, "# Enable network daemons for user convenience.\n");
 	if ((t_loc = time(NULL)) != -1 && (cp = ctime(&t_loc)))
 	    fprintf(rcSite, "# Created: %s", cp);
>Release-Note:
>Audit-Trail:

From: parv <parv@worldnet.att.net>
To: Hans Hoppe <h.hoppe@kabelfoon.nl>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: conf/29764: sysinstall puts confusing message in /etc/rc.conf about 'this file'
Date: Thu, 16 Aug 2001 03:33:59 -0400

 this was, on the fateful occasion around Aug 16 03:08 -0400,
 sent by Hans Hoppe                                                   
 >
 > 	
 ...
 > >Description:
 > /stand/sysinstall puts the following text in /etc/rc.conf:
 > 
 > # This file now contains just the overrides from /etc/defaults/rc.conf
 > # please make all changes to this file.
 > 
 > There could be confusion whether 'this file' on the second line refers to 
 > /etc/defaults/rc.conf or /etc/rc.conf.
 > 
 ...
 > >Fix:
 > Suggested diff for config.c:
 > 
 > --- usr/src/release/sysinstall/config.c.orig	Wed Jul  4 08:56:37 2001
 > +++ usr/src/release/sysinstall/config.c	Thu Aug 16 08:49:25 2001
 > @@ -389,7 +389,7 @@
 >  	return;
 >      if (write_header) {
 >  	fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf\n");
 > -	fprintf(rcSite, "# please make all changes to this file.\n\n");
 > +	fprintf(rcSite, "# please make all changes to /etc/rc.conf.\n\n");
 >  	fprintf(rcSite, "# Enable network daemons for user convenience.\n");
 >  	if ((t_loc = time(NULL)) != -1 && (cp = ctime(&t_loc)))
 >  	    fprintf(rcSite, "# Created: %s", cp);
 
 i think it will be better if "this" and "/etc/rc.conf" are 
 interchanged to print...
 
 # /etc/rc.conf file now contains just the overrides from 
 # /etc/defaults/rc.conf please make all changes to this file.
 
 ...here is the patch...
 
 --- src/release/sysinstall/config.c.old Thu Aug 16 03:28:19 2001
 +++ src/release/sysinstall/config.c     Thu Aug 16 03:29:49 2001
 @@ -388,8 +388,8 @@
      if (!rcSite)
         return;
      if (write_header) {
 -       fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf\n");
 -       fprintf(rcSite, "# please make all changes to this file.\n\n");
 +       fprintf(rcSite, "# /etc/rc.conf file now contains just the overrides from \n");
 +       fprintf(rcSite, "# /etc/defaults/rc.conf please make all changes to this file.\n\n");
         fprintf(rcSite, "# Enable network daemons for user convenience.\n");
         if ((t_loc = time(NULL)) != -1 && (cp = ctime(&t_loc)))
             fprintf(rcSite, "# Created: %s", cp);
 
 -- 
  so, do you like word games or scrabble?
 	 - parv

From: parv <parv_@yahoo.com>
To: Hans Hoppe <h.hoppe@kabelfoon.nl>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: conf/29764: sysinstall puts confusing message in /etc/rc.conf about 'this file'
Date: Thu, 16 Aug 2001 03:39:39 -0400

 here it is again w/ my correct email address.
 
 this was, on the fateful occasion around Aug 16 03:08 -0400,
 sent by Hans Hoppe                                                   
 >
 > 	
 ...
 > >Description:
 > /stand/sysinstall puts the following text in /etc/rc.conf:
 > 
 > # This file now contains just the overrides from /etc/defaults/rc.conf
 > # please make all changes to this file.
 > 
 > There could be confusion whether 'this file' on the second line refers to 
 > /etc/defaults/rc.conf or /etc/rc.conf.
 > 
 ...
 > >Fix:
 > Suggested diff for config.c:
 > 
 > --- usr/src/release/sysinstall/config.c.orig	Wed Jul  4 08:56:37 2001
 > +++ usr/src/release/sysinstall/config.c	Thu Aug 16 08:49:25 2001
 > @@ -389,7 +389,7 @@
 >  	return;
 >      if (write_header) {
 >  	fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf\n");
 > -	fprintf(rcSite, "# please make all changes to this file.\n\n");
 > +	fprintf(rcSite, "# please make all changes to /etc/rc.conf.\n\n");
 >  	fprintf(rcSite, "# Enable network daemons for user convenience.\n");
 >  	if ((t_loc = time(NULL)) != -1 && (cp = ctime(&t_loc)))
 >  	    fprintf(rcSite, "# Created: %s", cp);
 
 i think it will be better if "this" and "/etc/rc.conf" are 
 interchanged to print...
 
 # /etc/rc.conf file now contains just the overrides from 
 # /etc/defaults/rc.conf please make all changes to this file.
 
 ...here is the patch...
 
 --- src/release/sysinstall/config.c.old Thu Aug 16 03:28:19 2001
 +++ src/release/sysinstall/config.c     Thu Aug 16 03:29:49 2001
 @@ -388,8 +388,8 @@
      if (!rcSite)
         return;
      if (write_header) {
 -       fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf\n");
 -       fprintf(rcSite, "# please make all changes to this file.\n\n");
 +       fprintf(rcSite, "# /etc/rc.conf file now contains just the overrides from \n");
 +       fprintf(rcSite, "# /etc/defaults/rc.conf please make all changes to this file.\n\n");
         fprintf(rcSite, "# Enable network daemons for user convenience.\n");
         if ((t_loc = time(NULL)) != -1 && (cp = ctime(&t_loc)))
             fprintf(rcSite, "# Created: %s", cp);
 
 -- 
  so, do you like word games or scrabble?
 	 - parv

From: Hans Hoppe <h.hoppe@kabelfoon.nl>
To: parv <parv_@yahoo.com>
Cc: <FreeBSD-gnats-submit@freebsd.org>
Subject: Re: conf/29764: sysinstall puts confusing message in /etc/rc.conf
	about 'this file'
Date: Thu, 16 Aug 2001 12:53:32 +0200

 on 2001-08-16 09:39 parv <parv_@yahoo.com> wrote:
 
 > [...]
 > 
 > i think it will be better if "this" and "/etc/rc.conf" are
 > interchanged to print...
 > 
 > # /etc/rc.conf file now contains just the overrides from
 > # /etc/defaults/rc.conf please make all changes to this file.
 > 
 
 That depends on whether we're meant to make all changes to
 /etc/defaults/rc.conf or to /etc/rc.conf.
 I think we're supposed to leave /etc/defaults/rc.conf untouched
 and make changes to /etc/rc.conf.
 
 Greets,
       Hans
 --
 Kabelfoon BV          Phone: +31 174 615430
 PO Box 45             Fax:   +31 174 623860
 2670 AA  Naaldwijk    WWW:   http://www.kabelfoon.nl/
 Netherlands           Email: info@kabelfoon.nl
 
State-Changed-From-To: open->closed 
State-Changed-By: ru 
State-Changed-When: Sun Aug 19 23:49:16 PDT 2001 
State-Changed-Why:  
Duplicate of PR bin/29736. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=29764 
>Unformatted:
