From nobody@FreeBSD.org  Mon Jun 11 10:47:47 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 0663C37B407
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Jun 2001 10:47:47 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.3/8.11.3) id f5BHlku95940;
	Mon, 11 Jun 2001 10:47:46 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200106111747.f5BHlku95940@freefall.freebsd.org>
Date: Mon, 11 Jun 2001 10:47:46 -0700 (PDT)
From: cynic@mail.cz
To: freebsd-gnats-submit@FreeBSD.org
Subject: /stand/sysinstall skips distro selection after choosing "no" at final prompt
X-Send-Pr-Version: www-1.0

>Number:         28078
>Category:       conf
>Synopsis:       /stand/sysinstall skips distro selection after choosing "no" at final prompt
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-qa
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 11 10:50:00 PDT 2001
>Closed-Date:    Mon Jan 13 13:20:11 PST 2003
>Last-Modified:  Mon Jan 13 13:20:11 PST 2003
>Originator:     Roman Neuhauser
>Release:        4.3-RELEASE
>Organization:
>Environment:
FreeBSD freepuppy.local 4.3-RELEASE FreeBSD 4.3-RELEASE #2: Mon Jun 11 13:02:42 CEST 2001 toor@freepuppy.local:/usr/src/sys/compile/FREEPUPPY  i386
>Description:
(appended uname -a shows a custom kernel, but this happens with GENERIC, too)

"Standard install" -- when you choose "cancel" or "no" after the distro selection, /stand/sysinstall won't let you select a distro again.

>How-To-Repeat:
Take a 4.3-RELEASE CD, select "Standard Install", proceed all the way to the "Last chance" dialog, answer "no". Repeat the install. Distro selection is skipped.
>Fix:

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->analyzed 
State-Changed-By: murray 
State-Changed-When: Wed Sep 5 03:33:41 PDT 2001 
State-Changed-Why:  
A follow up has been sent.  The best solution is probably to ask the user somehow if they would like to reconfigure there distributions. 


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28078 

From: Murray Stokely <murray@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, cynic@mail.cz
Cc:  
Subject: Re: conf/28078: /stand/sysinstall skips distro selection after choosing "no" at final prompt
Date: Wed, 5 Sep 2001 03:38:03 -0700

   Hmm, this patch is a quick fix, but I'm not certain that this does
 the correct thing.  For which cases would you expect sysinstall to
 remember your dists and when do you want to start over with a clean
 plate?  It could be considered a feature that sysinstall remembers
 your dists for you when you cancel an install in progress.  Thoughts?
 
       - Murray
 
 Index: install.c
 ===================================================================
 RCS file: /home/ncvs/src/usr.sbin/sysinstall/install.c,v
 retrieving revision 1.305
 diff -u -r1.305 install.c
 --- install.c	2001/09/05 00:45:13	1.305
 +++ install.c	2001/09/05 10:24:07
 @@ -539,6 +539,14 @@
      if (DITEM_STATUS(diskLabelEditor(self)) == DITEM_FAILURE)
      return DITEM_FAILURE;
  
 +    /* During a standard interactive installation, we want to be
 +       prompted to make a selection of distfiles.  Without this, if we
 +       go partially through an install, and then abort, we can't
 +       reselect our distributions again. */
 +
 +    if (!variable_get(VAR_NONINTERACTIVE))
 +    distReset(NULL);	
 +
      if (DITEM_STATUS((i = installCommit(self))) == DITEM_FAILURE) {
      dialog_clear();
      msgConfirm("Installation completed with some errors.  You may wish to\n"
Responsible-Changed-From-To: freebsd-bugs->freebsd-qa 
Responsible-Changed-By: murray 
Responsible-Changed-When: Wed Mar 27 05:07:23 PST 2002 
Responsible-Changed-Why:  
Patch posted, thoughts? 


http://www.freebsd.org/cgi/query-pr.cgi?pr=28078 
State-Changed-From-To: analyzed->closed 
State-Changed-By: trhodes 
State-Changed-When: Mon Jan 13 13:19:29 PST 2003 
State-Changed-Why:  
I cannot reproduce this `bug'.  Closed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=28078 
>Unformatted:
