From ust@cert.siemens.de  Sat May  5 00:09:21 2001
Return-Path: <ust@cert.siemens.de>
Received: from goliath.siemens.de (goliath.siemens.de [194.138.37.131])
	by hub.freebsd.org (Postfix) with ESMTP id 4829F37B422
	for <FreeBSD-gnats-submit@freebsd.org>; Sat,  5 May 2001 00:09:20 -0700 (PDT)
	(envelope-from ust@cert.siemens.de)
Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14])
	by goliath.siemens.de (8.11.1/8.11.1) with ESMTP id f4579I417062
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 5 May 2001 09:09:18 +0200 (MET DST)
Received: from mars.cert.siemens.de (ust.mchp.siemens.de [139.23.201.17])
	by mail1.siemens.de (8.11.0/8.11.0) with ESMTP id f4579Hd15479
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 5 May 2001 09:09:17 +0200 (MET DST)
Received: from alaska.cert.siemens.de (reims.mchp.siemens.de [139.23.202.134])
	by mars.cert.siemens.de (8.11.3/8.11.3/Siemens CERT [ $Revision: 1.10 ]) with ESMTP id f4579HG26411
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 5 May 2001 09:09:17 +0200 (CEST)
	(envelope-from ust@alaska.cert.siemens.de)
Received: (from ust@localhost)
	by alaska.cert.siemens.de (8.11.3/8.11.3/alaska [ $Revision: 1.5 ]) id f4579Hm21424;
	Sat, 5 May 2001 07:09:17 GMT
Message-Id: <200105050709.f4579Hm21424@alaska.cert.siemens.de>
Date: Sat, 5 May 2001 07:09:17 GMT
From: Udo Schweigert <ust@cert.siemens.de>
Reply-To: ust@cert.siemens.de
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Missing include in /usr/include/sys/conf.h
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         27089
>Category:       conf
>Synopsis:       Missing include in /usr/include/sys/conf.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 05 00:10:01 PDT 2001
>Closed-Date:    Wed May 23 13:05:09 PDT 2001
>Last-Modified:  Wed May 23 13:05:44 PDT 2001
>Originator:     Udo Schweigert
>Release:        FreeBSD 5.0-CURRENT
>Organization:
>Environment:
FreeBSD keylargo.home 5.0-CURRENT FreeBSD 5.0-CURRENT #2: Wed May  2 09:13:26 CEST 2001     ust@keylargo.home:/usr/obj/usr/src/sys/keylargo  i386
>Description:
/usr/include/sys/conf.h references struct timespec which is defined in
/usr/include/sys/time.h. Since /usr/include/sys/time.h is not included by
/usr/include/sys/conf.h this results in an error (for example when trying
to build the sysutils/xosview port).
>How-To-Repeat:
Try to build port sysutils/xosview
>Fix:
--- /usr/src/sys/sys/conf.h	Wed May  2 08:06:29 2001
+++ /usr/include/sys/conf.h	Sat May  5 08:57:55 2001
@@ -45,6 +45,7 @@
 #define	_SYS_CONF_H_
 
 #include <sys/eventhandler.h>
+#include <sys/time.h>
 
 struct tty;
 struct disk;
>Release-Note:
>Audit-Trail:

From: Kris Kennaway <kris@obsecurity.org>
To: Udo Schweigert <ust@cert.siemens.de>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: conf/27089: Missing include in /usr/include/sys/conf.h
Date: Sat, 5 May 2001 22:32:07 -0700

 --b5gNqxB1S1yM7hjW
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Sat, May 05, 2001 at 07:09:17AM +0000, Udo Schweigert wrote:
 
 > /usr/include/sys/conf.h references struct timespec which is defined in
 > /usr/include/sys/time.h. Since /usr/include/sys/time.h is not included by
 > /usr/include/sys/conf.h this results in an error (for example when trying
 > to build the sysutils/xosview port).
 
 >  #include <sys/eventhandler.h>
 > +#include <sys/time.h>
 
 This is probably the wrong thing to do..the correct thing is to fix
 the broken software which makes that assumption.
 
 Kris
 
 --b5gNqxB1S1yM7hjW
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.5 (FreeBSD)
 Comment: For info see http://www.gnupg.org
 
 iD8DBQE69OHXWry0BWjoQKURAodKAJ95amUnPB4/aY+ZftHLg67xuM19oQCfSWTC
 xpEoQbmwjqy81xENtuIBoGY=
 =C/to
 -----END PGP SIGNATURE-----
 
 --b5gNqxB1S1yM7hjW--

From: Bruce Evans <bde@zeta.org.au>
To: Kris Kennaway <kris@obsecurity.org>
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: conf/27089: Missing include in /usr/include/sys/conf.h
Date: Sun, 6 May 2001 20:01:03 +1000 (EST)

 On Sat, 5 May 2001, Kris Kennaway wrote:
 
 >  On Sat, May 05, 2001 at 07:09:17AM +0000, Udo Schweigert wrote:
 >  
 >  > /usr/include/sys/conf.h references struct timespec which is defined in
 >  > /usr/include/sys/time.h. Since /usr/include/sys/time.h is not included by
 >  > /usr/include/sys/conf.h this results in an error (for example when trying
 >  > to build the sysutils/xosview port).
 >  
 >  >  #include <sys/eventhandler.h>
 >  > +#include <sys/time.h>
 >  
 >  This is probably the wrong thing to do..the correct thing is to fix
 >  the broken software which makes that assumption.
 
 It's not clear if the broken software is <sys/conf.h> or xosview.  A
 few applications in /usr/src include <sys/conf.h>.  At least fstat/fstat.c
 sort of needs to, since it wants convert kernel dev_t's to userland
 dev_t's.  Kernel dev_t's are now pointers, and <sys/conf.h> is the
 only place that declares the struct that they point to.  OTOH,
 top/machine.c includes <sys/conf.h> for no reason.
 
 Bruce
 
State-Changed-From-To: open->closed 
State-Changed-By: phk 
State-Changed-When: Wed May 23 13:05:09 PDT 2001 
State-Changed-Why:  
The mistake is entirely with xosview, <sys/conf.h> should have no 
user-servicable parts inside. 


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27089 
>Unformatted:
