From nobody@FreeBSD.org  Sat Dec 23 10:33:05 2000
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 73FEF37B402
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 23 Dec 2000 10:33:05 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id eBNIX5F80009;
	Sat, 23 Dec 2000 10:33:05 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200012231833.eBNIX5F80009@freefall.freebsd.org>
Date: Sat, 23 Dec 2000 10:33:05 -0800 (PST)
From: npapke@acm.org
Sender: nobody@FreeBSD.org
To: freebsd-gnats-submit@FreeBSD.org
Subject: periodic/daily/100.clean-disks doesn't remove files
X-Send-Pr-Version: www-1.0

>Number:         23805
>Category:       conf
>Synopsis:       periodic/daily/100.clean-disks doesn't remove files
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brian
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 23 10:40:01 PST 2000
>Closed-Date:    Tue Feb 20 14:33:29 PST 2001
>Last-Modified:  Tue Feb 20 14:37:14 PST 2001
>Originator:     Norbert Papke
>Release:        4.2-Stable
>Organization:
>Environment:
FreeBSD localhost.telus.net 4.2-STABLE FreeBSD 4.2-STABLE #0: Sun Dec 17 16:25:31 PST 2000     npapke@localhost.telus.net:/usr/obj/usr/src/sys/NGP  i386
>Description:
The periodic clean-disk script doesn't correctly find the files
to be automatically deleted.  The script incorrectly ANDs the
file patterns when they should be ORed.
>How-To-Repeat:
Enable periodic clean-disk with more than one file pattern.
>Fix:
When generating the $args file pattern, ensure that -o is inserted
between arguments.  Email me for diffs, if required.

>Release-Note:
>Audit-Trail:

From: Norbert Papke <npapke@telus.net>
To: freebsd-gnats-submit@FreeBSD.org, npapke@acm.org
Cc:  
Subject: Re: conf/23805: periodic/daily/100.clean-disks doesn't remove files
Date: Sat, 23 Dec 2000 16:12:24 -0800

 Should have included the diffs in the PR:
 
 --- /usr/src/etc/periodic/daily/100.clean-disks Tue Sep 26 18:39:56 2000
 
 +++ /etc/periodic/daily/100.clean-disks Sat Dec 23 16:08:55 2000
 @@ -27,10 +27,12 @@
             rc=2
         else
             echo ""
 -           echo "Removing old temporary files:"
 +           echo "Cleaning disk:"
             set -f noglob
             args="$args "`echo " ${daily_clean_disks_files% }" |
 -               sed 's/[        ][      ]*/ -name /g'`
 +               sed 's/[        ][      ]*/ -o -name /g'`
 +           args=`echo " $args" |
 +               sed 's/-o//`
 
             case "$daily_clean_tmps_verbose" in
                 [Yy][Ee][Ss])
 
 
 
State-Changed-From-To: open->feedback 
State-Changed-By: brian 
State-Changed-When: Sat Dec 23 19:22:56 PST 2000 
State-Changed-Why:  
Fixed in -current, I'll MFC in two weeks given no problems. 


Responsible-Changed-From-To: freebsd-bugs->brian 
Responsible-Changed-By: brian 
Responsible-Changed-When: Sat Dec 23 19:22:56 PST 2000 
Responsible-Changed-Why:  
The periodic stuff is mostly my fault. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23805 
State-Changed-From-To: feedback->closed 
State-Changed-By: brian 
State-Changed-When: Tue Feb 20 14:33:29 PST 2001 
State-Changed-Why:  
MFC'd on Jan 7 (oops - I forgot to close the pr!) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23805 
>Unformatted:
