From hmo@sep.hamburg.com  Mon Nov 20 09:22:58 2000
Return-Path: <hmo@sep.hamburg.com>
Received: from sep.hamburg.com (sep.hamburg.com [194.64.112.14])
	by hub.freebsd.org (Postfix) with ESMTP id BFF5337B479
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 20 Nov 2000 09:22:56 -0800 (PST)
Received: (from hmo@localhost)
	by sep.hamburg.com (8.11.1/8.11.1/hmo03sep00) id eAKHMoc51471;
	Mon, 20 Nov 2000 18:22:51 +0100 (CET)
	(envelope-from hmo)
Message-Id: <200011201722.eAKHMoc51471@sep.hamburg.com>
Date: Mon, 20 Nov 2000 18:22:51 +0100 (CET)
From: FreeBSD-gnats-submit@oldach.net
Sender: hmo@sep.hamburg.com
Reply-To: FreeBSD-gnats-submit@oldach.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: newvers.sh should retain SNAPDATE from environment
X-Send-Pr-Version: 3.2

>Number:         22979
>Category:       conf
>Synopsis:       sys/conf/newvers.sh erases SNAPDATE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jkh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 20 09:30:00 PST 2000
>Closed-Date:    Fri Dec 15 14:26:58 PST 2000
>Last-Modified:  Fri Dec 15 14:27:19 PST 2000
>Originator:     Helge Oldach
>Release:        FreeBSD 4.2-BETA i386
>Organization:
>Environment:


>Description:

	sys/conf/newvers.sh uses the SNAPDATE variable to amend the
	RELEASE tag of a kernel. For custom kernels SNAPDATE could
	be used to add private tags (e.g. CTM delta number, or date)
	to the kernel tag. Unfortunately newvers.sh zeroes out
	SNAPDATE before applying it to RELEASE, rendering it useless.

>How-To-Repeat:


>Fix:

--- /usr/src/sys/conf/newvers.sh	Tue Oct 31 20:34:15 2000
+++ /tmp/q/newvers.sh	Mon Nov 20 18:19:36 2000
@@ -38,7 +38,6 @@
 REVISION="4.2"
 BRANCH="BETA"
 RELEASE="${REVISION}-${BRANCH}"
-SNAPDATE=""
 if [ "X${SNAPDATE}" != "X" ]; then
 	RELEASE="${RELEASE}-${SNAPDATE}"
 fi
 
 

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jkh 
Responsible-Changed-By: johan 
Responsible-Changed-When: Fri Dec 15 13:51:46 PST 2000 
Responsible-Changed-Why:  
Let our release engineer have a look at this. 
However, I belive one is supposed to set these 
variables in the script. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=22979 
State-Changed-From-To: open->closed 
State-Changed-By: jkh 
State-Changed-When: Fri Dec 15 14:26:58 PST 2000 
State-Changed-Why:  
Your right, this is obsolete and was never officially used for 
anything anyway.  Removed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=22979 
>Unformatted:
