From ggm@twerp.rand.apnic.net  Mon May  5 05:20:13 2014
Return-Path: <ggm@twerp.rand.apnic.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 3D2B3B05
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 May 2014 05:20:13 +0000 (UTC)
Received: from twerp.rand.apnic.net (unknown [IPv6:2401:2000:6660::15])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id C06E41FC4
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 May 2014 05:20:11 +0000 (UTC)
Received: from twerp.rand.apnic.net (localhost [127.0.0.1])
	by twerp.rand.apnic.net (8.14.5/8.14.5) with ESMTP id s455K72A099061;
	Mon, 5 May 2014 05:20:07 GMT
	(envelope-from ggm@twerp.rand.apnic.net)
Received: (from root@localhost)
	by twerp.rand.apnic.net (8.14.7/8.14.7/Submit) id s455K7m7099060;
	Mon, 5 May 2014 05:20:07 GMT
	(envelope-from ggm)
Message-Id: <201405050520.s455K7m7099060@twerp.rand.apnic.net>
Date: Mon, 5 May 2014 05:20:07 GMT
From: George Michaelson <ggm@apnic.net>
Reply-To: ggm@apnic.net
To: FreeBSD-gnats-submit@freebsd.org
Cc: ggm@apnic.net
Subject: freebsd-update on FreeBSD10-release left set_rcvar lines in /etc/rc.d 
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         189366
>Category:       conf
>Synopsis:       freebsd-update on FreeBSD10-release left set_rcvar lines in /etc/rc.d
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 05 05:30:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     George Michaelson
>Release:        FreeBSD 10.0-RELEASE amd64
>Organization:
APNIC 
>Environment:
System: FreeBSD twerp.rand.apnic.net 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64

	
>Description:
	I run freebsd-update and get told its being upgraded from 10.0-release to -p2.
	After it runs, the machine fails to boot, stops single user, because almost all of /etc/rc.d has got set_rcvar lines in the files.
	However the set_rcvar function has been removed.

	Worryingly, when I diff -r on a -p2 system, I find that for many of these files the ONLY CHANGE is the textual replacement of
	the "`set_rcvar`" call by the "foo_enable" string: not the version/date/RCS stamp, just an in-place replacement.

	Somebody hasn't actually checked in tha change properly at some stage and instead has updated the FreeBSD-update information in a way
	which doesn't correctly replace the files.

	
>How-To-Repeat:
	You'd need to do a replace/install/upgrade on a 9.x series to 10.0 release and then run freebsd-update

	
>Fix:

	I have NFI because FreeBSD-update doesn't seem to want to 'replace' these files. I am copying rc.d and other stuff on from other hosts
	I have.
	


>Release-Note:
>Audit-Trail:
>Unformatted:
