From mellon@happy.checkpoint.com  Thu May 11 06:04:24 2000
Return-Path: <mellon@happy.checkpoint.com>
Received: from happy.checkpoint.com (happy.checkpoint.com [199.203.156.41])
	by hub.freebsd.org (Postfix) with ESMTP id 6A33D37B8F9
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 May 2000 06:04:15 -0700 (PDT)
	(envelope-from mellon@happy.checkpoint.com)
Received: (from mellon@localhost)
	by happy.checkpoint.com (8.9.3/8.9.3) id QAA01569;
	Thu, 11 May 2000 16:04:57 GMT
	(envelope-from mellon)
Message-Id: <200005111604.QAA01569@happy.checkpoint.com>
Date: Thu, 11 May 2000 16:04:57 GMT
From: mellon@pobox.com
Sender: mellon@happy.checkpoint.com
Reply-To: mellon@pobox.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: allowing ELF_VERBOSE in /etc/make.conf
X-Send-Pr-Version: 3.2

>Number:         18498
>Category:       conf
>Synopsis:       [boot] [patch] allowing ELF_VERBOSE in /etc/make.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jhb
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 11 06:10:00 PDT 2000
>Closed-Date:    
>Last-Modified:  Mon May 05 03:16:19 UTC 2014
>Originator:     Anatoly Vorobey
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:

5.0-CURRENT

>Description:

For debugging the loader, the following trivial change to
src/sys/boot/common/Makefile.inc will allow placing ELF_VERBOSE=true
in /etc/make.conf instead of having to change the makefile; this
makes life a little bit brighter and is exactly the arrangement
already existing with BTXLDR_VERBOSE in sys/boot/i386/btx/btxldr/Makefile,
for instance.

>How-To-Repeat:



>Fix:

Index: Makefile.inc
===================================================================
RCS file: /freebsd/cvs/src/sys/boot/common/Makefile.inc,v
retrieving revision 1.9
diff -u -r1.9 Makefile.inc
--- Makefile.inc	1999/08/28 00:39:44	1.9
+++ Makefile.inc	2000/05/11 15:53:43
@@ -16,3 +16,9 @@
 .if BOOT_FORTH
 SRCS+=	interp_forth.c
 .endif
+
+.if defined(ELF_VERBOSE)
+CFLAGS+=-DELF_VERBOSE
+.endif
+
+


>Release-Note:
>Audit-Trail:

From: Jeroen Ruigrok/Asmodai <asmodai@wxs.nl>
To: mellon@pobox.com
Cc: FreeBSD-gnats-submit@freebsd.org, jhb@freebsd.org
Subject: Re: bin/18498: allowing ELF_VERBOSE in /etc/make.conf
Date: Sat, 13 May 2000 13:48:11 +0200

 >Index: Makefile.inc
 >===================================================================
 >RCS file: /freebsd/cvs/src/sys/boot/common/Makefile.inc,v
 >retrieving revision 1.9
 >diff -u -r1.9 Makefile.inc
 >--- Makefile.inc	1999/08/28 00:39:44	1.9
 >+++ Makefile.inc	2000/05/11 15:53:43
 >@@ -16,3 +16,9 @@
 > .if BOOT_FORTH
 > SRCS+=	interp_forth.c
 > .endif
 >+
 >+.if defined(ELF_VERBOSE)
 >+CFLAGS+=-DELF_VERBOSE
 >+.endif
 >+
 >+
 
 Why those two trailing newlines?
 
 Anyways, John, what do you think of this change?
 
 I think it would make debugging easier for those who want it, however
 the ELF_VERBOSE name is a tad bit generic to make it a make.conf
 variable.  I prefer it to be ELF_BOOT_VERBOSE or something like that.
 Or ELF_BOOT_DEBUG.
 
 Just my interpretation to get this integrated.
 
 -- 
 Jeroen Ruigrok vd Werven/Asmodai    asmodai@[wxs.nl|bart.nl|freebsd.org]
 Documentation nutter/C-rated Coder BSD: Technical excellence at its best  
 The BSD Programmer's Documentation Project <http://home.wxs.nl/~asmodai>
 Sleep tonight, sweet summer light, scattered yesterdays, the past is far
  away...
 

From: John Baldwin <jhb@FreeBSD.org>
To: Jeroen Ruigrok/Asmodai <asmodai@wxs.nl>
Cc: FreeBSD-gnats-submit@FreeBSD.org, mellon@pobox.com
Subject: Re: bin/18498: allowing ELF_VERBOSE in /etc/make.conf
Date: Sat, 13 May 2000 08:00:03 -0400 (EDT)

 On 13-May-00 Jeroen Ruigrok/Asmodai wrote:
 > Why those two trailing newlines?
 
 They don't have to be in the final commit. :)
 
 > Anyways, John, what do you think of this change?
 > 
 > I think it would make debugging easier for those who want it, however
 > the ELF_VERBOSE name is a tad bit generic to make it a make.conf
 > variable.  I prefer it to be ELF_BOOT_VERBOSE or something like that.
 > Or ELF_BOOT_DEBUG.
 
 Probably BOOT_ELF_{DEBUG,VERBOSE} and with some tweaks we could
 make it so that all boot variables start with BOOT_, that way
 we can avoid nameclashes, and indicate that it is a variable
 that applies only to BOOT related stuff.
 
 -- 
 
 John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
 PGP Key: http://www.cslab.vt.edu/~jobaldwi/pgpkey.asc
 "Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
 

From: Jeroen Ruigrok/Asmodai <asmodai@wxs.nl>
To: John Baldwin <jhb@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org, mellon@pobox.com
Subject: Re: bin/18498: allowing ELF_VERBOSE in /etc/make.conf
Date: Sat, 13 May 2000 14:14:24 +0200

 -On [20000513 14:11], John Baldwin (jhb@FreeBSD.org) wrote:
 
 [snip]
 
 >> Why those two trailing newlines?
 >
 >They don't have to be in the final commit. :)
 
 Of course, just trying to make sure what the originator's intent was. ;)
 
 >Probably BOOT_ELF_{DEBUG,VERBOSE} and with some tweaks we could
 >make it so that all boot variables start with BOOT_, that way
 >we can avoid nameclashes, and indicate that it is a variable
 >that applies only to BOOT related stuff.
 
 I agree, that makes more sense than my suggestions.
 
 However, you can thus agree in principle with the patch [basically the
 moving of the make variable to make.conf]?
 
 Will you assign the pr to yourself and deal with it as you see fit? ;)
 
 -- 
 Jeroen Ruigrok vd Werven/Asmodai    asmodai@[wxs.nl|bart.nl|freebsd.org]
 Documentation nutter/C-rated Coder BSD: Technical excellence at its best  
 The BSD Programmer's Documentation Project <http://home.wxs.nl/~asmodai>
 I know you have tried, to feel...
 

From: Anatoly Vorobey <mellon@pobox.com>
To: Jeroen Ruigrok/Asmodai <asmodai@wxs.nl>
Cc: John Baldwin <jhb@FreeBSD.org>, FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: bin/18498: allowing ELF_VERBOSE in /etc/make.conf
Date: Sat, 13 May 2000 16:49:50 +0300

 You, Jeroen Ruigrok/Asmodai, were spotted writing this on Sat, May 13, 2000 at 02:14:24PM +0200:
 > Of course, just trying to make sure what the originator's intent was. ;)
 
 They were a part of the evil plan to bloat FreeBSD CVS repository
 out of all rational bounds by overwhelming it with carefully placed
 newlines. But now that this attempt has been foiled, I shall have
 to find some new ways of doing that ;)
 
 > >Probably BOOT_ELF_{DEBUG,VERBOSE} and with some tweaks we could
 > >make it so that all boot variables start with BOOT_, that way
 > >we can avoid nameclashes, and indicate that it is a variable
 > >that applies only to BOOT related stuff.
 
 Great idea. Then if you do this with ELF_VERBOSE, please take care
 to treat BTXLDR_VERBOSE similarly, it's in sys/boot/i386/btx/btxldr/Makefile .
 
 -- 
 Anatoly Vorobey,
 mellon@pobox.com http://pobox.com/~mellon/
 "Angels can fly because they take themselves lightly" - G.K.Chesterton
 
Responsible-Changed-From-To: freebsd-bugs->jhb 
Responsible-Changed-By: jhb 
Responsible-Changed-When: Sat May 13 07:00:01 PDT 2000 
Responsible-Changed-Why:  
I'll take this one. 

From: John Baldwin <jhb@FreeBSD.org>
To: Jeroen Ruigrok/Asmodai <asmodai@wxs.nl>
Cc: mellon@pobox.com, FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: bin/18498: allowing ELF_VERBOSE in /etc/make.conf
Date: Sat, 13 May 2000 10:01:57 -0400 (EDT)

 On 13-May-00 Jeroen Ruigrok/Asmodai wrote:
 > I agree, that makes more sense than my suggestions.
 > 
 > However, you can thus agree in principle with the patch [basically the
 > moving of the make variable to make.conf]?
 
 Yeah.
 
 > Will you assign the pr to yourself and deal with it as you see fit? ;)
 
 I've taken it.  Note that due to graduation and moving back home and stuff
 I may not get to this for a week or two, but I will get to it
 eventually. :)
 
 > -- 
 > Jeroen Ruigrok vd Werven/Asmodai    asmodai@[wxs.nl|bart.nl|freebsd.org]
 > Documentation nutter/C-rated Coder BSD: Technical excellence at its best  
 > The BSD Programmer's Documentation Project <http://home.wxs.nl/~asmodai>
 > I know you have tried, to feel...
 
 -- 
 
 John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
 PGP Key: http://www.cslab.vt.edu/~jobaldwi/pgpkey.asc
 "Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
 

From: John Baldwin <jhb@FreeBSD.org>
To: Anatoly Vorobey <mellon@pobox.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org,
	Jeroen Ruigrok/Asmodai <asmodai@wxs.nl>
Subject: Re: bin/18498: allowing ELF_VERBOSE in /etc/make.conf
Date: Sat, 13 May 2000 15:27:36 -0400 (EDT)

 On 13-May-00 Anatoly Vorobey wrote:
 > Great idea. Then if you do this with ELF_VERBOSE, please take care
 > to treat BTXLDR_VERBOSE similarly, it's in sys/boot/i386/btx/btxldr/Makefile .
 
 That is my intention, along with all the other BTX variables, etc.
 
 > Anatoly Vorobey,
 
 -- 
 
 John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
 PGP Key: http://www.cslab.vt.edu/~jobaldwi/pgpkey.asc
 "Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
 
>Unformatted:
