From nobody@FreeBSD.org  Tue Apr 23 03:07:14 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id A443A2A6
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Apr 2013 03:07:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 7BABE1529
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Apr 2013 03:07:14 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r3N37E7M069902
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Apr 2013 03:07:14 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r3N37EfH069901;
	Tue, 23 Apr 2013 03:07:14 GMT
	(envelope-from nobody)
Message-Id: <201304230307.r3N37EfH069901@red.freebsd.org>
Date: Tue, 23 Apr 2013 03:07:14 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] Add hook for libraries to be built as part of _prebuild_libs
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         178066
>Category:       conf
>Synopsis:       [PATCH] Add hook for libraries to be built as part of _prebuild_libs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 23 03:10:00 UTC 2013
>Closed-Date:    Fri May 31 04:53:45 UTC 2013
>Last-Modified:  Fri May 31 04:53:45 UTC 2013
>Originator:     Garrett Cooper
>Release:        10-CURRENT
>Organization:
EMC Isilon
>Environment:
FreeBSD gran-tourismo.west.isilon.com 10.0-CURRENT FreeBSD 10.0-CURRENT #2 r+ba9afe9: Fri Apr 19 20:29:10 PDT 2013     gcooper@gran-tourismo.west.isilon.com:/usr/obj/usr/src/sys/GRAN-TOURISMO  amd64
>Description:
Sometimes LOCAL_LIB_DIRS depends on libraries not specified in _prebuild_libs. In order to get around this issue, it's best to add a hook (in this case LOCAL_PREBUILD_LIB_DIRS) in order to automatically append the libraries needing to be built at the end of _prebuild_libs.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

From b7326a9804218ee7cd7e4ed4a161e2a9a690a0e9 Mon Sep 17 00:00:00 2001
From: Garrett Cooper <yanegomi@gmail.com>
Date: Mon, 22 Apr 2013 18:18:35 -0700
Subject: [PATCH 3/3] Allow user to specify _prebuild_libs via
 LOCAL_PREBUILD_LIB_DIRS

Sometimes LOCAL_LIB_DIRS depends on libraries not available in
_prebuild_libs, so it's necessary to tack on libraries in this
way to avoid running into build/linker errors later on.

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
---
 Makefile.inc1 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile.inc1 b/Makefile.inc1
index 5175b5e..de4efcd 100644
--- a/Makefile.inc1
+++ b/Makefile.inc1
@@ -1416,7 +1416,8 @@ _prebuild_libs=	${_kerberos5_lib_libasn1} \
 		${_cddl_lib_libzfs_core} \
 		lib/libutil ${_lib_libypclnt} lib/libz lib/msun \
 		${_secure_lib_libcrypto} ${_secure_lib_libssh} \
-		${_secure_lib_libssl}
+		${_secure_lib_libssl} \
+		${LOCAL_PREBUILD_LIB_DIRS} \
 
 .if ${MK_ATF} != "no"
 _lib_atf=	lib/atf
-- 
1.8.2



>Release-Note:
>Audit-Trail:

From: Garrett Cooper <yaneurabeya@gmail.com>
To: bug-followup@FreeBSD.org, yaneurabeya@gmail.com
Cc:  
Subject: Re: conf/178066: [PATCH] Add hook for libraries to be built as part
 of _prebuild_libs
Date: Thu, 30 May 2013 21:49:09 -0700

     Please close this PR. It would be a REALLY, REALLY bad design
 mistake to allow this to be committed to head/.
 Thanks!
 -Garrett
State-Changed-From-To: open->closed 
State-Changed-By: gjb 
State-Changed-When: Fri May 31 04:53:32 UTC 2013 
State-Changed-Why:  
Closed at submitter's request. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=178066 
>Unformatted:
