From nobody@FreeBSD.org  Fri Feb  1 07:23:56 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 7BDFFE4E
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  1 Feb 2013 07:23:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B204F6D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  1 Feb 2013 07:23:56 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r117Ntf2052278
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 1 Feb 2013 07:23:55 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r117NthZ052277;
	Fri, 1 Feb 2013 07:23:55 GMT
	(envelope-from nobody)
Message-Id: <201302010723.r117NthZ052277@red.freebsd.org>
Date: Fri, 1 Feb 2013 07:23:55 GMT
From: Issei <i10a@herbmint.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: FreeBSD 10.0-CURRENT: build failure with "device runfw" 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         175751
>Category:       conf
>Synopsis:       FreeBSD 10.0-CURRENT: build failure with "device runfw"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 01 07:30:00 UTC 2013
>Closed-Date:    Sat Jun 22 00:21:47 UTC 2013
>Last-Modified:  Tue Dec 31 16:10:00 UTC 2013
>Originator:     Issei
>Release:        FreeBSD 10.0-CURRENT
>Organization:
>Environment:
FreeBSD nerima 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r246191M: Fri Feb  1 16:00:47 JST 2013     root@nerima:/usr/obj/usr/src/sys/RPI-B-i10a  arm
>Description:
On FreeBSD 10.0-CURRENT/amd64 or /arm, moist recent sources, adding
"device runfw" to kernel configuration file results in build error.



cc -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000  -mno-thumb-interwork -ffreestanding -c runfw.c
uudecode -o runfw /usr/src/sys/contrib/dev/run/rt2870.fw.uu
ld -b binary --no-warn-mismatch -d -warn-common -r  -o runfw.fwo 
ld: no input files
*** [runfw.fwo] Error code 1

Stop in /usr/obj/usr/src/sys/RPI-B-i10a.
*** [buildkernel] Error code 1

Stop in /usr/src.
*** [buildkernel] Error code 1

Stop in /usr/src.

>How-To-Repeat:
Add 2 lines to your kernel configuration file.

device          firmware
device          runfw

>Fix:
Index: sys/conf/files
===================================================================
--- sys/conf/files      (revision 246145)
+++ sys/conf/files      (working copy)
@@ -2208,19 +2208,19 @@
 dev/usb/wlan/if_rum.c          optional rum
 dev/usb/wlan/if_run.c          optional run
 runfw.c                                optional runfw                         \
-       compile-with    "${AWK} -f $S/tools/fw_stub.awk runfw:runfw -mrunfw -c${.TARGET}"       \
+       compile-with    "${AWK} -f $S/tools/fw_stub.awk runfw.fw:runfw -mrunfw -c${.TARGET}"    \
        no-implicit-rule before-depend local                                   \
        clean           "runfw.c"
 runfw.fwo                      optional runfw                                 \
-       dependency      "runfw"                                                \
+       dependency      "runfw.fw"                                             \
        compile-with    "${NORMAL_FWO}"                                        \
        no-implicit-rule                                                       \
        clean           "runfw.fwo"
-runfw                          optional runfw                                 \
+runfw.fw                       optional runfw                                 \
        dependency      "$S/contrib/dev/run/rt2870.fw.uu"                      \
        compile-with    "${NORMAL_FW}"                                         \
        no-obj no-implicit-rule                                                \
-       clean           "runfw"
+       clean           "runfw.fw"
 dev/usb/wlan/if_uath.c         optional uath
 dev/usb/wlan/if_upgt.c         optional upgt
 dev/usb/wlan/if_ural.c         optional ural
Index: sys/modules/runfw/Makefile
===================================================================
--- sys/modules/runfw/Makefile  (revision 246145)
+++ sys/modules/runfw/Makefile  (working copy)
@@ -1,11 +1,11 @@
 # $FreeBSD$
 
 KMOD=  runfw
-FIRMWS=        runfw:runfw:1
+FIRMWS=        runfw.fw:runfw:1
 
-CLEANFILES=    runfw
+CLEANFILES=    runfw.fw
 
-runfw: ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu
+runfw.fw: ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu
        uudecode -p ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu > ${.TARGET}
 
 .include <bsd.kmod.mk>


>Release-Note:
>Audit-Trail:

From: Giorgos Keramidas <keramida@FreeBSD.org>
To: Issei <i10a@herbmint.jp>
Cc: bug-followup@freebsd.org, Andrew Thompson <thompsa@freebsd.org>
Subject: Re: conf/175751: FreeBSD 10.0-CURRENT: build failure with "device
 runfw"
Date: Tue, 5 Feb 2013 19:38:17 +0100

 On 2013-02-01 07:23, Issei <i10a@herbmint.jp> wrote:
 > >Number:         175751
 > >Category:       conf
 > >Synopsis:       FreeBSD 10.0-CURRENT: build failure with "device runfw"
 
 > On FreeBSD 10.0-CURRENT/amd64 or /arm, moist recent sources, adding
 > "device runfw" to kernel configuration file results in build error.
 
 > cc -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000  -mno-thumb-interw ork -ffreestanding -c runfw.c
 > uudecode -o runfw /usr/src/sys/contrib/dev/run/rt2870.fw.uu
 > ld -b binary --no-warn-mismatch -d -warn-common -r  -o runfw.fwo
 > ld: no input files
 > *** [runfw.fwo] Error code 1
 
 Andrew (thompsa) may want to chime in and check this change for runfw
 too, so I've Cc:ed him in this thread too.
 
 This error is present for amd64 too.  I just tried rebuilding a kernel
 with this configuration file, and I can reproduce this error myself too:
 
 kobe:~$ cat -nv /usr/src/sys/amd64/conf/RUNFW
      1	#
      2	# RUNFW -- test kernel for device runfw
      3	#
      4	include		GENERIC
      5	ident			RUNFW
      6
      7	device          firmware
      8	device          runfw
 kobe:~$
 
 And this is indeed the fix, because it breaks the circular dependency of
 'runfw -> runfw' in sys/conf/files.  Thanks!
 
 > Index: sys/conf/files
 > ===================================================================
 > --- sys/conf/files      (revision 246145)
 > +++ sys/conf/files      (working copy)
 > @@ -2208,19 +2208,19 @@
 >  dev/usb/wlan/if_rum.c          optional rum
 >  dev/usb/wlan/if_run.c          optional run
 >  runfw.c                                optional runfw                         \
 > -       compile-with    "${AWK} -f $S/tools/fw_stub.awk runfw:runfw -mrunfw -c${.TARGET}"       \
 > +       compile-with    "${AWK} -f $S/tools/fw_stub.awk runfw.fw:runfw -mrunfw -c${.TARGET}"    \
 >         no-implicit-rule before-depend local                                   \
 >         clean           "runfw.c"
 >  runfw.fwo                      optional runfw                                 \
 > -       dependency      "runfw"                                                \
 > +       dependency      "runfw.fw"                                             \
 >         compile-with    "${NORMAL_FWO}"                                        \
 >         no-implicit-rule                                                       \
 >         clean           "runfw.fwo"
 > -runfw                          optional runfw                                 \
 > +runfw.fw                       optional runfw                                 \
 >         dependency      "$S/contrib/dev/run/rt2870.fw.uu"                      \
 >         compile-with    "${NORMAL_FW}"                                         \
 >         no-obj no-implicit-rule                                                \
 > -       clean           "runfw"
 > +       clean           "runfw.fw"
 >  dev/usb/wlan/if_uath.c         optional uath
 >  dev/usb/wlan/if_upgt.c         optional upgt
 >  dev/usb/wlan/if_ural.c         optional ural
 > Index: sys/modules/runfw/Makefile
 > ===================================================================
 > --- sys/modules/runfw/Makefile  (revision 246145)
 > +++ sys/modules/runfw/Makefile  (working copy)
 > @@ -1,11 +1,11 @@
 >  # $FreeBSD$
 >
 >  KMOD=  runfw
 > -FIRMWS=        runfw:runfw:1
 > +FIRMWS=        runfw.fw:runfw:1
 >
 > -CLEANFILES=    runfw
 > +CLEANFILES=    runfw.fw
 >
 > -runfw: ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu
 > +runfw.fw: ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu
 >         uudecode -p ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu > ${.TARGET}
 >
 >  .include <bsd.kmod.mk>

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/175751: commit references a PR
Date: Fri, 21 Jun 2013 18:17:02 +0000 (UTC)

 Author: gonzo
 Date: Fri Jun 21 18:16:54 2013
 New Revision: 252064
 URL: http://svnweb.freebsd.org/changeset/base/252064
 
 Log:
   Rename run(4) firmware file from runfw to run.fw. Previous name was the
   same as top-level target name for "device runfw" kernel option and
   caused cyclic dependancy that lead to kernel build breakage
   
   Module change is not strictly required and done for name unification sake
   
   PR:		conf/175751
   Submitted by:	    Issei <i10a at herbmint.jp>
 
 Modified:
   head/sys/conf/files
   head/sys/modules/runfw/Makefile
 
 Modified: head/sys/conf/files
 ==============================================================================
 --- head/sys/conf/files	Fri Jun 21 17:36:33 2013	(r252063)
 +++ head/sys/conf/files	Fri Jun 21 18:16:54 2013	(r252064)
 @@ -2284,19 +2284,19 @@ dev/usb/net/uhso.c		optional uhso
  dev/usb/wlan/if_rum.c		optional rum
  dev/usb/wlan/if_run.c		optional run
  runfw.c				optional runfw							\
 -	compile-with	"${AWK} -f $S/tools/fw_stub.awk runfw:runfw -mrunfw -c${.TARGET}"	\
 +	compile-with	"${AWK} -f $S/tools/fw_stub.awk run.fw:runfw -mrunfw -c${.TARGET}"	\
  	no-implicit-rule before-depend local							\
  	clean		"runfw.c"
  runfw.fwo			optional runfw							\
 -	dependency	"runfw"									\
 +	dependency	"run.fw"								\
  	compile-with	"${NORMAL_FWO}"								\
  	no-implicit-rule									\
  	clean		"runfw.fwo"
 -runfw				optional runfw							\
 +run.fw				optional runfw							\
  	dependency	"$S/contrib/dev/run/rt2870.fw.uu"					\
  	compile-with	"${NORMAL_FW}"								\
  	no-obj no-implicit-rule									\
 -	clean		"runfw"
 +	clean		"run.fw"
  dev/usb/wlan/if_uath.c		optional uath
  dev/usb/wlan/if_upgt.c		optional upgt
  dev/usb/wlan/if_ural.c		optional ural
 
 Modified: head/sys/modules/runfw/Makefile
 ==============================================================================
 --- head/sys/modules/runfw/Makefile	Fri Jun 21 17:36:33 2013	(r252063)
 +++ head/sys/modules/runfw/Makefile	Fri Jun 21 18:16:54 2013	(r252064)
 @@ -1,11 +1,11 @@
  # $FreeBSD$
  
  KMOD=	runfw
 -FIRMWS=	runfw:runfw:1
 +FIRMWS=	run.fw:runfw:1
  
 -CLEANFILES=	runfw
 +CLEANFILES=	run.fw
  
 -runfw: ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu
 +run.fw: ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu
  	uudecode -p ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu > ${.TARGET}
  
  .include <bsd.kmod.mk>
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: gonzo 
State-Changed-When: Sat Jun 22 00:20:52 UTC 2013 
State-Changed-Why:  
Fix committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175751 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/175751: commit references a PR
Date: Tue, 31 Dec 2013 16:01:26 +0000 (UTC)

 Author: kevlo
 Date: Tue Dec 31 16:01:17 2013
 New Revision: 260134
 URL: http://svnweb.freebsd.org/changeset/base/260134
 
 Log:
   MFC r252064:
   
   Rename run(4) firmware file from runfw to run.fw. Previous name was the
   same as top-level target name for "device runfw" kernel option and
   caused cyclic dependancy that lead to kernel build breakage
   
   Module change is not strictly required and done for name unification sake
   
   PR:	conf/175751
   Submitted by:	Issei <i10a at herbmint.jp>
 
 Modified:
   stable/9/sys/conf/files
 Directory Properties:
   stable/9/sys/conf/   (props changed)
 
 Modified: stable/9/sys/conf/files
 ==============================================================================
 --- stable/9/sys/conf/files	Tue Dec 31 15:45:12 2013	(r260133)
 +++ stable/9/sys/conf/files	Tue Dec 31 16:01:17 2013	(r260134)
 @@ -2033,19 +2033,19 @@ dev/usb/net/uhso.c		optional uhso
  dev/usb/wlan/if_rum.c		optional rum
  dev/usb/wlan/if_run.c		optional run
  runfw.c				optional runfw							\
 -	compile-with	"${AWK} -f $S/tools/fw_stub.awk runfw:runfw -mrunfw -c${.TARGET}"	\
 +	compile-with	"${AWK} -f $S/tools/fw_stub.awk run.fw:runfw -mrunfw -c${.TARGET}"	\
  	no-implicit-rule before-depend local							\
  	clean		"runfw.c"
  runfw.fwo			optional runfw							\
 -	dependency	"runfw"									\
 +	dependency	"run.fw"								\
  	compile-with	"${NORMAL_FWO}"								\
  	no-implicit-rule									\
  	clean		"runfw.fwo"
 -runfw				optional runfw							\
 +run.fw				optional runfw							\
  	dependency	"$S/contrib/dev/run/rt2870.fw.uu"					\
  	compile-with	"${NORMAL_FW}"								\
  	no-obj no-implicit-rule									\
 -	clean		"runfw"
 +	clean		"run.fw"
  dev/usb/wlan/if_uath.c		optional uath
  dev/usb/wlan/if_upgt.c		optional upgt
  dev/usb/wlan/if_ural.c		optional ural
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
