From nobody@FreeBSD.org  Wed Jul 18 13:53:31 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7BB1C106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Jul 2012 13:53:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 6749A8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Jul 2012 13:53:31 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q6IDrVcO051931
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Jul 2012 13:53:31 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q6IDrVGE051930;
	Wed, 18 Jul 2012 13:53:31 GMT
	(envelope-from nobody)
Message-Id: <201207181353.q6IDrVGE051930@red.freebsd.org>
Date: Wed, 18 Jul 2012 13:53:31 GMT
From: Mark Johnston <markjdb@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [newsyslog.conf] add 'N' flag for sendmail.st
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         169973
>Category:       conf
>Synopsis:       [newsyslog.conf] [patch] add 'N' flag for sendmail.st
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    markj
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 18 14:00:01 UTC 2012
>Closed-Date:    Mon Dec 31 22:13:54 UTC 2012
>Last-Modified:  Mon Dec 31 22:13:54 UTC 2012
>Originator:     Mark Johnston
>Release:        CURRENT
>Organization:
Sandvine Inc.
>Environment:
FreeBSD oddish 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r237931+09aeb19-dirty: Sun Jul  1 13:10:47 EDT 2012     mark@oddish:/home/mark/src/obj/usr/home/mark/src/freebsd/sys/GENERIC  amd64
>Description:
The newsyslog.conf entry for /var/log/sendmail.st should use the 'N' flag. The only process that writes to /var/log/sendmail.st is sendmail itself, and it doesn't hold the file open: it just opens it as needed in the poststats() function.

In particular, syslogd shouldn't receive SIGHUP when sendmail.st is rotated.
>How-To-Repeat:

>Fix:
Add the 'N' flag to the sendmail.st entry in newsyslog.conf, as in the patch below.

Patch attached with submission follows:

diff --git a/etc/newsyslog.conf b/etc/newsyslog.conf
index 44aff12..e0154e3 100644
--- a/etc/newsyslog.conf
+++ b/etc/newsyslog.conf
@@ -33,7 +33,7 @@
 /var/log/pflog				600  3	   100	*     JB    /var/run/pflogd.pid
 /var/log/ppp.log	root:network	640  3	   100	*     JC
 /var/log/security			600  10	   100	*     JC
-/var/log/sendmail.st			640  10	   *	168   B
+/var/log/sendmail.st			640  10	   *	168   BN
 /var/log/utx.log			644  3	   *	@01T05 B
 /var/log/weekly.log			640  5	   1	$W6D0 JN
 /var/log/xferlog			600  7	   100	*     JC


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->markj 
Responsible-Changed-By: markj 
Responsible-Changed-When: Wed Dec 19 17:34:05 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169973 
State-Changed-From-To: open->patched 
State-Changed-By: markj 
State-Changed-When: Thu Dec 20 23:25:17 UTC 2012 
State-Changed-Why:  
awaiting MFC 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169973 
State-Changed-From-To: patched->closed 
State-Changed-By: markj 
State-Changed-When: Mon Dec 31 22:13:54 UTC 2012 
State-Changed-Why:  
Committed and MFCed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169973 
>Unformatted:
