From nobody@FreeBSD.org  Sun May  6 18:23:14 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4A727106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  6 May 2012 18:23:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 35A098FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  6 May 2012 18:23:14 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q46INDEZ069620
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 6 May 2012 18:23:13 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q46INDZG069614;
	Sun, 6 May 2012 18:23:13 GMT
	(envelope-from nobody)
Message-Id: <201205061823.q46INDZG069614@red.freebsd.org>
Date: Sun, 6 May 2012 18:23:13 GMT
From: Jeff Kletsky <freebsd@wagsky.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Update rc.conf man page to use "new" ipv4_addrs_<interface> for VLANs
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         167648
>Category:       conf
>Synopsis:       Update rc.conf man page to use "new" ipv4_addrs_<interface> for VLANs
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 06 18:30:12 UTC 2012
>Closed-Date:    Sat Sep 08 13:02:05 UTC 2012
>Last-Modified:  Sat Sep 08 13:02:05 UTC 2012
>Originator:     Jeff Kletsky
>Release:        9.0-STABLE
>Organization:
>Environment:
FreeBSD port16.pn.wagsky.com 9.0-STABLE FreeBSD 9.0-STABLE #0: Mon Apr 23 08:07:43 PDT 2012     root@port16.pn.wagsky.com:/usr/obj/usr/src/sys/JMK.2012-04-23  i386

>Description:
The "new" method for specifying IPv4 addresses ipv4_addrs_<interface> is discussed in the rc.conf(5) man page. It also indicates that the "old" method of using ifconfig_<interface>_alias<n> is deprecated. 

However, the vlan-related section still uses the "old" method:


                 To create a vlan device named em0.101 on em0 with the vlan
                 tag 101 and the optional the IPv4 address 192.0.2.1/24:

                 vlans_em0="101"
                 ifconfig_em0_101="inet 192.0.2.1/24"

Suggest changing this to


                 To create a vlan device named em0.101 on em0 with the vlan
                 tag 101 and the optional the IPv4 address 192.0.2.1/24:

                 vlans_em0="101"
                 ipv4_addrs_em0_101="inet 192.0.2.1/24"

to improve clarity and reinforce the "new" method of setting IPv4 addresses.
>How-To-Repeat:

>Fix:
Relative to $FreeBSD: src/share/man/man5/rc.conf.5,v 1.398.2.7 2012/04/26 20:11:57 gjb Exp $

--- /usr/src/share/man/man5/rc.conf.5	2012-04-28 07:28:40.000000000 -0700
+++ rc.conf.5	2012-05-06 11:21:01.000000000 -0700
@@ -1191,7 +1191,7 @@
 with the vlan tag 101 and the optional the IPv4 address 192.0.2.1/24:
 .Bd -literal
 vlans_em0="101"
-ifconfig_em0_101="inet 192.0.2.1/24"
+ipv4_addrs_em0_101="inet 192.0.2.1/24"
 .Ed
 .Pp
 To create a vlan device named


>Release-Note:
>Audit-Trail:

From: Jeff Kletsky <freebsd@wagsky.com>
To: bug-followup@FreeBSD.org, freebsd@wagsky.com
Cc:  
Subject: Re: conf/167648: Update rc.conf man page to use &quot;new&quot; ipv4_addrs_&lt;interface&gt;
 for VLANs
Date: Sun, 06 May 2012 12:32:29 -0700

 With apologies, the line should read
 
 ipv4_addrs_em0_101="192.0.2.1/24"
 
 and the patch should be
 
 --- /usr/src/share/man/man5/rc.conf.5    2012-04-28 07:28:40.000000000 -0700
 +++ rc.conf.5    2012-05-06 11:25:19.000000000 -0700
 @@ -1191,7 +1191,7 @@
   with the vlan tag 101 and the optional the IPv4 address 192.0.2.1/24:
   .Bd -literal
   vlans_em0="101"
 -ifconfig_em0_101="inet 192.0.2.1/24"
 +ipv4_addrs_em0_101="192.0.2.1/24"
   .Ed
   .Pp
   To create a vlan device named
 
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun May 6 20:14:59 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167648 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Wed Jul 25 06:50:14 UTC 2012 
State-Changed-Why:  
requested review, awaiting reply 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167648 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/167648: commit references a PR
Date: Sun,  5 Aug 2012 08:20:17 +0000 (UTC)

 Author: eadler
 Date: Sun Aug  5 08:19:52 2012
 New Revision: 239049
 URL: http://svn.freebsd.org/changeset/base/239049
 
 Log:
   Use new method of assigning IPv4 addresses
   
   PR:		conf/167648
   Submitted by:	Jeff Kletsky <freebsd@wagsky.com>
   Approved by:	bcr
   MFC after:	3 days
 
 Modified:
   head/share/man/man5/rc.conf.5
 
 Modified: head/share/man/man5/rc.conf.5
 ==============================================================================
 --- head/share/man/man5/rc.conf.5	Sun Aug  5 08:10:02 2012	(r239048)
 +++ head/share/man/man5/rc.conf.5	Sun Aug  5 08:19:52 2012	(r239049)
 @@ -1201,7 +1201,7 @@ on
  with the vlan tag 101 and the optional the IPv4 address 192.0.2.1/24:
  .Bd -literal
  vlans_em0="101"
 -ifconfig_em0_101="inet 192.0.2.1/24"
 +ipv4_addrs_em0_101="192.0.2.1/24"
  .Ed
  .Pp
  To create a vlan device named
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->patched 
State-Changed-By: eadler 
State-Changed-When: Sun Aug 5 15:49:04 UTC 2012 
State-Changed-Why:  
patched in r239049 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167648 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/167648: commit references a PR
Date: Sat,  8 Sep 2012 12:46:01 +0000 (UTC)

 Author: eadler
 Date: Sat Sep  8 12:45:47 2012
 New Revision: 240237
 URL: http://svn.freebsd.org/changeset/base/240237
 
 Log:
   Revert r239049:
   This is the way to assign a range, but not
   a single IPv4 address.
   
   PR:		conf/167648
   Approved by:	cperciva (implicit)
 
 Modified:
   head/share/man/man5/rc.conf.5
 
 Modified: head/share/man/man5/rc.conf.5
 ==============================================================================
 --- head/share/man/man5/rc.conf.5	Sat Sep  8 11:34:22 2012	(r240236)
 +++ head/share/man/man5/rc.conf.5	Sat Sep  8 12:45:47 2012	(r240237)
 @@ -1201,7 +1201,7 @@ on
  with the vlan tag 101 and the optional the IPv4 address 192.0.2.1/24:
  .Bd -literal
  vlans_em0="101"
 -ipv4_addrs_em0_101="192.0.2.1/24"
 +ifconfig_em0_101="inet 192.0.2.1/24"
  .Ed
  .Pp
  To create a vlan device named
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Sat Sep 8 13:02:02 UTC 2012 
State-Changed-Why:  
per the latest commit 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167648 
>Unformatted:
