From jdc@koitsu.dyndns.org  Wed Mar 28 01:58:59 2012
Return-Path: <jdc@koitsu.dyndns.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 72CEE106566C
	for <freebsd-gnats-submit@freebsd.org>; Wed, 28 Mar 2012 01:58:59 +0000 (UTC)
	(envelope-from jdc@koitsu.dyndns.org)
Received: from qmta11.emeryville.ca.mail.comcast.net (qmta11.emeryville.ca.mail.comcast.net [76.96.27.211])
	by mx1.freebsd.org (Postfix) with ESMTP id 5985E8FC0C
	for <freebsd-gnats-submit@freebsd.org>; Wed, 28 Mar 2012 01:58:59 +0000 (UTC)
Received: from omta09.emeryville.ca.mail.comcast.net ([76.96.30.20])
	by qmta11.emeryville.ca.mail.comcast.net with comcast
	id qpqy1i0020S2fkCABpxtjz; Wed, 28 Mar 2012 01:57:53 +0000
Received: from koitsu.dyndns.org ([67.180.84.87])
	by omta09.emeryville.ca.mail.comcast.net with comcast
	id qpxs1i00L1t3BNj8VpxswE; Wed, 28 Mar 2012 01:57:52 +0000
Received: by icarus.home.lan (Postfix, from userid 1000)
	id 0F2A9102C1E; Tue, 27 Mar 2012 18:57:52 -0700 (PDT)
Message-Id: <20120328015752.0F2A9102C1E@icarus.home.lan>
Date: Tue, 27 Mar 2012 18:57:52 -0700 (PDT)
From: Jeremy Chadwick <freebsd@jdc.parodius.com>
Reply-To: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: WITHOUT_IPFILTER does not remove ipfstat-reliant periodic scripts
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         166460
>Category:       conf
>Synopsis:       WITHOUT_IPFILTER does not remove ipfstat-reliant periodic scripts
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 28 02:00:22 UTC 2012
>Closed-Date:    Thu May 31 07:44:56 UTC 2012
>Last-Modified:  Thu May 31 07:50:02 UTC 2012
>Originator:     Jeremy Chadwick
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD icarus.home.lan 8.2-STABLE FreeBSD 8.2-STABLE #0: Fri Feb 10 17:43:50 PST 2012 root@icarus.home.lan:/usr/obj/usr/src/sys/X7SBA_RELENG_8_amd64 amd64
>Description:
	First: not sure if I got the right Category.  This might be kern
	or misc.

	Issue was discussed on freebsd-stable here:
	http://lists.freebsd.org/pipermail/freebsd-stable/2012-March/066962.html
	http://lists.freebsd.org/pipermail/freebsd-stable/2012-March/066978.html (root cause)

	When ipfilter is removed from the system via src.conf knob
	WITHOUT_IPFILTER, periodic scripts which rely on ipfstat(8) do not
	get removed during "make delete-old".  This results in errors
	like the following during "periodic security" phase:

	ipfstat: not found

	Root cause appears to be lack of OLD_FILES entries for the two
	periodic scripts in question.  Patch should fix this.  Only tested on
	RELENG_8; other adjustments may be needed for RELENG_7 or RELENG_9.

	Note that etc/periodic/security/610.ipf6denied is a tricky one: it's both
	IPFILTER-related *and* IPv6.  So I'm not sure if this removal should go
	under the MK_IPFILTER check or the MK_INET6 check.
>How-To-Repeat:
	1. Add WITHOUT_IPFILTER=true to /etc/src.conf
	2. Rebuild system (world/kernel), mergemaster, etc... -- the usual
	3. Run "periodic security" and watch for "ipfstat: not found" messages
>Fix:
	Apply below patch:

--- src/tools/build/mk/OptionalObsoleteFiles.inc.orig	2010-11-22 17:39:30.000000000 -0800
+++ src/tools/build/mk/OptionalObsoleteFiles.inc	2012-03-27 18:56:15.167308202 -0700
@@ -605,6 +605,8 @@
 OLD_FILES+=usr/share/man/man8/ipmon.8.gz
 OLD_FILES+=usr/share/man/man8/ipnat.8.gz
 OLD_FILES+=usr/share/man/man8/ippool.8.gz
+OLD_FILES+=etc/periodic/security/510.ipfdenied
+OLD_FILES+=etc/periodic/security/610.ipf6denied
 .endif
 
 .if ${MK_IPX} == no
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Wed Mar 28 02:41:43 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166460 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Sun May 6 14:05:42 UTC 2012 
State-Changed-Why:  
awaiting approval 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166460 
State-Changed-From-To: analyzed->patched 
State-Changed-By: eadler 
State-Changed-When: Fri May 11 02:45:53 UTC 2012 
State-Changed-Why:  
committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166460 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Thu May 31 07:44:55 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166460 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/166460: commit references a PR
Date: Thu, 31 May 2012 07:44:47 +0000 (UTC)

 Author: eadler
 Date: Thu May 31 07:44:27 2012
 New Revision: 236354
 URL: http://svn.freebsd.org/changeset/base/236354
 
 Log:
   MFC r235204:
   	Add some missing files to OLD_FILES
   
   PR:		conf/166460
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/9/tools/build/mk/OptionalObsoleteFiles.inc
 Directory Properties:
   stable/9/tools/build/   (props changed)
 
 Modified: stable/9/tools/build/mk/OptionalObsoleteFiles.inc
 ==============================================================================
 --- stable/9/tools/build/mk/OptionalObsoleteFiles.inc	Thu May 31 07:40:37 2012	(r236353)
 +++ stable/9/tools/build/mk/OptionalObsoleteFiles.inc	Thu May 31 07:44:27 2012	(r236354)
 @@ -2179,6 +2179,8 @@ OLD_FILES+=usr/share/man/man8/ipfstat.8.
  OLD_FILES+=usr/share/man/man8/ipmon.8.gz
  OLD_FILES+=usr/share/man/man8/ipnat.8.gz
  OLD_FILES+=usr/share/man/man8/ippool.8.gz
 +OLD_FILES+=etc/periodic/security/510.ipfdenied
 +OLD_FILES+=etc/periodic/security/610.ipf6denied
  .endif
  
  .if ${MK_IPFW} == no
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
