From nobody@FreeBSD.org  Thu Feb  2 14:45:49 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 499831065670
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  2 Feb 2012 14:45:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 3462E8FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  2 Feb 2012 14:45:49 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q12Ejnm0087844
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 2 Feb 2012 14:45:49 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q12EjmsK087843;
	Thu, 2 Feb 2012 14:45:48 GMT
	(envelope-from nobody)
Message-Id: <201202021445.q12EjmsK087843@red.freebsd.org>
Date: Thu, 2 Feb 2012 14:45:48 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] [pc-sysinstall] add raidz3 support; permit 'raidz' in input
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164709
>Category:       conf
>Synopsis:       [patch] [pc-sysinstall] add raidz3 support; permit 'raidz' in input
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 02 14:50:04 UTC 2012
>Closed-Date:    Tue Mar 20 01:28:18 UTC 2012
>Last-Modified:  Sun Feb 03 22:30:23 UTC 2013
>Originator:     Garrett Cooper
>Release:        9.0-STABLE
>Organization:
n/a
>Environment:
FreeBSD bayonetta.local 9.0-STABLE FreeBSD 9.0-STABLE #4 r230371M: Thu Jan 19 23:55:38 PST 2012     gcooper@bayonetta.local:/usr/obj/store/freebsd/stable/9/sys/BAYONETTA  amd64
>Description:
The attached patch permits one to specify raidz3 in get_fs_line_xvars(..) (RAIDZ3 is 3-disk parity option available in versions of ZFS in 8.3+/9.0+), and also relaxes the checks to allow one to specify raidz instead of raidz1.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh
===================================================================
--- usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh	(revision 230088)
+++ usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh	(working copy)
@@ -59,7 +59,7 @@
       ZTYPE="NONE"
       ZFSVARS="`echo $LINE | cut -d '(' -f 2- | cut -d ')' -f 1 | xargs`"
 
-      echo $ZFSVARS | grep -qE "^(disk|file|mirror|raidz(1|2)?|spare|log|cache):" 2>/dev/null
+      echo $ZFSVARS | grep -qE "^(disk|file|mirror|raidz[1-3]?|spare|log|cache):" 2>/dev/null
 	  if [ $? -eq 0 ] ; then
        ZTYPE=`echo $ZFSVARS | cut -f1 -d:`
        ZFSVARS=`echo $ZFSVARS | sed "s|$ZTYPE: ||g" | sed "s|$ZTYPE:||g"`


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Thu Feb 2 17:00:59 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164709 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Sat Mar 3 03:23:17 UTC 2012 
State-Changed-Why:  
awaiting approval 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164709 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/164709: commit references a PR
Date: Sun,  4 Mar 2012 17:33:35 +0000 (UTC)

 Author: eadler
 Date: Sun Mar  4 17:33:22 2012
 New Revision: 232510
 URL: http://svn.freebsd.org/changeset/base/232510
 
 Log:
   Permit the use of raidz3 in pc-sysinstall
   
   PR:		conf/164709
   Submitted by:	Garrett Cooper <yaneurabeya@gmail.com>
   Reviewed by:	brd, brooks
   Approved by:	cperciva
   MFC after:	3 days
 
 Modified:
   head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh
 
 Modified: head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh
 ==============================================================================
 --- head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh	Sun Mar  4 17:08:43 2012	(r232509)
 +++ head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh	Sun Mar  4 17:33:22 2012	(r232510)
 @@ -59,7 +59,7 @@ get_fs_line_xvars()
        ZTYPE="NONE"
        ZFSVARS="`echo $LINE | cut -d '(' -f 2- | cut -d ')' -f 1 | xargs`"
  
 -      echo $ZFSVARS | grep -qE "^(disk|file|mirror|raidz(1|2)?|spare|log|cache):" 2>/dev/null
 +      echo $ZFSVARS | grep -qE "^(disk|file|mirror|raidz(1|2|3)?|spare|log|cache):" 2>/dev/null
  	  if [ $? -eq 0 ] ; then
         ZTYPE=`echo $ZFSVARS | cut -f1 -d:`
         ZFSVARS=`echo $ZFSVARS | sed "s|$ZTYPE: ||g" | sed "s|$ZTYPE:||g"`
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->patched 
State-Changed-By: eadler 
State-Changed-When: Sun Mar 4 17:49:34 UTC 2012 
State-Changed-Why:  
committed in r232510 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164709 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/164709: commit references a PR
Date: Mon, 19 Mar 2012 23:25:24 +0000 (UTC)

 Author: eadler
 Date: Mon Mar 19 23:25:10 2012
 New Revision: 233225
 URL: http://svn.freebsd.org/changeset/base/233225
 
 Log:
   MFC 232510:
   	Permit the use of raidz3 in pc-sysinstall
   
   PR:		conf/164709
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/9/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh
 Directory Properties:
   stable/9/usr.sbin/pc-sysinstall/   (props changed)
 
 Modified: stable/9/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh
 ==============================================================================
 --- stable/9/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh	Mon Mar 19 23:20:52 2012	(r233224)
 +++ stable/9/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh	Mon Mar 19 23:25:10 2012	(r233225)
 @@ -59,7 +59,7 @@ get_fs_line_xvars()
        ZTYPE="NONE"
        ZFSVARS="`echo $LINE | cut -d ' ' -f 4 |cut -d '(' -f 2- | cut -d ')' -f 1 | xargs`"
  
 -      echo $ZFSVARS | grep -qE "^(disk|file|mirror|raidz(1|2)?|spare|log|cache):" 2>/dev/null
 +      echo $ZFSVARS | grep -qE "^(disk|file|mirror|raidz(1|2|3)?|spare|log|cache):" 2>/dev/null
  	  if [ $? -eq 0 ] ; then
         ZTYPE=`echo $ZFSVARS | cut -f1 -d:`
         ZFSVARS=`echo $ZFSVARS | sed "s|$ZTYPE: ||g" | sed "s|$ZTYPE:||g"`
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Tue Mar 20 01:28:17 UTC 2012 
State-Changed-Why:  
committed to { head, 9 } 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164709 
>Unformatted:
