From nobody@FreeBSD.org  Fri Jul  1 09:02:14 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BF8C41065674
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  1 Jul 2011 09:02:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 97BF28FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  1 Jul 2011 09:02:14 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6192EcQ079540
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 1 Jul 2011 09:02:14 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p6192EFN079539;
	Fri, 1 Jul 2011 09:02:14 GMT
	(envelope-from nobody)
Message-Id: <201107010902.p6192EFN079539@red.freebsd.org>
Date: Fri, 1 Jul 2011 09:02:14 GMT
From: David Demelier <demelier.david@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] /etc/rc.d/pf broken messages
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         158557
>Category:       conf
>Synopsis:       [patch] /etc/rc.d/pf broken messages
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-rc
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 01 09:10:02 UTC 2011
>Closed-Date:    
>Last-Modified:  Sat Jul 02 22:12:52 UTC 2011
>Originator:     David Demelier
>Release:        8.2-STABLE
>Organization:
>Environment:
FreeBSD Groseille.malikania.fr 8.2-STABLE FreeBSD 8.2-STABLE #1: Fri Jun 24 13:18:15 CEST 2011     root@Groseille.malikania.fr:/usr/obj/usr/src/sys/Groseille  amd64

>Description:
The current /etc/rc.d/pf service prints status messages like:

Enabling pfpf enabled
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/158557: [patch] /etc/rc.d/pf broken messages
Date: Fri, 1 Jul 2011 17:21:16 -0500

 ----- Forwarded message from David Demelier <demelier.david@gmail.com> -----
 
 --- pf.diff begins here ---
 --- /etc/rc.d/pf.orig	2011-07-01 10:33:45.000000000 +0200
 +++ /etc/rc.d/pf	2011-07-01 10:57:10.000000000 +0200
 @@ -29,17 +29,19 @@
  	$pf_program -F all > /dev/null 2>&1
  	$pf_program -f "$pf_rules" $pf_flags
  	if ! $pf_program -s info | grep -q "Enabled" ; then
 -		$pf_program -e
 +		msg=`$pf_program -e 2>&1`
 +		check_startmsgs && echo -n ": ${msg}" || echo -n "${msg}"
 +
  	fi
 -	check_startmsgs && echo '.'
 +	echo '.'
  }
 
  pf_stop()
  {
  	if $pf_program -s info | grep -q "Enabled" ; then
 -		echo -n 'Disabling pf'
 -		$pf_program -d
 -		echo '.'
 +		echo -n 'Disabling pf: '
 +		msg=`$pf_program -d 2>&1`
 +		echo "$msg."
  	fi
  }
 
 --- pf.diff ends here ---
 
 -- 
 David Demelier
 
 ----- End forwarded message -----
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Sat Jul 2 22:12:22 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158557 
>Unformatted:
