From ubique@user.z8.ru  Tue Jun  7 13:26:08 2011
Return-Path: <ubique@user.z8.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9136C106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  7 Jun 2011 13:26:08 +0000 (UTC)
	(envelope-from ubique@user.z8.ru)
Received: from bmx1.z8.ru (bmx1.z8.ru [80.93.62.39])
	by mx1.freebsd.org (Postfix) with ESMTP id 463618FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  7 Jun 2011 13:26:08 +0000 (UTC)
Received: from titan.phst ([192.168.6.81] helo=titan.z8.ru)
	by bmx1.z8.ru with esmtp (Exim 4.71 (FreeBSD))
	(envelope-from <ubique@user.z8.ru>)
	id 1QTw8U-000PYe-VC
	for FreeBSD-gnats-submit@freebsd.org; Tue, 07 Jun 2011 17:15:58 +0400
Received: (from ubique@localhost)
	by titan.z8.ru (8.14.3/8.13.8/Submit) id p57DFvT7081739;
	Tue, 7 Jun 2011 17:15:57 +0400 (MSD)
	(envelope-from ubique)
Message-Id: <201106071315.p57DFvT7081739@titan.z8.ru>
Date: Tue, 7 Jun 2011 17:15:57 +0400 (MSD)
From: Dmitry Banschikov <d.banschikov@peterhost.ru>
Reply-To: Dmitry Banschikov <d.banschikov@peterhost.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] /etc/rc.d/quota and quotaon args
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         157687
>Category:       conf
>Synopsis:       [patch] /etc/rc.d/quota and quotaon args
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-rc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 07 13:30:09 UTC 2011
>Closed-Date:    Tue Jul 05 10:41:47 UTC 2011
>Last-Modified:  Tue Jul  5 10:50:08 UTC 2011
>Originator:     Dmitry Banschikov <d.banschikov@peterhost.ru>
>Release:        FreeBSD 6.4-STABLE-201004 amd64
>Organization:
peterhost.ru
>Environment:
System: FreeBSD titan.z8.ru 6.4-STABLE-201004 FreeBSD 6.4-STABLE-201004 #3: Tue Jun 15 12:44:14 MSD 2010 root@build_6_4.z8.ru:/usr/src/sys/amd64/compile/VH_6.4_64_01 amd64

>Description:
    Setting quota_enable="YES" in /etc/rc.conf and after that /etc/rc.d/quota restart (or start, stop) got error:
# /etc/rc.d/quota restart
usage: quotaon [-g] [-u] [-v] -a
quotaon [-g] [-u] [-v] filesystem ...
quotaoff [-g] [-u] [-v] -a
quotaoff [-g] [-u] [-v] filesystem ...
Checking quotas: done.
Enabling quotas: done.

Setting default values for variables quotaon_flags, quotacheck_flags and quotaoff_flags to "-a" will eliminate this error message and automatically complete for all fs with quota support described in /etc/fstab.


>How-To-Repeat:
    Set quota_enable to "YES" in /etc/rc.conf, and execute /etc/rc.d/quota start.
>Fix:
    Included patch sets default values for variable $quotaon_flags, $quotacheck_flags and $quotaoff_flags to "-a".

>Release-Note:
>Audit-Trail:

From: Dmitry Banschikov <d.banschikov@peterhost.ru>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/157687: [patch] /etc/rc.d/quota and quotaon args
Date: Tue, 07 Jun 2011 17:44:11 +0400

 It seems that patch was not attached. Here it is:
 
 --- quota.orig	2004-10-08 18:23:49.000000000 +0400
 +++ quota.new	2011-06-07 16:31:12.000000000 +0400
 @@ -15,18 +15,18 @@
   name="quota"
   rcvar=`set_rcvar`
   start_cmd="quota_start"
 -stop_cmd="/usr/sbin/quotaoff ${quotaoff_flags}"
 +stop_cmd="/usr/sbin/quotaoff ${quotaoff_flags:-\"-a\"}"
 
   quota_start()
   {
   	if checkyesno check_quotas; then
   		echo -n 'Checking quotas:'
 -		quotacheck ${quotacheck_flags}
 +		quotacheck ${quotacheck_flags:-"-a"}
   		echo ' done.'
   	fi
 
   	echo -n 'Enabling quotas:'
 -	quotaon ${quotaon_flags}
 +	quotaon ${quotaon_flags:-"-a"}
   	echo ' done.'
   }
 
 
 
 -- 
 
 Dmitry Banschikov
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Jun 9 21:26:59 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157687 
State-Changed-From-To: open->patched 
State-Changed-By: pluknet 
State-Changed-When: Tue Jun 28 14:27:24 UTC 2011 
State-Changed-Why:  
Thanks for reporting! Different version committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157687 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/157687: commit references a PR
Date: Tue, 28 Jun 2011 14:26:48 +0000 (UTC)

 Author: pluknet
 Date: Tue Jun 28 14:26:34 2011
 New Revision: 223644
 URL: http://svn.freebsd.org/changeset/base/223644
 
 Log:
   Run load_rc_config before stop_cmd definition, so that ${quotaoff_flags}
   is correctly expanded inside stop_cmd instead of getting nothing.
   
   PR:		conf/157687
   Reported by:	Dmitry Banschikov <d.banschikov peterhost ru>
   MFC after:	1 week
 
 Modified:
   head/etc/rc.d/quota
 
 Modified: head/etc/rc.d/quota
 ==============================================================================
 --- head/etc/rc.d/quota	Tue Jun 28 14:10:39 2011	(r223643)
 +++ head/etc/rc.d/quota	Tue Jun 28 14:26:34 2011	(r223644)
 @@ -14,6 +14,7 @@
  
  name="quota"
  rcvar=`set_rcvar`
 +load_rc_config $name
  start_cmd="quota_start"
  stop_cmd="/usr/sbin/quotaoff ${quotaoff_flags}"
  
 @@ -30,5 +31,4 @@ quota_start()
  	echo ' done.'
  }
  
 -load_rc_config $name
  run_rc_command "$1"
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/157687: commit references a PR
Date: Tue,  5 Jul 2011 10:21:19 +0000 (UTC)

 Author: pluknet
 Date: Tue Jul  5 10:21:06 2011
 New Revision: 223783
 URL: http://svn.freebsd.org/changeset/base/223783
 
 Log:
   MFC r223644:
   
   Run load_rc_config early to fix quota knobs expansion.
   
   PR:		conf/157687
 
 Modified:
   stable/8/etc/rc.d/quota
 Directory Properties:
   stable/8/etc/   (props changed)
 
 Modified: stable/8/etc/rc.d/quota
 ==============================================================================
 --- stable/8/etc/rc.d/quota	Tue Jul  5 10:03:21 2011	(r223782)
 +++ stable/8/etc/rc.d/quota	Tue Jul  5 10:21:06 2011	(r223783)
 @@ -14,6 +14,7 @@
  
  name="quota"
  rcvar=`set_rcvar`
 +load_rc_config $name
  start_cmd="quota_start"
  stop_cmd="/usr/sbin/quotaoff ${quotaoff_flags}"
  
 @@ -30,5 +31,4 @@ quota_start()
  	echo ' done.'
  }
  
 -load_rc_config $name
  run_rc_command "$1"
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: pluknet 
State-Changed-When: Tue Jul 5 10:39:21 UTC 2011 
State-Changed-Why:  
Merged to stable/8 (as r223783) and stable/7 (as r223784). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157687 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/157687: commit references a PR
Date: Tue,  5 Jul 2011 10:37:36 +0000 (UTC)

 Author: pluknet
 Date: Tue Jul  5 10:37:17 2011
 New Revision: 223784
 URL: http://svn.freebsd.org/changeset/base/223784
 
 Log:
   MFC r223644:
   
   Run load_rc_config early to fix quota knobs expansion.
   
   PR:		conf/157687
 
 Modified:
   stable/7/etc/rc.d/quota
 Directory Properties:
   stable/7/etc/   (props changed)
 
 Modified: stable/7/etc/rc.d/quota
 ==============================================================================
 --- stable/7/etc/rc.d/quota	Tue Jul  5 10:21:06 2011	(r223783)
 +++ stable/7/etc/rc.d/quota	Tue Jul  5 10:37:17 2011	(r223784)
 @@ -14,6 +14,7 @@
  
  name="quota"
  rcvar="enable_quotas"
 +load_rc_config $name
  start_cmd="quota_start"
  stop_cmd="/usr/sbin/quotaoff ${quotaoff_flags}"
  
 @@ -30,5 +31,4 @@ quota_start()
  	echo ' done.'
  }
  
 -load_rc_config $name
  run_rc_command "$1"
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
