From jdc@koitsu.dyndns.org  Wed May  4 10:31:25 2011
Return-Path: <jdc@koitsu.dyndns.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 70A6E1065675
	for <freebsd-gnats-submit@freebsd.org>; Wed,  4 May 2011 10:31:25 +0000 (UTC)
	(envelope-from jdc@koitsu.dyndns.org)
Received: from qmta13.westchester.pa.mail.comcast.net (qmta13.westchester.pa.mail.comcast.net [76.96.59.243])
	by mx1.freebsd.org (Postfix) with ESMTP id 1DB378FC1C
	for <freebsd-gnats-submit@freebsd.org>; Wed,  4 May 2011 10:31:24 +0000 (UTC)
Received: from omta01.westchester.pa.mail.comcast.net ([76.96.62.11])
	by qmta13.westchester.pa.mail.comcast.net with comcast
	id fNWZ1g0020EZKEL5DNXQ4V; Wed, 04 May 2011 10:31:24 +0000
Received: from koitsu.dyndns.org ([67.180.84.87])
	by omta01.westchester.pa.mail.comcast.net with comcast
	id fNXN1g00Y1t3BNj3MNXPqM; Wed, 04 May 2011 10:31:24 +0000
Received: by icarus.home.lan (Postfix, from userid 1000)
	id 65EE7102C36; Wed,  4 May 2011 03:31:21 -0700 (PDT)
Message-Id: <20110504103121.65EE7102C36@icarus.home.lan>
Date: Wed,  4 May 2011 03:31:21 -0700 (PDT)
From: Jeremy Chadwick <freebsd@jdc.parodius.com>
Reply-To: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: dougb@freebsd.org, florent.thoumie@gmail.com
Subject: 220.backup-pkgdb on RELENG_7 emits tar leading slash warning
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         156810
>Category:       conf
>Synopsis:       220.backup-pkgdb on RELENG_7 emits tar leading slash warning
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 04 10:40:08 UTC 2011
>Closed-Date:    Mon May 16 20:35:39 UTC 2011
>Last-Modified:  Mon May 16 20:35:39 UTC 2011
>Originator:     Jeremy Chadwick
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD icarus.home.lan 8.2-STABLE FreeBSD 8.2-STABLE #0: Tue May 3 04:29:11 PDT 2011 root@icarus.home.lan:/usr/obj/usr/src/sys/X7SBA_RELENG_8_amd64 amd64
>Description:
	First, please note the above Release and Environment statements are not
	from a RELENG_7 box (obviously :-) ).  The issue I'm describing is
	specific to RELENG_7's version of tar, which differs from RELENG_8.

	RELENG_7 tar spits out a warning when attempting to tar something
	with a leading slash:

	Backing up package db directory:
	tar: Removing leading '/' from member names

	RELENG_8 tar has different logic in util.c, causing it not to output
	said warning.  I'm not sure if there's any effort underway to backport
	RELENG_8's tar to RELENG_7.
>How-To-Repeat:
	Run /etc/periodic/daily/220.backup-pkgdb on a present-day RELENG_7 box.
>Fix:
	There's multiple ways to fix this, but I think the easiest is to
	simply redirect stderr to /dev/null like so (diff):

-	if tar -cjf "${new_bak_file}" "$pkg_dbdir"; then
+	if tar -cjf "${new_bak_file}" "$pkg_dbdir" 2>/dev/null; then

	I've tested this on a RELENG_7 (7.4-STABLE) box dated 2011/04/30 and
	it does work.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: dougb 
State-Changed-When: Thu May 5 02:30:42 UTC 2011 
State-Changed-Why:  

r221475 


Responsible-Changed-From-To: freebsd-ports-bugs->dougb 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Thu May 5 02:30:42 UTC 2011 
Responsible-Changed-Why:  

My problem. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156810 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/156810: commit references a PR
Date: Thu,  5 May 2011 02:35:26 +0000 (UTC)

 Author: dougb
 Date: Thu May  5 02:35:11 2011
 New Revision: 221475
 URL: http://svn.freebsd.org/changeset/base/221475
 
 Log:
   1. If PKG_DBDIR cannot be determined from make, set the default
   2. Add the -H flag to tar in case /var/db/pkg itself is a symlink
   3. Direct stderr to /dev/null to suppress the leading slash warning [1]
   
   PR:		ports/156810 [1]
   Submitted by:	Jeremy Chadwick <freebsd@jdc.parodius.com> [1]
 
 Modified:
   head/etc/periodic/daily/220.backup-pkgdb
 
 Modified: head/etc/periodic/daily/220.backup-pkgdb
 ==============================================================================
 --- head/etc/periodic/daily/220.backup-pkgdb	Thu May  5 02:04:56 2011	(r221474)
 +++ head/etc/periodic/daily/220.backup-pkgdb	Thu May  5 02:35:11 2011	(r221475)
 @@ -18,7 +18,8 @@ case "$daily_backup_pkgdb_enable" in
  	bak="${daily_backup_pkgdb_dir:-/var/backups}"
  	bak_file="${bak}/pkgdb.bak.tbz"
  
 -	pkg_dbdir=`make -f/usr/share/mk/bsd.port.mk -V PKG_DBDIR 2>/dev/null`
 +	pkg_dbdir=`make -f/usr/share/mk/bsd.port.mk -V PKG_DBDIR 2>/dev/null` ||
 +	  pkg_dbdir=/var/db/pkg
  
  	if [ ! -d "$bak" ]
  	then
 @@ -33,7 +34,7 @@ case "$daily_backup_pkgdb_enable" in
  
  	new_bak_file=`mktemp ${bak_file}-XXXXX`
  
 -	if tar -cjf "${new_bak_file}" "$pkg_dbdir"; then
 +	if tar -cjHf "${new_bak_file}" "$pkg_dbdir" 2>/dev/null; then
  	    chmod 644 "${new_bak_file}"
  
  	    if [ -e "${bak_file}.2" -a -e "${bak_file}" ]; then
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: dougb 
State-Changed-When: Mon May 16 20:35:19 UTC 2011 
State-Changed-Why:  
MFC complete. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156810 
>Unformatted:
