From nobody@FreeBSD.org  Mon Mar 21 01:15:00 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BE75B1065675
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Mar 2011 01:15:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A47938FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Mar 2011 01:15:00 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2L1F0bj029417
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Mar 2011 01:15:00 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2L1F0Mx029416;
	Mon, 21 Mar 2011 01:15:00 GMT
	(envelope-from nobody)
Message-Id: <201103210115.p2L1F0Mx029416@red.freebsd.org>
Date: Mon, 21 Mar 2011 01:15:00 GMT
From: Eitan Adler <lists@eitanadler.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] reaper of the dead: time to BURN_BRIDGES and remove bsd.compat.mk 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155738
>Category:       conf
>Synopsis:       [exp-run] [patch] reaper of the dead: time to BURN_BRIDGES and remove bsd.compat.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 21 01:20:01 UTC 2011
>Closed-Date:    Fri Jan 11 10:10:30 UTC 2013
>Last-Modified:  Fri Jan 11 10:10:30 UTC 2013
>Originator:     Eitan Adler
>Release:        
>Organization:
>Environment:
>Description:
I'm a able to build world with the current sources and BURN_BRIDGES set (and the  .warn changed to .error) as well as the with the patch supplied.

The compatibility options described were initially committed by ru@ in r139103 (2004) and last touched in r172831 (2007).

It has been 4 years since these options have been deprecated so I think it would be a good time to remove these compatibility options. 
>How-To-Repeat:

>Fix:
$svn rm bsd.compat.mk





Index: bsd.own.mk
===================================================================
--- bsd.own.mk	(revision 219789)
+++ bsd.own.mk	(working copy)
@@ -198,80 +198,6 @@
 .endfor
 
 #
-# Compat NO_* options (same as above, except their use is deprecated).
-#
-.if !defined(BURN_BRIDGES)
-.for var in \
-    ACPI \
-    ATM \
-    AUDIT \
-    AUTHPF \
-    BIND \
-    BIND_DNSSEC \
-    BIND_ETC \
-    BIND_LIBS_LWRES \
-    BIND_MTREE \
-    BIND_NAMED \
-    BIND_UTILS \
-    BLUETOOTH \
-    BOOT \
-    CALENDAR \
-    CPP \
-    CRYPT \
-    CVS \
-    CXX \
-    DICT \
-    DYNAMICROOT \
-    EXAMPLES \
-    FORTH \
-    FP_LIBC \
-    GAMES \
-    GCOV \
-    GDB \
-    GNU \
-    GPIB \
-    GROFF \
-    HTML \
-    INET6 \
-    INFO \
-    IPFILTER \
-    IPX \
-    KERBEROS \
-    LIB32 \
-    LIBPTHREAD \
-    LIBTHR \
-    LOCALES \
-    LPR \
-    MAILWRAPPER \
-    NETCAT \
-    NIS \
-    NLS \
-    NLS_CATALOGS \
-    NS_CACHING \
-    OBJC \
-    OPENSSH \
-    OPENSSL \
-    PAM \
-    PF \
-    RCMDS \
-    RCS \
-    RESCUE \
-    SENDMAIL \
-    SETUID_LOGIN \
-    SHAREDOCS \
-    SYSCONS \
-    TCSH \
-    TOOLCHAIN \
-    USB \
-    WPA_SUPPLICANT_EAPOL
-.if defined(NO_${var})
-#.warning NO_${var} is deprecated in favour of WITHOUT_${var}=
-WITHOUT_${var}=
-.endif
-.endfor
-.endif # !defined(BURN_BRIDGES)
-
-#
 # Older-style variables that enabled behaviour when set.
 #
 .if defined(YES_HESIOD)
Index: sys.mk
===================================================================
--- sys.mk	(revision 219789)
+++ sys.mk	(working copy)
@@ -369,5 +369,4 @@
 
 .endif
 
-.include <bsd.compat.mk>
 .include <bsd.cpu.mk>
Index: Makefile
===================================================================
--- Makefile	(revision 219789)
+++ Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 FILES=	bsd.README
 FILES+=	bsd.arch.inc.mk
-FILES+=	bsd.compat.mk bsd.cpu.mk bsd.dep.mk bsd.doc.mk bsd.dtrace.mk
+FILES+=	bsd.cpu.mk bsd.dep.mk bsd.doc.mk bsd.dtrace.mk
 FILES+=	bsd.endian.mk
 FILES+=	bsd.files.mk bsd.crunchgen.mk bsd.incs.mk bsd.info.mk bsd.init.mk
 FILES+=	bsd.kmod.mk
Index: bsd.init.mk
===================================================================
--- bsd.init.mk	(revision 219789)
+++ bsd.init.mk	(working copy)
@@ -9,7 +9,6 @@
 .if exists(${.CURDIR}/../Makefile.inc)
 .include "${.CURDIR}/../Makefile.inc"
 .endif
-.include <bsd.compat.mk>
 .include <bsd.own.mk>
 .MAIN: all
 .endif	# !target(__<bsd.init.mk>__)
Index: ObsoleteFiles.inc
===================================================================
--- ObsoleteFiles.inc	(revision 219789)
+++ ObsoleteFiles.inc	(working copy)
@@ -38,6 +38,9 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
+# ???????: remove old compatability options
+OLD_FILES+=share/mk/bsd.compat.mk
+
 # 20110224: sticky.8 -> sticky.7
 OLD_FILES+=usr/share/man/man8/sticky.8.gz
 # 20110220: new clang import which bumps version from 2.8 to 2.9


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->portmgr 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri May 13 22:47:58 UTC 2011 
Responsible-Changed-Why:  
exp-run request 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155738 
State-Changed-From-To: open->closed 
State-Changed-By: des 
State-Changed-When: Fri Jan 11 10:10:29 UTC 2013 
State-Changed-Why:  
Fixed in r245269 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155738 
>Unformatted:
