From nobody@FreeBSD.org  Mon Mar 21 00:36:08 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 037691065670
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Mar 2011 00:36:08 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id EA7DF8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Mar 2011 00:36:07 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2L0a7xB092757
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Mar 2011 00:36:07 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2L0a77U092756;
	Mon, 21 Mar 2011 00:36:07 GMT
	(envelope-from nobody)
Message-Id: <201103210036.p2L0a77U092756@red.freebsd.org>
Date: Mon, 21 Mar 2011 00:36:07 GMT
From: Eitan Adler <lists@eitanadler.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] reaper of the dead: remove OBJFORMAT variable in share/mk/sys.mk
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155737
>Category:       conf
>Synopsis:       [exp-run] [patch] reaper of the dead: remove OBJFORMAT variable in share/mk/sys.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 21 00:40:01 UTC 2011
>Closed-Date:    Sun Jun 23 20:35:12 UTC 2013
>Last-Modified:  Sun Jun 23 20:40:00 UTC 2013
>Originator:     Eitan Adler
>Release:        
>Organization:
>Environment:
>Description:
There appears to be a variable added by ru@ in r94940 that is no longer used by source or ports in share/mk/sys.mk
This patch removes said variable.

Filed under conf/ because it affects a .mk file. Feel free to re-categorize.
>How-To-Repeat:
 
>Fix:
Index: sys.mk
===================================================================
--- sys.mk      (revision 219789)
+++ sys.mk      (working copy)
@@ -360,10 +360,6 @@
 .SHELL: path=${__MAKE_SHELL}
 .endif
 
-# Default executable format
-# XXX hint for bsd.port.mk
-OBJFORMAT?=    elf
-
 # Toggle on warnings
 .WARN: dirsyntax
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->portmgr 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri May 13 22:50:48 UTC 2011 
Responsible-Changed-Why:  
exp-run request 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155737 
State-Changed-From-To: open->analyzed 
State-Changed-By: linimon 
State-Changed-When: Mon Aug 8 09:21:57 UTC 2011 
State-Changed-Why:  
take for -exp run. 


Responsible-Changed-From-To: portmgr->linimon 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Aug 8 09:21:57 UTC 2011 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=155737 
State-Changed-From-To: analyzed->open 
State-Changed-By: linimon 
State-Changed-When: Mon Aug 8 09:39:04 UTC 2011 
State-Changed-Why:  
oops, not set up to run this one right now, sorry. 


Responsible-Changed-From-To: linimon->portmgr 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Aug 8 09:39:04 UTC 2011 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=155737 
Responsible-Changed-From-To: portmgr->bdrewery 
Responsible-Changed-By: bdrewery 
Responsible-Changed-When: Sun Jun 16 09:25:55 CDT 2013 
Responsible-Changed-Why:  
Take for exp-run 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155737 
Responsible-Changed-From-To: bdrewery->eadler 
Responsible-Changed-By: bdrewery 
Responsible-Changed-When: Wed Jun 19 07:20:45 CDT 2013 
Responsible-Changed-Why:  
Back to eadler. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155737 

From: Bryan Drewery <bdrewery@FreeBSD.org>
To: bug-followup@FreeBSD.org, lists@eitanadler.com
Cc:  
Subject: Re: conf/155737: [exp-run] [patch] reaper of the dead: remove OBJFORMAT
 variable in share/mk/sys.mk
Date: Wed, 19 Jun 2013 07:20:08 -0500

 exp-run complete. This only breaks ftp/bsdftpd-ssl.
 
 Full log:
 http://pb2.nyi.freebsd.org/bulk/91i386-default-objformat/2013-06-17_20%3A26%3A18/logs/errors/bsdftpd-ssl-1.1.0_3.log
 
 Relevant failure during build:
 
 > "../port/bsd_prog.mk", line 80: Malformed conditional (${OBJFORMAT} == aout)
 > "../port/bsd_prog.mk", line 165: Malformed conditional (${OBJFORMAT} != aout || make(checkdpadd) || defined(NEED_LIBNAMES))
 > "../port/bsd_prog.mk", line 167: if-less endif
 > "Makefile", line 48: if-less endif
 > make: fatal errors encountered -- cannot continue
 > *** [do-build] Error code 1
 > 
 > Stop in /usr/ports/ftp/bsdftpd-ssl.
 
 
 
 
 
 -- 
 Regards,
 Bryan Drewery
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Sun Jun 23 20:35:11 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155737 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/155737: commit references a PR
Date: Sun, 23 Jun 2013 20:35:02 +0000 (UTC)

 Author: eadler
 Date: Sun Jun 23 20:34:54 2013
 New Revision: 252127
 URL: http://svnweb.freebsd.org/changeset/base/252127
 
 Log:
   Remove variable added by ru@ in r94940 that is no longer used by source or ports in share/mk/sys.mk
   
   PR:		conf/155737
   Reviewed by:	ed (two years ago!)
   Exp-Run by:	bdrewery
 
 Modified:
   head/share/mk/sys.mk
 
 Modified: head/share/mk/sys.mk
 ==============================================================================
 --- head/share/mk/sys.mk	Sun Jun 23 20:24:43 2013	(r252126)
 +++ head/share/mk/sys.mk	Sun Jun 23 20:34:54 2013	(r252127)
 @@ -332,10 +332,6 @@ SHELL=	${__MAKE_SHELL}
  .SHELL: path=${__MAKE_SHELL}
  .endif
  
 -# Default executable format
 -# XXX hint for bsd.port.mk
 -OBJFORMAT?=	elf
 -
  # Tell bmake to expand -V VAR by default
  .MAKE.EXPAND_VARIABLES= yes
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
