From nobody@FreeBSD.org  Thu Feb 24 15:51:24 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A37C9106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Feb 2011 15:51:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 92FC88FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Feb 2011 15:51:24 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p1OFpOHW053831
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Feb 2011 15:51:24 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p1OFpOFf053830;
	Thu, 24 Feb 2011 15:51:24 GMT
	(envelope-from nobody)
Message-Id: <201102241551.p1OFpOFf053830@red.freebsd.org>
Date: Thu, 24 Feb 2011 15:51:24 GMT
From: Helmut Schneider <jumper99@gmx.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: named(8): /etc/rc.d/named might set wrong pid file
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155006
>Category:       conf
>Synopsis:       [patch] named(8): /etc/rc.d/named might set wrong pid file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 24 16:00:19 UTC 2011
>Closed-Date:    Fri Jul 22 21:41:23 UTC 2011
>Last-Modified:  Fri Jul 22 21:41:23 UTC 2011
>Originator:     Helmut Schneider
>Release:        8.1-RELEASE-p2
>Organization:
>Environment:
>Description:
According to "man named 8" the default pid file is /var/run/named/named.pid. /etc/rc.d/named says:

pidfile="${named_pidfile:-/var/run/named/pid}"

There might be a reason for it but if not /etc/rc.d/named should state:

pidfile="${named_pidfile:-/var/run/named/${name}.pid}
>How-To-Repeat:

>Fix:
--- /etc/rc.d/named.org 2011-02-24 16:43:08.000000000 +0100
+++ /etc/rc.d/named     2011-02-24 16:43:37.000000000 +0100
@@ -279,7 +279,7 @@
 #
 required_dirs="$named_chrootdir"       # if it is set, it must exist

-pidfile="${named_pidfile:-/var/run/named/pid}"
+pidfile="${named_pidfile:-/var/run/named/${name}.pid}"
 named_confdir="${named_chrootdir}${named_conf%/*}"

 run_rc_command "$1"

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: jh 
Responsible-Changed-When: Wed Jun 8 14:37:04 UTC 2011 
Responsible-Changed-Why:  
Reclassify and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155006 
Responsible-Changed-From-To: freebsd-rc->dougb 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Sun Jul 17 03:50:19 UTC 2011 
Responsible-Changed-Why:  

I'll fix the man page 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155006 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/155006: commit references a PR
Date: Sun, 17 Jul 2011 04:09:09 +0000 (UTC)

 dougb       2011-07-17 04:08:59 UTC
 
   FreeBSD ports repository
 
   Modified files:
     dns/bind96           Makefile 
     dns/bind97           Makefile 
     dns/bind98           Makefile 
   Log:
   Fix the location of the default pid file in named.8
   
   Problem pointed out in the PR
   
   PR:             conf/155006
   Submitted by:   Helmut Schneider <jumper99@gmx.de>
   
   Revision  Changes    Path
   1.117     +1 -0      ports/dns/bind96/Makefile
   1.19      +1 -0      ports/dns/bind97/Makefile
   1.10      +1 -0      ports/dns/bind98/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: dougb 
State-Changed-When: Sun Jul 17 04:10:34 UTC 2011 
State-Changed-Why:  

I fixed the location in the ports, and patched src/usr.sbin/named/Makefile 
in r224122. 

The default path and file name have been the way they are in FreeBSD for 
a long time, so the appropriate solution is to fix the documentation, not 
to change the path. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155006 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/155006: commit references a PR
Date: Sun, 17 Jul 2011 04:10:21 +0000 (UTC)

 Author: dougb
 Date: Sun Jul 17 04:10:00 2011
 New Revision: 224122
 URL: http://svn.freebsd.org/changeset/base/224122
 
 Log:
   Fix the location of the default pid file in named.8
   
   Problem pointed out in the PR
   
   PR:		conf/155006
   Submitted by:	Helmut Schneider <jumper99@gmx.de>
 
 Modified:
   head/usr.sbin/named/Makefile
 
 Modified: head/usr.sbin/named/Makefile
 ==============================================================================
 --- head/usr.sbin/named/Makefile	Sun Jul 17 03:44:05 2011	(r224121)
 +++ head/usr.sbin/named/Makefile	Sun Jul 17 04:10:00 2011	(r224122)
 @@ -57,7 +57,8 @@ LDADD+=		${BIND_LDADD} ${CRYPTO_LDADD} $
  
  MAN=		named.8 lwresd.8 named.conf.5
  
 -MANFILTER=	sed -e "s@/etc/named\.conf@/etc/namedb/named.conf@g"
 +MANFILTER=	sed -e "s@/etc/named\.conf@/etc/namedb/named.conf@g" \
 +		-e "s@/var\/run\/named\/named.pid@/var/run/named/pid@"
  
  LINKS=		${BINDIR}/named ${BINDIR}/lwresd
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: dougb 
State-Changed-When: Fri Jul 22 21:41:00 UTC 2011 
State-Changed-Why:  

The change has been MFC'ed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155006 
>Unformatted:
