From walter.pelissero@iesy.net  Sun Aug  8 12:44:25 2010
Return-Path: <walter.pelissero@iesy.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CF35F106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Aug 2010 12:44:25 +0000 (UTC)
	(envelope-from walter.pelissero@iesy.net)
Received: from mail01.ish.de (mailout.ish.de [80.69.98.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 6258E8FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Aug 2010 12:44:24 +0000 (UTC)
Received: from [95.222.206.96] (account walter.pelissero@iesy.net HELO zaphod.home.lan)
  by mail-fe-02.mail01.ish.de (CommuniGate Pro SMTP 5.2.18)
  with ESMTPSA id 372405519 for FreeBSD-gnats-submit@freebsd.org; Sun, 08 Aug 2010 14:34:21 +0200
Received: from zaphod.home.lan (localhost [127.0.0.1])
	by zaphod.home.lan (8.14.4/8.14.4) with ESMTP id o78CVvYi012033
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 8 Aug 2010 14:31:57 +0200 (CEST)
	(envelope-from wcp@zaphod.home.lan)
Received: (from wcp@localhost)
	by zaphod.home.lan (8.14.4/8.14.4/Submit) id o78CVv9m012032;
	Sun, 8 Aug 2010 14:31:57 +0200 (CEST)
	(envelope-from wcp)
Message-Id: <201008081231.o78CVv9m012032@zaphod.home.lan>
Date: Sun, 8 Aug 2010 14:31:57 +0200 (CEST)
From: "Walter C. Pelissero" <walter.pelissero@iesy.net>
Reply-To: walter@pelissero.de
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: fstab and labels with whitespace
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         149424
>Category:       conf
>Synopsis:       [patch] fstab(5) and labels with whitespace
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 08 12:50:00 UTC 2010
>Closed-Date:    Wed Aug 18 13:26:11 UTC 2010
>Last-Modified:  Wed Aug 18 13:26:11 UTC 2010
>Originator:     Walter C. Pelissero
>Release:        FreeBSD 8.1-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD zaphod.home.lan 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #1: Tue Jul 13 22:21:06 CEST 2010 root@zaphod.home.lan:/usr/home/obj/usr/src/sys/TIGER-MP i386


	
>Description:
	/etc/fstab currently doesn't allow for whitespace anywhere but
	between fields (or in comments).  This makes impossible to use
	a label in place of a device name when mounting volumes
	containing whitespace in the name.  Take for instance CF or SD
	memory cards created by Nikon cameras: they are labelled
	"NIKON <model>", with a whitespace between NIKON and the model
	name.  Although it's still possible to mount the /dev/da*
	device, the label is arguably much more convenient.
>How-To-Repeat:

>Fix:

	The following patch modifies libc to allow for special
	characters in the first field of a fstab entry.  A single
	space can be written as \s, as in NIKON\sD300S, or \040, as in
	NIKON\040D300S.  Indeed, any octal escape sequence can be
	used, or sequences such as \t, \r, or \n.

	I'm afraid, this patch does not update fstab.5.


Index: fstab.c
===================================================================
RCS file: /repos/src/lib/libc/gen/fstab.c,v
retrieving revision 1.15.10.1
diff -u -r1.15.10.1 fstab.c
--- fstab.c	3 Aug 2009 08:13:06 -0000	1.15.10.1
+++ fstab.c	8 Aug 2010 11:51:02 -0000
@@ -106,6 +106,40 @@
 	_fs_fstab.fs_spec = buf;
 }
 
+#define isoctal(c) ((c) >= '0' && (c) <= '7')
+#define octdigit2int(c) ((c) - '0')
+
+static char *
+unescape (char *string)
+{
+	static char special[] = "s\\trn";
+	static char translation[] = " \\\t\r\n";
+	char *s, *d;
+
+	for (s = d = string; *s; ++s, ++d)
+	{
+		if (s[0] == '\\') {
+			char *p;
+
+			if ((p = strchr(special, s[1]))) {
+				*d = translation[p - special];
+				++s;
+			} else if (isoctal(s[1]) &&
+				   isoctal(s[2]) &&
+				   isoctal(s[3])) {
+				*d =	octdigit2int(s[1]) * 8 * 8 +
+					octdigit2int(s[2]) * 8 +
+					octdigit2int(s[3]);
+				s += 3;
+			} else
+				*d = *s;
+		} else
+			*d = *s;
+	}
+	*d = '\0';
+	return string;
+}
+
 static int
 fstabscan()
 {
@@ -148,7 +182,7 @@
 /* OLD_STYLE_FSTAB */
 		while ((cp = strsep(&p, " \t\n")) != NULL && *cp == '\0')
 			;
-		_fs_fstab.fs_spec = cp;
+		_fs_fstab.fs_spec = unescape(cp);
 		if (!_fs_fstab.fs_spec || *_fs_fstab.fs_spec == '#')
 			continue;
 		while ((cp = strsep(&p, " \t\n")) != NULL && *cp == '\0')
>Release-Note:
>Audit-Trail:

From: Jaakko Heinonen <jh@FreeBSD.org>
To: bug-followup@FreeBSD.org, walter@pelissero.de
Cc:  
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Mon, 16 Aug 2010 18:00:31 +0300

 On 2010-08-08, Walter C. Pelissero wrote:
 > 	/etc/fstab currently doesn't allow for whitespace anywhere but
 > 	between fields (or in comments).  This makes impossible to use
 > 	a label in place of a device name when mounting volumes
 > 	containing whitespace in the name.
 
 This is duplicate of conf/37569, bin/55539 and bin/117687.
 
 -- 
 Jaakko

From: walter@pelissero.de (Walter C. Pelissero)
To: Jaakko Heinonen <jh@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, walter@pelissero.de
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Mon, 16 Aug 2010 19:40:46 +0200

 Jaakko Heinonen writes:
  > On 2010-08-08, Walter C. Pelissero wrote:
  > > 	/etc/fstab currently doesn't allow for whitespace anywhere but
  > > 	between fields (or in comments).  This makes impossible to use
  > > 	a label in place of a device name when mounting volumes
  > > 	containing whitespace in the name.
  > 
  > This is duplicate of conf/37569, bin/55539 and bin/117687.
 
 Wow.  Some date back 7-8 years.  At this pace I'm not sure I'll be
 seeing the end of it, so I hope my new born son will get some interest
 in FreeBSD one day and follow up on it.
 
 -- 
 walter pelissero
 http://www.pelissero.de

From: Oliver Fromme <olli@lurza.secnetix.de>
To: freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG, walter@pelissero.de
Cc:  
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Tue, 17 Aug 2010 14:47:46 +0200 (CEST)

 Walter C. Pelissero <walter.pelissero@iesy.net> wrote:
  > > Number:         149424
  > > Category:       bin
  > > Synopsis:       fstab and labels with whitespace
  > [...]
  > > Description:
  >         /etc/fstab currently doesn't allow for whitespace anywhere but
  >         between fields (or in comments).  This makes impossible to use
  >         a label in place of a device name when mounting volumes
  >         containing whitespace in the name.  Take for instance CF or SD
  >         memory cards created by Nikon cameras: they are labelled
  >         "NIKON <model>", with a whitespace between NIKON and the model
  >         name.  Although it's still possible to mount the /dev/da*
  >         device, the label is arguably much more convenient.
  > > How-To-Repeat:
  > 
  > > Fix:
  > 
  >         The following patch modifies libc to allow for special
  >         characters in the first field of a fstab entry.  A single
  >         space can be written as \s, as in NIKON\sD300S, or \040, as in
  >         NIKON\040D300S.  Indeed, any octal escape sequence can be
  >         used, or sequences such as \t, \r, or \n.
 
 The problem with this patch is that it breaks backwards-
 compatibility.  Some people might already use backslashes
 in /etc/fstab, for whatever reason.  This change would
 make them rather unhappy, I'm afraid.
 
 One way to circumvent the problem would be to use glabel(8)
 which should also work with memory cards that contain FAT
 file systems.  You just have to make sure that you don't
 format the card with the camera -- If you accidentally do
 that, you need to recreate the label.
 
 Best regards
    Oliver
 
 -- 
 Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
 Handelsregister: Registergericht Muenchen, HRA 74606,  Geschftsfuehrung:
 secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mn-
 chen, HRB 125758,  Geschftsfhrer: Maik Bachmann, Olaf Erb, Ralf Gebhart
 
 FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd
 
 I suggested holding a "Python Object Oriented Programming Seminar",
 but the acronym was unpopular.
         -- Joseph Strout

From: walter@pelissero.de (Walter C. Pelissero)
To: Oliver Fromme <olli@lurza.secnetix.de>
Cc: freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Tue, 17 Aug 2010 15:09:23 +0200

 Oliver Fromme writes:
  > The problem with this patch is that it breaks backwards-
  > compatibility.  Some people might already use backslashes
 
 As far as I remember, the patch I proposed allowed a double backslash
 ('\\') to mean a single backslash ('\').
 
  > in /etc/fstab, for whatever reason.  This change would
  > make them rather unhappy, I'm afraid.
 
 Being unhappy for having to change a couple of entries in fstab is not
 nearly as bad as not being able to insert an entry altogether.
 
  > One way to circumvent the problem would be to use glabel(8)
 
 Yes, or mlabel(1).  Although reformatting (and, thus, relabelling) is
 common on devices such as digital camera; it saves time compared to
 deleting everything.
 
 -- 
 walter pelissero
 http://www.pelissero.de

From: Oliver Fromme <olli@lurza.secnetix.de>
To: walter@pelissero.de
Cc: freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Tue, 17 Aug 2010 15:27:31 +0200 (CEST)

 Walter C. Pelissero wrote:
  > Oliver Fromme writes:
  > > The problem with this patch is that it breaks backwards-
  > > compatibility.  Some people might already use backslashes
  > 
  > As far as I remember, the patch I proposed allowed a double backslash
  > ('\\') to mean a single backslash ('\').
 
 Sure, but still everyone who uses backslashes will have to
 change his /etc/fstab *in advance*, or otherwise his box
 will not boot after the update.  Changing the syntax of
 /etc/fstab is a very delicate issue.
 
 Of course, it would be possible to change the syntax in a
 backwards-compatible way.  But this would require more code
 and would potentially introduce more complications.
 
  > > in /etc/fstab, for whatever reason.  This change would
  > > make them rather unhappy, I'm afraid.
  > 
  > Being unhappy for having to change a couple of entries in fstab is not
  > nearly as bad as not being able to insert an entry altogether.
 
 As I wrote, there are several workarounds.
 
  > > One way to circumvent the problem would be to use glabel(8)
  > 
  > Yes, or mlabel(1).  Although reformatting (and, thus, relabelling) is
  > common on devices such as digital camera; it saves time compared to
  > deleting everything.
 
 Well ...  I always format my camera's memory card under
 FreeBSD after I have downloaded all images from it (which
 requires connecting to the FreeBSD machine anyway).
 
 I cannot format the card with the camera anyway because
 that wouldn't work with my CHDK firmware.  :)
 
 Best regards
    Oliver
 
 -- 
 Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
 Handelsregister: Registergericht Muenchen, HRA 74606,  Geschftsfuehrung:
 secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mn-
 chen, HRB 125758,  Geschftsfhrer: Maik Bachmann, Olaf Erb, Ralf Gebhart
 
 FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd
 
 With Perl you can manipulate text, interact with programs, talk over
 networks, drive Web pages, perform arbitrary precision arithmetic,
 and write programs that look like Snoopy swearing.

From: walter@pelissero.de (Walter C. Pelissero)
To: Oliver Fromme <olli@lurza.secnetix.de>
Cc: freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Tue, 17 Aug 2010 16:21:58 +0200

 Oliver Fromme writes:
  > Walter C. Pelissero wrote:
  >  > Oliver Fromme writes:
  >  > > The problem with this patch is that it breaks backwards-
  >  > > compatibility.  Some people might already use backslashes
  >  > 
  >  > As far as I remember, the patch I proposed allowed a double backslash
  >  > ('\\') to mean a single backslash ('\').
  > 
  > Sure, but still everyone who uses backslashes will have to
  > change his /etc/fstab *in advance*, or otherwise his box
  > will not boot after the update.
 
 It seems to be unlikely there are systems out there relying on a
 boot-time mounted filesystem whose device path (or label) contains a
 backslash.  Certainly not a great deal of those.
 
 Maybe you care to give us some concrete example.  Who knows, there
 could be a BSD distribution, that I failed to notice, with a really
 bizarre naming convention for the device drivers.
 
  > Changing the syntax of /etc/fstab is a very delicate issue.
 
 Acute observation, indeed.
 
  > Of course, it would be possible to change the syntax in a
  > backwards-compatible way.  But this would require more code
  > and would potentially introduce more complications.
 
 Maybe you should leave alone the generic considerations of
 circumstance and write some code yourself.
 
 In the past 8 years there have been three different proposals and
 concrete implementations.  You could add your own.  So we would at
 least know what you mean with "backwards-compatible way".
 
 
  >  > > in /etc/fstab, for whatever reason.  This change would
  >  > > make them rather unhappy, I'm afraid.
  >  > 
  >  > Being unhappy for having to change a couple of entries in fstab is not
  >  > nearly as bad as not being able to insert an entry altogether.
  > 
  > As I wrote, there are several workarounds.
 
 Then, why do you write it again?
 
 -- 
 walter pelissero
 http://www.pelissero.de

From: Oliver Fromme <olli@lurza.secnetix.de>
To: walter@pelissero.de
Cc: freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Tue, 17 Aug 2010 17:06:26 +0200 (CEST)

 Walter C. Pelissero wrote:
  > Oliver Fromme writes:
  > > Sure, but still everyone who uses backslashes will have to
  > > change his /etc/fstab *in advance*, or otherwise his box
  > > will not boot after the update.
  > 
  > It seems to be unlikely there are systems out there relying on a
  > boot-time mounted filesystem whose device path (or label) contains a
  > backslash.  Certainly not a great deal of those.
  > 
  > Maybe you care to give us some concrete example.  Who knows, there
  > could be a BSD distribution, that I failed to notice, with a really
  > bizarre naming convention for the device drivers.
 
 What prevents you from labelling a disk 'backup\500GB'?
 In fact I *do* sometimes use backslashes in file names when
 I would ordinarily use a forward slash, but of course forward
 slashes are not allowed in file names.
 
  > > Of course, it would be possible to change the syntax in a
  > > backwards-compatible way.  But this would require more code
  > > and would potentially introduce more complications.
  > 
  > Maybe you should leave alone the generic considerations of
  > circumstance and write some code yourself.
  > 
  > In the past 8 years there have been three different proposals and
  > concrete implementations.  You could add your own.  So we would at
  > least know what you mean with "backwards-compatible way".
 
 In the past 16 years (maybe longer; I checked only the FreeBSD
 repository) nobody dared to change the syntax of /etc/fstab.
 I'm not going to open this can of worms.
 
  > > > > in /etc/fstab, for whatever reason.  This change would
  > > > > make them rather unhappy, I'm afraid.
  > > > 
  > > > Being unhappy for having to change a couple of entries in fstab is not
  > > > nearly as bad as not being able to insert an entry altogether.
  > > 
  > > As I wrote, there are several workarounds.
  > 
  > Then, why do you write it again?
 
 Because it seemed that you missed it, because "not being able
 to insert an entry altogether" is untrue, given the fact that
 workarounds exist.
 
 Breaking existing configurations (possibly leaving people
 with unbootable remote machines!) is certainly worse than
 requiring some people to use workarounds for an optional
 feature.  Of course, the case would be completely different
 if you weren't able to mount those file systems at all.
 
 And finally, the patch presented in this PR fails to update
 all places that handle /etc/fstab.  For example, it breaks
 /etc/rc.d/gbde, /etc/rc.d/jail and "mount -p".  Those are
 just three things from the top of my head; there are probably
 more.  Not to mention any third-party software that might try
 to parse that file.
 
 If you want to change the syntax of /etc/fstab, *all* of the
 above needs to be adapted.
 
 Best regards
    Oliver
 
 -- 
 Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
 Handelsregister: Registergericht Muenchen, HRA 74606,  Geschftsfuehrung:
 secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mn-
 chen, HRB 125758,  Geschftsfhrer: Maik Bachmann, Olaf Erb, Ralf Gebhart
 
 FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd
 
 "If you think C++ is not overly complicated, just what is a protected
 abstract virtual base pure virtual private destructor, and when was the
 last time you needed one?"
         -- Tom Cargil, C++ Journal

From: walter@pelissero.de (Walter C. Pelissero)
To: Oliver Fromme <olli@lurza.secnetix.de>
Cc: freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Tue, 17 Aug 2010 20:49:31 +0200

 Oliver Fromme writes:
  > Walter C. Pelissero wrote:
  >  > Oliver Fromme writes:
  >  > > Sure, but still everyone who uses backslashes will have to
  >  > > change his /etc/fstab *in advance*, or otherwise his box
  >  > > will not boot after the update.
  >  > 
  >  > It seems to be unlikely there are systems out there relying on a
  >  > boot-time mounted filesystem whose device path (or label) contains a
  >  > backslash.  Certainly not a great deal of those.
  >  > 
  >  > Maybe you care to give us some concrete example.  Who knows, there
  >  > could be a BSD distribution, that I failed to notice, with a really
  >  > bizarre naming convention for the device drivers.
  > 
  > What prevents you from labelling a disk 'backup\500GB'?
 
 Besides some remorse about the uninspired name, nothing keeps you from
 that.  Are you also going to boot from that volume?  Because that is
 what you were arguing just before.  So, if you aren't, your argument
 about rendering systems unbootable is moot.
 
 BTW, that was the meaning of:
   It seems to be unlikely there are systems out there relying on a
   boot-time mounted filesystem whose device path (or label) contains a
   backslash.  Certainly not a great deal of those."
 
 
  > In the past 16 years (maybe longer; I checked only the FreeBSD
  > repository) nobody dared to change the syntax of /etc/fstab.  I'm
  > not going to open this can of worms.
 
 Are you the person responsible for that code?
 
 
  >  > > > > in /etc/fstab, for whatever reason.  This change would
  >  > > > > make them rather unhappy, I'm afraid.
  >  > > > 
  >  > > > Being unhappy for having to change a couple of entries in fstab is not
  >  > > > nearly as bad as not being able to insert an entry altogether.
  >  > > 
  >  > > As I wrote, there are several workarounds.
  >  > 
  >  > Then, why do you write it again?
  > 
  > Because it seemed that you missed it,
 
 Did I?
  
 
  > Breaking existing configurations (possibly leaving people
  > with unbootable remote machines!)
 
 Right: machines that boot from backup\500GB, aren't they?
 
 
  > is certainly worse than requiring some people to use workarounds
  > for an optional feature.
 
 Booting from backup\500GB sounds pretty "optional feature" to me.
 
 
  > And finally, the patch presented in this PR fails to update all
  > places that handle /etc/fstab.  For example, it breaks
  > /etc/rc.d/gbde, /etc/rc.d/jail and "mount -p".
 
 Neither /etc/rc.d/gbde nor /etc/rc.d/jail is broken by my patch.  (As
 far as I can tell, there is not even use for the device name in
 /etc/rc.d/jail.)  It would, on the other hand, interfere with your ill
 named USB disk if that were encrypted with GBDE (a still experimental
 feature).
 
 
  > Those are just three things from the top of my head; there are
  > probably more.
 
 There must be aplenty, if in 8 years nobody hasn't been able to even
 enumerate them.
 
 
  > Not to mention any third-party software that might try to parse
  > that file.
 
 Parsing is not hindered by my patch.  Programs that use libc to read
 fstab don't have problems.  Those that use some home brewed parser are
 still able to parse fstab without problems, because the syntax is
 backward compatible.  They simply don't get the right value for those
 device entries that employ backslashes.
 
 In other words, you are in trouble if you intend to use
 some\funny\device in your third-party software that doesn't use libc
 to parse fstab.
 
 
  > If you want to change the syntax of /etc/fstab, *all* of the above
  > needs to be adapted.
 
 That patch changes libc.  Where else more central or appropriate did
 you have in mind?
 
 /sbin/mount, for -p to work, would require an equally trivial patch.
 So would some other program, I suppose.  Hardly a tin of
 invertebrates, and nothing that cannot be discovered by trial-and-
 error.
 
 If you meant to say: "either you mend all FreeBSD boot chain or your
 patch is not enough"; well, I'm still waiting to see your code.
 Or the others of your "several" workarounds.
 I've seen one this far.
 (Yes, I didn't miss it.)
 
 
 -- 
 walter pelissero
 http://www.pelissero.de

From: Oliver Fromme <olli@lurza.secnetix.de>
To: walter@pelissero.de
Cc: freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Tue, 17 Aug 2010 22:34:14 +0200 (CEST)

 Walter C. Pelissero wrote:
  > Oliver Fromme writes:
  > > What prevents you from labelling a disk 'backup\500GB'?
  > 
  > Besides some remorse about the uninspired name, nothing keeps you from
  > that.  Are you also going to boot from that volume?  Because that is
  > what you were arguing just before.  So, if you aren't, your argument
  > about rendering systems unbootable is moot.
 
 You don't have to "boot from it".  It's sufficient to have
 an entry in /etc/fstab that doesn't have "noauto" or "xx".
 
 I do have a /backup entry in /etc/fstab on one of my boxes
 that uses a label for mounting.  This particular one does
 not have backslash in it, but it could well have one.  (Why
 not?  A backslash is not special in file names.)  And *if*
 it had one, then that box would *not* boot anymore with
 the patch in this PR applied.
 
 If you don't believe that, I suggest you try it.  I'm not
 going to reply to the rest of your statements which seem
 to be based on wrong assumptions.
 
 Best regards
    Oliver
 
 -- 
 Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
 Handelsregister: Registergericht Muenchen, HRA 74606,  Geschftsfuehrung:
 secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mn-
 chen, HRB 125758,  Geschftsfhrer: Maik Bachmann, Olaf Erb, Ralf Gebhart
 
 FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd

From: walter@pelissero.de (Walter C. Pelissero)
To: Oliver Fromme <olli@lurza.secnetix.de>
Cc: freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG
Subject: Re: bin/149424: fstab and labels with whitespace
Date: Wed, 18 Aug 2010 10:35:27 +0200

 Oliver Fromme writes:
  > Walter C. Pelissero wrote:
  >  > Oliver Fromme writes:
  >  > > What prevents you from labelling a disk 'backup\500GB'?
  >  > 
  >  > Besides some remorse about the uninspired name, nothing keeps you from
  >  > that.  Are you also going to boot from that volume?  Because that is
  >  > what you were arguing just before.  So, if you aren't, your argument
  >  > about rendering systems unbootable is moot.
  > 
  > You don't have to "boot from it".  It's sufficient to have
  > an entry in /etc/fstab that doesn't have "noauto" or "xx".
 
 which is implied by:
  "It seems to be unlikely there are systems out there relying on a
   boot-time mounted filesystem whose device path (or label) contains a
   backslash.  Certainly not a great deal of those."
 
 therefore: after the patch the vast majority will still be able to
 boot without problems, mend their fstab, if they need to, and proceed
 with their normal life.
 
 Anyhow, thank you again for your acute contribution.
 
 
  > If you don't believe that, I suggest you try it.  I'm not
  > going to reply to the rest of your statements which seem
  > to be based on wrong assumptions.
 
 Is the Oktoberfest already on?
 
 The only wrong assumption is that you might be sober one day.
 
 -- 
 walter pelissero
 http://www.pelissero.de
State-Changed-From-To: open->closed 
State-Changed-By: remko 
State-Changed-When: Wed Aug 18 13:26:10 UTC 2010 
State-Changed-Why:  
Unless you properly fit yourself in the community I am not even willing 
to look into your issue. Goodbye. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149424 
>Unformatted:
