From nobody@FreeBSD.org  Thu Mar 18 01:51:59 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 06855106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Mar 2010 01:51:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id E9D278FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Mar 2010 01:51:58 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2I1pwEo023271
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Mar 2010 01:51:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o2I1pwSA023270;
	Thu, 18 Mar 2010 01:51:58 GMT
	(envelope-from nobody)
Message-Id: <201003180151.o2I1pwSA023270@www.freebsd.org>
Date: Thu, 18 Mar 2010 01:51:58 GMT
From: Phil Pennock <freebsd-bugs@spodhuis.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ipv6_default_interface causes route complaints from -cloning
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         144842
>Category:       conf
>Synopsis:       [ip6] ipv6_default_interface causes route complaints from -cloning
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hrs
>State:          patched
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 18 02:00:09 UTC 2010
>Closed-Date:    
>Last-Modified:  Tue Mar 01 10:15:39 EST 2011
>Originator:     Phil Pennock
>Release:        FreeBSD 8.0-RELEASE
>Organization:
>Environment:
FreeBSD shade.field.spodhuis.org 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Sat Nov 21 15:02:08 UTC 2009     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
In /etc/rc.conf set:
  ipv6_default_interface="ed0"

See error messages on boot because route(8) no longer supports the -cloning flag and network.subr network6_default_interface_setup() has not been updated to reflect this.

route: bad keyword: cloning
usage: route [-dnqtv] command [[modifiers] args]

The man-page for route(8) still documents -cloning.
>How-To-Repeat:
Install FreeBSD 8.0, try to set a default interface for link-local traffic (such as pinging ff02::2) per /etc/defaults/rc.conf and previous experience on FreeBSD 7.
>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->hrs 
Responsible-Changed-By: hrs 
Responsible-Changed-When: Thu Mar 18 02:03:46 UTC 2010 
Responsible-Changed-Why:  
I'll handle this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144842 

From: Thomas Sandford <freebsduser@paradisegreen.co.uk>
To: bug-followup@FreeBSD.org, freebsd-bugs@spodhuis.org
Cc:  
Subject: Re: conf/144842: [ip6] ipv6_default_interface causes route complaints
 from -cloning
Date: Mon, 04 Oct 2010 16:36:41 +0100

 Any feedback on this issue?
 
 I can confirm that the bug is still present in FreeBSD 8.1-RELEASE
 i) error message still observed on boot
 ii) route(8) manpage still references the cloning keyword

From: Thomas Sandford <freebsduser@paradisegreen.co.uk>
To: bug-followup@FreeBSD.org, freebsd-bugs@spodhuis.org
Cc:  
Subject: Re: conf/144842: [ip6] ipv6_default_interface causes route complaints
 from -cloning
Date: Tue, 05 Oct 2010 15:11:59 +0100

 Following some research on the corresponding code in -current:
 
 (equivalent code in current is
 http://svn.freebsd.org/viewvc/base/head/etc/rc.d/routing?revision=197719&view=markup
 line 223)
 
 simply dropping the -cloning option to the route command would appear to 
 be sufficient.
 
 (Unfortunately the networking scripts have diverged considerably between 
 8-stable and -current so there doesn't look to be a simple/sensible MFC 
 to resolve this issue).
 
 NB this bug is a duplicate of conf/139255 so a fix would close both.

From: Thomas Sandford <freebsduser@paradisegreen.co.uk>
To: bug-followup@FreeBSD.org, freebsd-bugs@spodhuis.org
Cc:  
Subject: Re: conf/144842: [ip6] ipv6_default_interface causes route complaints
 from -cloning
Date: Tue, 05 Oct 2010 15:53:58 +0100

 This is a multi-part message in MIME format.
 --------------070209010103060207000704
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Patch attached.
 
 Man page issue can be resolved by a MFC of r196833
 
 
 
 --------------070209010103060207000704
 Content-Type: text/plain;
  name="patch.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="patch.diff"
 
 Index: network.subr
 ===================================================================
 --- network.subr	(revision 213450)
 +++ network.subr	(working copy)
 @@ -1134,8 +1134,7 @@
  		;;
  	*)
  		laddr=`network6_getladdr ${ipv6_default_interface}`
 -		route add -inet6 ff02:: ${laddr} -prefixlen 16 -interface \
 -			-cloning
 +		route add -inet6 ff02:: ${laddr} -prefixlen 16 -interface
  
  		# Disable installing the default interface with the
  		# case net.inet6.ip6.forwarding=0 and
 
 --------------070209010103060207000704--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/144842: commit references a PR
Date: Mon, 27 Dec 2010 16:01:45 +0000 (UTC)

 Author: hrs
 Date: Mon Dec 27 16:01:39 2010
 New Revision: 216739
 URL: http://svn.freebsd.org/changeset/base/216739
 
 Log:
   - route(8) manual page update: no longer supports RTF_CLONING and
     RTF_LLINFO (MFC from r196833)
   
   - Remove -cloning flag from network.subr[*]
   
   PR:		conf/144842 [*]
   Approved by:	re (bz)
 
 Modified:
   stable/8/etc/network.subr
   stable/8/sbin/route/route.8
 Directory Properties:
   stable/8/sbin/route/   (props changed)
 
 Modified: stable/8/etc/network.subr
 ==============================================================================
 --- stable/8/etc/network.subr	Mon Dec 27 15:57:41 2010	(r216738)
 +++ stable/8/etc/network.subr	Mon Dec 27 16:01:39 2010	(r216739)
 @@ -1134,8 +1134,7 @@ network6_default_interface_setup()
  		;;
  	*)
  		laddr=`network6_getladdr ${ipv6_default_interface}`
 -		route add -inet6 ff02:: ${laddr} -prefixlen 16 -interface \
 -			-cloning
 +		route add -inet6 ff02:: ${laddr} -prefixlen 16 -interface
  
  		# Disable installing the default interface with the
  		# case net.inet6.ip6.forwarding=0 and
 
 Modified: stable/8/sbin/route/route.8
 ==============================================================================
 --- stable/8/sbin/route/route.8	Mon Dec 27 15:57:41 2010	(r216738)
 +++ stable/8/sbin/route/route.8	Mon Dec 27 16:01:39 2010	(r216739)
 @@ -28,7 +28,7 @@
  .\"     @(#)route.8	8.3 (Berkeley) 3/19/94
  .\" $FreeBSD$
  .\"
 -.Dd October 2, 2005
 +.Dd December 17, 2010
  .Dt ROUTE 8
  .Os
  .Sh NAME
 @@ -279,7 +279,6 @@ when sending to destinations matched by 
  These flags may be set (or sometimes cleared)
  by indicating the following corresponding modifiers:
  .Bd -literal
 --cloning   RTF_CLONING    - generates a new route on use
  -xresolve  RTF_XRESOLVE   - emit mesg on use (for external lookup)
  -iface    ~RTF_GATEWAY    - destination is directly reachable
  -static    RTF_STATIC     - manually added route
 @@ -288,7 +287,6 @@ by indicating the following correspondin
  -blackhole RTF_BLACKHOLE  - silently discard pkts (during updates)
  -proto1    RTF_PROTO1     - set protocol specific routing flag #1
  -proto2    RTF_PROTO2     - set protocol specific routing flag #2
 --llinfo    RTF_LLINFO     - validly translates proto addr to link addr
  .Ed
  .Pp
  The optional modifiers
 @@ -326,25 +324,6 @@ or
  .Fl ifa
  modifiers may be used to determine the interface or interface address.
  .Pp
 -The optional
 -.Fl proxy
 -modifier specifies that the
 -.Dv RTF_LLINFO
 -routing table entry is the
 -.Dq published (proxy-only)
 -.Tn ARP
 -entry, as reported by
 -.Xr arp 8 .
 -.Pp
 -The optional
 -.Fl genmask
 -modifier specifies that a cloning mask is present.
 -This specifies the mask applied when determining if a child route
 -should be created.
 -It is only applicable to network routes with the
 -.Dv RTF_CLONING
 -flag set.
 -.Pp
  All symbolic names specified for a
  .Ar destination
  or
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/144842: commit references a PR
Date: Mon, 27 Dec 2010 16:02:20 +0000 (UTC)

 Author: hrs
 Date: Mon Dec 27 16:02:14 2010
 New Revision: 216740
 URL: http://svn.freebsd.org/changeset/base/216740
 
 Log:
   - route(8) manual page update: no longer supports RTF_CLONING and
     RTF_LLINFO (MFC from r196833)
   
   - Remove -cloning flag from network.subr[*]
   
   PR:		conf/144842 [*]
   Approved by:	re (bz)
 
 Modified:
   releng/8.2/etc/network.subr
   releng/8.2/sbin/route/route.8
 Directory Properties:
   releng/8.2/sbin/route/   (props changed)
 
 Modified: releng/8.2/etc/network.subr
 ==============================================================================
 --- releng/8.2/etc/network.subr	Mon Dec 27 16:01:39 2010	(r216739)
 +++ releng/8.2/etc/network.subr	Mon Dec 27 16:02:14 2010	(r216740)
 @@ -1134,8 +1134,7 @@ network6_default_interface_setup()
  		;;
  	*)
  		laddr=`network6_getladdr ${ipv6_default_interface}`
 -		route add -inet6 ff02:: ${laddr} -prefixlen 16 -interface \
 -			-cloning
 +		route add -inet6 ff02:: ${laddr} -prefixlen 16 -interface
  
  		# Disable installing the default interface with the
  		# case net.inet6.ip6.forwarding=0 and
 
 Modified: releng/8.2/sbin/route/route.8
 ==============================================================================
 --- releng/8.2/sbin/route/route.8	Mon Dec 27 16:01:39 2010	(r216739)
 +++ releng/8.2/sbin/route/route.8	Mon Dec 27 16:02:14 2010	(r216740)
 @@ -279,7 +279,6 @@ when sending to destinations matched by 
  These flags may be set (or sometimes cleared)
  by indicating the following corresponding modifiers:
  .Bd -literal
 --cloning   RTF_CLONING    - generates a new route on use
  -xresolve  RTF_XRESOLVE   - emit mesg on use (for external lookup)
  -iface    ~RTF_GATEWAY    - destination is directly reachable
  -static    RTF_STATIC     - manually added route
 @@ -288,7 +287,6 @@ by indicating the following correspondin
  -blackhole RTF_BLACKHOLE  - silently discard pkts (during updates)
  -proto1    RTF_PROTO1     - set protocol specific routing flag #1
  -proto2    RTF_PROTO2     - set protocol specific routing flag #2
 --llinfo    RTF_LLINFO     - validly translates proto addr to link addr
  .Ed
  .Pp
  The optional modifiers
 @@ -326,25 +324,6 @@ or
  .Fl ifa
  modifiers may be used to determine the interface or interface address.
  .Pp
 -The optional
 -.Fl proxy
 -modifier specifies that the
 -.Dv RTF_LLINFO
 -routing table entry is the
 -.Dq published (proxy-only)
 -.Tn ARP
 -entry, as reported by
 -.Xr arp 8 .
 -.Pp
 -The optional
 -.Fl genmask
 -modifier specifies that a cloning mask is present.
 -This specifies the mask applied when determining if a child route
 -should be created.
 -It is only applicable to network routes with the
 -.Dv RTF_CLONING
 -flag set.
 -.Pp
  All symbolic names specified for a
  .Ar destination
  or
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Tue Mar 1 10:15:38 EST 2011 
State-Changed-Why:  
committed in head (r216739) and stable (216740) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144842 
>Unformatted:
