From nobody@FreeBSD.org  Wed Nov 18 01:54:50 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9B8BC106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Nov 2009 01:54:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 8A4A88FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Nov 2009 01:54:50 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nAI1sob3045505
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Nov 2009 01:54:50 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nAI1so03045487;
	Wed, 18 Nov 2009 01:54:50 GMT
	(envelope-from nobody)
Message-Id: <200911180154.nAI1so03045487@www.freebsd.org>
Date: Wed, 18 Nov 2009 01:54:50 GMT
From: Ben Kelly <ben@wanderview.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: WITHOUT_MODULES cannot be used from kernel config with makeoptions
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         140650
>Category:       conf
>Synopsis:       [build] [patch] WITHOUT_MODULES cannot be used from kernel config with makeoptions
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    cperciva
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 18 02:00:02 UTC 2009
>Closed-Date:    Mon May 07 22:43:06 UTC 2012
>Last-Modified:  Mon May 07 22:43:06 UTC 2012
>Originator:     Ben Kelly
>Release:        CURRENT
>Organization:
>Environment:
FreeBSD ianto.in.wanderview.com 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r254M: Fri Nov 13 23:26:25 UTC 2009     root@ianto.in.wanderview.com:/usr/obj/usr/src/sys/SERVER  i386

>Description:
Currently you can only specify WITHOUT_MODULES in /etc/make.conf.  This
is unintuitive since the related variable MODULES_OVERRIDE is often used
from kernel config files.  The attached patch fixes this problem for me.
>How-To-Repeat:

>Fix:
Index: sys/conf/kern.pre.mk
===================================================================
--- sys/conf/kern.pre.mk        (revision 254)
+++ sys/conf/kern.pre.mk        (working copy)
@@ -163,6 +163,9 @@
.if defined(MODULES_OVERRIDE)
MKMODULESENV+= MODULES_OVERRIDE="${MODULES_OVERRIDE}"
.endif
+.if defined(WITHOUT_MODULES)
+MKMODULESENV+= WITHOUT_MODULES="${WITHOUT_MODULES}"
+.endif
.if defined(DEBUG)
MKMODULESENV+= DEBUG_FLAGS="${DEBUG}"
.endif

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: pluknet 
State-Changed-When: Tue Feb 22 16:10:35 UTC 2011 
State-Changed-Why:  
Patched in HEAD (r216746). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140650 
Responsible-Changed-From-To: freebsd-bugs->cperciva 
Responsible-Changed-By: pluknet 
Responsible-Changed-When: Tue Feb 22 16:12:17 UTC 2011 
Responsible-Changed-Why:  
Over to committer as MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140650 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Mon May 7 22:43:05 UTC 2012 
State-Changed-Why:  
MFCed a long time ago (or head has become stable) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140650 
>Unformatted:
