From nobody@FreeBSD.org  Thu Aug  6 04:53:58 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B6C63106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Aug 2009 04:53:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A48198FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Aug 2009 04:53:58 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n764rwxm057227
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 6 Aug 2009 04:53:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n764rw3H057214;
	Thu, 6 Aug 2009 04:53:58 GMT
	(envelope-from nobody)
Message-Id: <200908060453.n764rw3H057214@www.freebsd.org>
Date: Thu, 6 Aug 2009 04:53:58 GMT
From: Mohd Izhar Firdaus Ismail <kagesenshi.87@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameters for _mdconfig2_list over the value in rc.conf
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         137470
>Category:       conf
>Synopsis:       [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameters for _mdconfig2_list over the value in rc.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-rc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 06 05:00:14 UTC 2009
>Closed-Date:    Thu Nov 01 19:42:13 UTC 2012
>Last-Modified:  Thu Nov 01 19:42:13 UTC 2012
>Originator:     Mohd Izhar Firdaus Ismail
>Release:        7.2-RELEASE
>Organization:
Inigo Consulting Sdn Bhd
>Environment:
FreeBSD hulk.inigo-tech.com 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Tue May 19 19:59:44 MYT 2009     kaeru@hulk.inigo-tech.com:/usr/obj/usr/src/sys/HULK  amd64
>Description:
when _mdconfig2_list is specified in rc.conf, `/etc/rc.d/mdconfig2 start` ignored parameters passed to it (which supposed to be stored in _mdconfig2_list variable afterward).




>How-To-Repeat:
create 2 image files, and configure them to be automatically mounted by mdconfig2

add in rc.conf:
_mdconfig2_list="md5"
mdconfig_md5=" -t vnode -f /img/image.img"
mdconfig_md6=" -t vnode -f /img/image2.img"

add in fstab:
/dev/md5                /mnt/image       ufs     rw,noauto      0       0
/dev/md6                /mnt/image2       ufs     rw,noauto      0       0

start mdconfig2:

$ /etc/rc.d/mdconfig2 start
Creating md5 device (vnode).
Mounting /dev/md5.

try to start/stop only md6:

$ /etc/rc.d/mdconfig2 start md6
/etc/rc.d/mdconfig2: ERROR: md5 already exists

[root@hulk /etc/rc.d]# /etc/rc.d/mdconfig2 stop md6
Umounting /dev/md5.
Destroying md5.
>Fix:
moving `load_rc_config $name` in the code to an earlier line fixes the problems

Patch attached with submission follows:

--- mdconfig2.orig	2009-08-06 12:33:04.000000000 +0800
+++ mdconfig2	2009-08-06 12:28:10.000000000 +0800
@@ -203,14 +203,14 @@
 	done
 }
 
+load_rc_config $name
+
 _mdconfig2_cmd="$1"
 if [ $# -gt 0 ]; then
         shift
 fi
 [ -n "$*" ] && _mdconfig2_list="$*"
 
-load_rc_config $name
-
 _mdconfig2_unit=0
 if [ -z "${_mdconfig2_list}" ]; then
 	while :; do


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Aug 6 06:32:55 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137470 

From: Garrett Cooper <yanegomi@gmail.com>
To: bug-followup@FreeBSD.org, kagesenshi.87@gmail.com
Cc:  
Subject: Re: conf/137470: [PATCH] /etc/rc.d/mdconfig2 : prioritize cli
 parameters for _mdconfig2_list over the value in rc.conf
Date: Mon, 2 Jan 2012 11:45:08 -0800

  Please refer to conf/122477 for a patch that does what you want.
  Thanks,
  -Garrett
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Thu Nov 1 19:42:13 UTC 2012 
State-Changed-Why:  
Related to conf/122477, please continue discussion there 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137470 
>Unformatted:
