From nobody@FreeBSD.org  Fri Jul 17 19:26:47 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 17720106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 17 Jul 2009 19:26:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 067D68FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 17 Jul 2009 19:26:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n6HJQksX054312
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 17 Jul 2009 19:26:46 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n6HJQk2r054311;
	Fri, 17 Jul 2009 19:26:46 GMT
	(envelope-from nobody)
Message-Id: <200907171926.n6HJQk2r054311@www.freebsd.org>
Date: Fri, 17 Jul 2009 19:26:46 GMT
From: Ruud Althuizen <ruud@il.fontys.nl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: <software>_flags appending
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         136875
>Category:       conf
>Synopsis:       [request] <software>_flags appending
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 17 19:30:02 UTC 2009
>Closed-Date:    Fri Oct 07 02:45:25 UTC 2011
>Last-Modified:  Fri Oct 07 02:45:25 UTC 2011
>Originator:     Ruud Althuizen
>Release:        7.2-STABLE
>Organization:
>Environment:
FreeBSD hyde.il.fontys.nl 7.2-STABLE FreeBSD 7.2-STABLE #0: Fri Jun 12 00:01:27 CEST 2009     root@hyde.il.fontys.nl:/usr/obj/usr/src/sys/HYDE  i386
>Description:
When configuring software in /etc/rc.conf I sometimes find that I want to append something to <software>_flags instead of overwriting it. This may be the case for long lines or lines where the defaults are sensible but just missing stuff.

For example in the mailgraph rc-script, the default is:
: ${mailgraph_flags="--logfile /var/log/maillog --daemon-rrd=/var/db/mailgraph --ignore-localhost --daemon --daemon-pid=${mailgraph_pidfile}"

I just want the '--rbl-is-spam' flag added. In this case another problem occurs, predefined variables are used (the pidfile). So that would mean I need to define both or define them in one go.
>How-To-Repeat:

>Fix:
I propose to have /etc/rc.subr line 594 (eval rc_flags=\$${name}_flags) expanded to include something like \$${name}_flags_append

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Jul 18 23:21:12 UTC 2009 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136875 
State-Changed-From-To: open->suspended 
State-Changed-By: eadler 
State-Changed-When: Tue Aug 2 03:38:19 UTC 2011 
State-Changed-Why:  
Suspend this awaiting patches. This is a great idea but we need patches 
to review. Perhaps you should mail -rc about this? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136875 
State-Changed-From-To: suspended->closed 
State-Changed-By: dougb 
State-Changed-When: Fri Oct 7 02:44:52 UTC 2011 
State-Changed-Why:  

Discussion on freebsd-rc@ is indeed the way to go here. 


Responsible-Changed-From-To: freebsd-rc->dougb 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Fri Oct 7 02:44:52 UTC 2011 
Responsible-Changed-Why:  

I closed it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136875 
>Unformatted:
