From nobody@FreeBSD.org  Sat May 16 14:48:34 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D950106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 16 May 2009 14:48:34 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6AD428FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 16 May 2009 14:48:34 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n4GEmYRN096935
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 16 May 2009 14:48:34 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n4GEmYKd096934;
	Sat, 16 May 2009 14:48:34 GMT
	(envelope-from nobody)
Message-Id: <200905161448.n4GEmYKd096934@www.freebsd.org>
Date: Sat, 16 May 2009 14:48:34 GMT
From: Lucius Windschuh <lwindschuh@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [devd.conf] Semicolon missing
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         134579
>Category:       conf
>Synopsis:       [devd.conf] Semicolon missing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 16 14:50:00 UTC 2009
>Closed-Date:    Mon May 25 10:13:50 UTC 2009
>Last-Modified:  Mon May 25 10:13:50 UTC 2009
>Originator:     Lucius Windschuh
>Release:        CURRENT
>Organization:
>Environment:
FreeBSD current 8.0-CURRENT FreeBSD 8.0-CURRENT #9 r192020M: Tue May 12 21:47:51 UTC 2009     root@current:/usr/obj/usr/src/sys/CURRENT  i386

>Description:
There is a semicolon missing in /etc/devd.conf, line 135:
# Firmware download for Entrega Serial DB25 adapter.
attach 100 {
  match "vendor"  "0x1645";
  match "product" "0x8001";
  match "release" "0x0101";
  action "if ! kldstat -n usio > /dev/null 2>&1 ; then kldload usio; fi /usr/sbin/ezdownload -v -f /usr/share/usb/firmware/1645.8001.0101 /dev/$device-name";
};

This produces an error when such an adaptor is plugged in:
  Syntax error: word unexpected

>How-To-Repeat:
Paste the action line into /bin/sh
>Fix:
Add a semicolon:

# Firmware download for Entrega Serial DB25 adapter.
attach 100 {
  match "vendor"  "0x1645";
  match "product" "0x8001";
  match "release" "0x0101";
  action "if ! kldstat -n usio > /dev/null 2>&1 ; then kldload usio; fi; /usr/sbin/ezdownload -v -f /usr/share/usb/firmware/1645.8001.0101 /dev/$device-name";
};

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Sat May 16 15:13:14 UTC 2009 
State-Changed-Why:  
Fixed in HEAD.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134579 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/134579: commit references a PR
Date: Sat, 16 May 2009 15:13:06 +0000 (UTC)

 Author: maxim
 Date: Sat May 16 15:12:56 2009
 New Revision: 192198
 URL: http://svn.freebsd.org/changeset/base/192198
 
 Log:
   o Add missed semicolon in action script.
   
   PR:		conf/134579
   Submitted by:	Lucius Windschuh
   MFC after:	1 week
 
 Modified:
   head/etc/devd.conf
 
 Modified: head/etc/devd.conf
 ==============================================================================
 --- head/etc/devd.conf	Sat May 16 14:30:08 2009	(r192197)
 +++ head/etc/devd.conf	Sat May 16 15:12:56 2009	(r192198)
 @@ -132,7 +132,7 @@ attach 100 {
  	match "vendor"	"0x1645";
  	match "product"	"0x8001";
  	match "release"	"0x0101";
 -	action "if ! kldstat -n usio > /dev/null 2>&1 ; then kldload usio; fi /usr/sbin/ezdownload -v -f /usr/share/usb/firmware/1645.8001.0101 /dev/$device-name";
 +	action "if ! kldstat -n usio > /dev/null 2>&1 ; then kldload usio; fi; /usr/sbin/ezdownload -v -f /usr/share/usb/firmware/1645.8001.0101 /dev/$device-name";
  };
  
  # This entry starts the ColdSync tool in daemon mode. Make sure you have an up
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Mon May 25 10:13:37 UTC 2009 
State-Changed-Why:  
Merged to RELENG_7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134579 
>Unformatted:
